diff mbox series

riscv: Allow -Wno-psabi to turn off ABI warnings [PR91229]

Message ID YjBw7ILOHjYx5h4r@tucnak
State New
Headers show
Series riscv: Allow -Wno-psabi to turn off ABI warnings [PR91229] | expand

Commit Message

Jakub Jelinek March 15, 2022, 10:56 a.m. UTC 
Hi!

While checking if all targets honor -Wno-psabi for ABI related warnings
or messages, I found that almost all do, except for riscv.
In the testsuite when we want to ignore ABI related messages we
typically use -Wno-psabi -w, but it would be nice to get rid of those
-w uses eventually.

The following allows silencing those warnings with -Wno-psabi rather than
just -w even on riscv.

Ok for trunk?

2022-03-15  Jakub Jelinek  <jakub@redhat.com>

	PR target/91229
	* config/riscv/riscv.cc (riscv_pass_aggregate_in_fpr_pair_p,
	riscv_pass_aggregate_in_fpr_and_gpr_p): Pass OPT_Wpsabi instead of 0
	to warning calls.


	Jakub

Comments

Kito Cheng March 15, 2022, 12:30 p.m. UTC | #1 
Hi Jakub:

LGTM, Thanks!

On Tue, Mar 15, 2022 at 6:57 PM Jakub Jelinek via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi!
>
> While checking if all targets honor -Wno-psabi for ABI related warnings
> or messages, I found that almost all do, except for riscv.
> In the testsuite when we want to ignore ABI related messages we
> typically use -Wno-psabi -w, but it would be nice to get rid of those
> -w uses eventually.
>
> The following allows silencing those warnings with -Wno-psabi rather than
> just -w even on riscv.
>
> Ok for trunk?
>
> 2022-03-15  Jakub Jelinek  <jakub@redhat.com>
>
>         PR target/91229
>         * config/riscv/riscv.cc (riscv_pass_aggregate_in_fpr_pair_p,
>         riscv_pass_aggregate_in_fpr_and_gpr_p): Pass OPT_Wpsabi instead of 0
>         to warning calls.
>
> --- gcc/config/riscv/riscv.cc.jj        2022-03-07 15:00:17.239592719 +0100
> +++ gcc/config/riscv/riscv.cc   2022-03-15 11:20:37.823661044 +0100
> @@ -2918,8 +2918,8 @@ riscv_pass_aggregate_in_fpr_pair_p (cons
>
>    if ((n_old != n_new) && (warned == 0))
>      {
> -      warning (0, "ABI for flattened struct with zero-length bit-fields "
> -              "changed in GCC 10");
> +      warning (OPT_Wpsabi, "ABI for flattened struct with zero-length "
> +                          "bit-fields changed in GCC 10");
>        warned = 1;
>      }
>
> @@ -2960,8 +2960,8 @@ riscv_pass_aggregate_in_fpr_and_gpr_p (c
>            && (num_int_old != num_int_new || num_float_old != num_float_new)))
>        && (warned == 0))
>      {
> -      warning (0, "ABI for flattened struct with zero-length bit-fields "
> -              "changed in GCC 10");
> +      warning (OPT_Wpsabi, "ABI for flattened struct with zero-length "
> +                          "bit-fields changed in GCC 10");
>        warned = 1;
>      }
>
>
>         Jakub
>
diff mbox series

Patch

--- gcc/config/riscv/riscv.cc.jj	2022-03-07 15:00:17.239592719 +0100
+++ gcc/config/riscv/riscv.cc	2022-03-15 11:20:37.823661044 +0100
@@ -2918,8 +2918,8 @@  riscv_pass_aggregate_in_fpr_pair_p (cons
 
   if ((n_old != n_new) && (warned == 0))
     {
-      warning (0, "ABI for flattened struct with zero-length bit-fields "
-	       "changed in GCC 10");
+      warning (OPT_Wpsabi, "ABI for flattened struct with zero-length "
+			   "bit-fields changed in GCC 10");
       warned = 1;
     }
 
@@ -2960,8 +2960,8 @@  riscv_pass_aggregate_in_fpr_and_gpr_p (c
 	   && (num_int_old != num_int_new || num_float_old != num_float_new)))
       && (warned == 0))
     {
-      warning (0, "ABI for flattened struct with zero-length bit-fields "
-	       "changed in GCC 10");
+      warning (OPT_Wpsabi, "ABI for flattened struct with zero-length "
+			   "bit-fields changed in GCC 10");
       warned = 1;
     }