diff mbox series

[committed] libstdc++: Suppress -Wstringop-overread warning in test

Message ID YMxyZCLVcID9FPMx@redhat.com
State New
Headers show
Series [committed] libstdc++: Suppress -Wstringop-overread warning in test | expand

Commit Message

Jonathan Wakely June 18, 2021, 10:16 a.m. UTC 
When compiled with -m32 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 we get a warning
for 21_strings/basic_string/cons/char/1.cc:

bits/char_traits.h:409:56: warning: ‘void* __builtin_memcpy(void*, const void*, unsigned int)’ reading 1073741821 bytes from a region of size 19 [-Wstringop-overread]

The warning is legitimate, even if that line cannot be reached because
we throw std::length_error before getting there. Since the invalid
length is deliberate (and mentioned in a comment) just suppress the
warning, so that the test can verify we get the exception.

Also remove an unused typedef that produces another warning.

libstdc++-v3/ChangeLog:

	* testsuite/21_strings/basic_string/cons/char/1.cc: Use
	diagnostic pragma to suppress -Wstringop-overread error.

Signed-off-by: Jonathan Wakely <jwakely@redhat.com>

Tested x86_64-linux. Committed to trunk.
commit 92edc4a7684cdad5d30e197b976c35b2257f7bed
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Jun 18 11:08:19 2021

    libstdc++: Suppress -Wstringop-overread warning in test
    
    When compiled with -m32 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 we get a warning
    for 21_strings/basic_string/cons/char/1.cc:
    
    bits/char_traits.h:409:56: warning: ‘void* __builtin_memcpy(void*, const void*, unsigned int)’ reading 1073741821 bytes from a region of size 19 [-Wstringop-overread]
    
    The warning is legitimate, even if that line cannot be reached because
    we throw std::length_error before getting there. Since the invalid
    length is deliberate (and mentioned in a comment) just suppress the
    warning, so that the test can verify we get the exception.
    
    Also remove an unused typedef that produces another warning.
    
    libstdc++-v3/ChangeLog:
    
            * testsuite/21_strings/basic_string/cons/char/1.cc: Use
            diagnostic pragma to suppress -Wstringop-overread error.
    
    Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
diff mbox series

Patch

diff --git a/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc b/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc
index 5549094553e..099921f0941 100644
--- a/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc
+++ b/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc
@@ -36,7 +36,6 @@  using namespace std;
 void test01(void)
 {
   typedef string::size_type csize_type;
-  typedef string::iterator citerator;
   csize_type npos = string::npos;
   csize_type csz01;
 
@@ -68,6 +67,8 @@  void test01(void)
 
   // basic_string(const char* s, size_type n, alloc)
   csz01 = str01.max_size();
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstringop-overread"
   // NB: As strlen(str_lit01) != csz01, this test is undefined. It
   // should not crash, but what gets constructed is a bit arbitrary.
   try {
@@ -94,6 +95,7 @@  void test01(void)
   catch(...) {
     VERIFY( false );
   }
+#pragma GCC diagnostic pop
 
   // Build a maxsize - 1 lengthed string consisting of all A's
   try {