From patchwork Mon Sep 28 05:27:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hurugalawadi, Naveen" X-Patchwork-Id: 523231 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 251D114090B for ; Mon, 28 Sep 2015 15:27:55 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=Lm5K8uT/; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:mime-version; q=dns; s=default; b=ishNt+tUqJ9CecKd yBuH9emlGLwwVIaKdOcCf8mBJ41q9z6EMijygevM4+CzdZfD+Wzl7XqVSuWkc2ok 17jq5GKceuII2Qx10Vkw68pIjohg4B9CMOp3cFQ9wGxSXesNGaWMQSYFJXJDODOT 2vKDdxGihGxNImg+ZAr7jcRdCCc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:mime-version; s=default; bh=XD+5EZLWXFBZf0usImT5OQ a3g+w=; b=Lm5K8uT/nZU5mkCgPQ0dvA4XbpK7y4BeCCJ2GqbK/byFi5/YFD0CwR 0W+5aSkqQjxvzGmwayAPD0+OS48AZOpzKR8VGJG9LcOOVw1cIFmKWa4IJJyiRV7k Xz73zAApDTVpBcOYMhU7q4oqyY7Vo9RQSkaNMMst7D0mZ2gnxGlvE= Received: (qmail 43806 invoked by alias); 28 Sep 2015 05:27:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 43794 invoked by uid 89); 28 Sep 2015 05:27:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: na01-by2-obe.outbound.protection.outlook.com Received: from mail-by2on0067.outbound.protection.outlook.com (HELO na01-by2-obe.outbound.protection.outlook.com) (207.46.100.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Mon, 28 Sep 2015 05:27:43 +0000 Received: from BN3PR0701MB1233.namprd07.prod.outlook.com (10.160.115.14) by BN3PR0701MB1591.namprd07.prod.outlook.com (10.163.38.26) with Microsoft SMTP Server (TLS) id 15.1.280.20; Mon, 28 Sep 2015 05:27:40 +0000 Received: from SN2PR0701MB1024.namprd07.prod.outlook.com (10.160.57.150) by BN3PR0701MB1233.namprd07.prod.outlook.com (10.160.115.14) with Microsoft SMTP Server (TLS) id 15.1.280.20; Mon, 28 Sep 2015 05:27:38 +0000 Received: from SN2PR0701MB1024.namprd07.prod.outlook.com ([10.160.57.150]) by SN2PR0701MB1024.namprd07.prod.outlook.com ([10.160.57.150]) with mapi id 15.01.0274.009; Mon, 28 Sep 2015 05:27:38 +0000 From: "Hurugalawadi, Naveen" To: Marcus Shawcroft CC: "gcc-patches@gcc.gnu.org" , "Pinski, Andrew" Subject: Re: [AArch64] Fix Prefetch ICE Date: Mon, 28 Sep 2015 05:27:37 +0000 Message-ID: References: , In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Naveen.Hurugalawadi@caviumnetworks.com; x-microsoft-exchange-diagnostics: 1; BN3PR0701MB1233; 5:8ADuLZXvtW3MuyUVbsBxnf6LUtX3MAx5/iAsc0mJgx82/CyGxyLUg1jHkPnxd+H6pc+tWNPXcdBkzWNugbkaRwf71W0frXz4NEOh0u2IY7tWybCfFfkyVbziZ72fyIl3E03rWe/Jf2YmF/+yOSFBKQ==; 24:5DaBWLMjNjv76GkWA3I3t/C2d6lHPEjH8OMTgu+nN2Vr/Uz65H8HA8D+hCDbdZX1/iiaL2eTabmlQUH9We2BNBH9KAPfJLH0rWQp7K0HIRQ=; 20:40U251iONAyILDZILt8Ka5OFk32J+HpcoyA4mjtaJeG84g71qDX7/Q93pvojJx2W3IHkPBCsRzw+k0V5RnkZpw== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1233; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001); SRVR:BN3PR0701MB1233; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1233; x-forefront-prvs: 0713BC207F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(51914003)(199003)(54534003)(377424004)(164054003)(189002)(11100500001)(40100003)(10400500002)(5001960100002)(105586002)(106356001)(76176999)(106116001)(110136002)(50986999)(19580405001)(97736004)(5001830100001)(81156007)(19580395003)(122556002)(4001540100001)(99936001)(107886002)(46102003)(189998001)(54356999)(68736005)(5001860100001)(2950100001)(76576001)(102836002)(62966003)(5004730100002)(92566002)(77156002)(77096005)(5007970100001)(2900100001)(64706001)(74316001)(5003600100002)(5890100001)(5002640100001)(33656002)(101416001)(86362001)(99286002)(87936001)(4001430100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1233; H:SN2PR0701MB1024.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2015 05:27:37.5041 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1233 X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1591; 2:QvcMZg5b44XlSG/3pR2P8xe6q68i+dC5QlSnVve+FLyJBjvSYjqxFawC0jbO6jwvi7wGK8Ih+F0eOiOv5RJj4YMfJPCxKS7guo4s30g3uIwW5krEfjPiFZXz/dQMyaxU3HkyRUVmRjctXJjRbLhHtNSxAvcMl/1Rjg3/t6uvuX4=; 23:TyPv+T4H9sIjMPFYd22aGK6eeUQCr/43ElPo3csOP2vocOcNQDVwTvaDBOYDb10yqR5rP16q7R/GsXFLDGss0JqDdggd9ADoRwlbjVodZN1o/yBNqW252cXYdM1wwJcOLmumt9IK1/KlliADHTvC+fv4VUPya5wkd9V4pWS8RNM/rVXi5+XFC6PqxSYt5BRW X-OriginatorOrg: caviumnetworks.com Hi Marcus, Thanks for the review and comments. >> OK and can you back port to 5 ? Please find attached the backported patch on gcc-5-branch. Regression tested on AArch64 without any issues. 2015-09-28 Andrew Pinski ChangeLog * config/aarch64/aarch64.md (prefetch): Change the predicate of operand 0 to register_operand. Thanks, Naveen Index: config/aarch64/aarch64.md =================================================================== --- config/aarch64/aarch64.md (revision 228182) +++ config/aarch64/aarch64.md (working copy) @@ -382,7 +382,7 @@ ) (define_insn "prefetch" - [(prefetch (match_operand:DI 0 "address_operand" "r") + [(prefetch (match_operand:DI 0 "register_operand" "r") (match_operand:QI 1 "const_int_operand" "") (match_operand:QI 2 "const_int_operand" ""))] ""