diff mbox

[obvious] Fix va_end calls

Message ID Pine.LNX.4.64.1204201636560.25409@wotan.suse.de
State New
Headers show

Commit Message

Michael Matz April 20, 2012, 2:40 p.m. UTC 
Hi,

On Thu, 19 Apr 2012, Michael Matz wrote:

> I've audited all other calls of va_end in the compiler and these were the 
> only problematic ones.

Well, I did, but forgot the fact that I found one in cp/error.c, so the 
generated diff and the commit forgot that file too.  It was in the 
regstrapped tree, so I've committed this now too as r186626.


Ciao,
Michael.
--------------------
	* error.c (pedwarn_cxx98): Move va_end call after user
	of the va_list.
diff mbox

Patch

Index: error.c
===================================================================
--- error.c	(revision 186625)
+++ error.c	(working copy)
@@ -3352,13 +3352,15 @@  pedwarn_cxx98 (location_t location, int
 {
   diagnostic_info diagnostic;
   va_list ap;
+  bool ret;
 
   va_start (ap, gmsgid);
   diagnostic_set_info (&diagnostic, gmsgid, &ap, location,
 		       (cxx_dialect == cxx98) ? DK_PEDWARN : DK_WARNING);
   diagnostic.option_index = opt;
+  ret = report_diagnostic (&diagnostic);
   va_end (ap);
-  return report_diagnostic (&diagnostic);
+  return ret;
 }
 
 /* Issue a diagnostic that NAME cannot be found in SCOPE.  DECL is what