From patchwork Thu Dec 29 13:33:23 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Rosen X-Patchwork-Id: 133541 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 819DAB6FBB for ; Fri, 30 Dec 2011 00:33:52 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1325770434; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:In-Reply-To:References:Subject:To:Cc: Message-ID:From:Date:MIME-Version:Content-type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=ejgmlPVzVCZ75ZmqZ2NZFtzBSDs=; b=nzd2vMexGD6HViYlHVQec2FyXQ3vl2j7Mp1F+O8ujdMWs3xKe5OxfVe5GwLyvH BaIwFt10y+XhtSuFzEtAq0bWeT/ec0Ov3bVT5/ffqZdltdnP70U3uggmG4c7U7su htlC9a7paukjUWQNu6bKfcWrQVzc2x1boCeiay4/w/zLY= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Received:In-Reply-To:References:Subject:X-KeepSent:To:Cc:Message-ID:From:Date:MIME-Version:Content-type:x-cbid:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=wWMFqR/iYNar+qFGMvs5G07+Wjon7IKphyjcQspiTwZQn2XubS/whw2UuMwDuT y8DquhuG1/So5EtD2EEi7aJkY16tgf81/3XnWkJtRUv3BPkINVoye0ed8VhQHpOj 0AzVcLilf/wl00WvA382RAtccPucUbJ1Xp+BrIn1DmvXE=; Received: (qmail 7261 invoked by alias); 29 Dec 2011 13:33:46 -0000 Received: (qmail 7252 invoked by uid 22791); 29 Dec 2011 13:33:44 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, TW_AV X-Spam-Check-By: sourceware.org Received: from e06smtp12.uk.ibm.com (HELO e06smtp12.uk.ibm.com) (195.75.94.108) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Dec 2011 13:33:30 +0000 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 29 Dec 2011 13:33:29 -0000 Received: from d06nrmr1507.portsmouth.uk.ibm.com ([9.149.38.233]) by e06smtp12.uk.ibm.com ([192.168.101.142]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 29 Dec 2011 13:33:27 -0000 Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pBTDXQO92150420 for ; Thu, 29 Dec 2011 13:33:26 GMT Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pBTDXQc4014297 for ; Thu, 29 Dec 2011 06:33:26 -0700 Received: from d06ml319.portsmouth.uk.ibm.com (d06ml319.portsmouth.uk.ibm.com [9.149.76.146]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id pBTDXQ9h014294; Thu, 29 Dec 2011 06:33:26 -0700 In-Reply-To: References: Subject: Re: [PATCH] PR testsuite/51097 fix: a lot of "FAIL: gcc.dg/vect" on i686 avx build 181167 to 181177 X-KeepSent: 9B23FCE9:37998EEB-C2257975:00452381; type=4; name=$KeepSent To: Igor Zamyatin Cc: gcc-patches@gcc.gnu.org Message-ID: From: Ira Rosen Date: Thu, 29 Dec 2011 15:33:23 +0200 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII x-cbid: 11122913-8372-0000-0000-0000013A89FA X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Igor Zamyatin wrote on 29/12/2011 02:29:46 PM: > > Because it includes AVX and AVX2 which deals with int and for AVX2 > there are no problems with doubled diagnostics. And you can't just update vect_int because AVX does support it but with 128-bit vectors, right? So, your vect_float_no_int looks incorrect as well. You need to describe the case when two vector sizes are analyzed, but the first one always fails. Maybe vect_sizes_32B_16B_noint? Probably ugly, but correct at least. I also suggest to simplify the checks and not to check the number of times a pattern was detected , like this: /* { dg-final { scan-tree-dump-times "pattern recognized" 1 "vect" { target vect_widen_mult_hi_to_si_pattern } } } */ /* { dg-final { cleanup-tree-dump "vect" } } */ And split the tests with several loops into several files, like, for example, vect-widen-mult-const-s16.c. The simplification is ok for slp-reduc-6.c, vect-119.c, vect-35-big-array.c as well. For the rest of the tests, I don't understand why there are alignment messages printed twice for two vector sizes. Why doesn't the vectorizer fail during vect_determine_vectorization_factor? Ira > > I understand that all this looks quite bulky but it's hard to create > something which looks better without loosing generality > > > On Thu, Dec 29, 2011 at 4:15 PM, Ira Rosen wrote: > > > > > > Igor Zamyatin wrote on 29/12/2011 02:04:45 PM: > > > >> When compiler configured with, say corei7-avx, it outputs twice more > >> diagnostics on integer tests since AVX deals mostly with floats. I.e. > >> compiler tries to vectorize on AVX vector size, than fails and then > >> vectorizes on smaller vector size. This double work leads to double > >> diagnostic output. > > > > OK, so you why not use vect_sizes_32B_16B? > > > > Ira > > > > > Index: vect-widen-mult-half.c =================================================================== --- vect-widen-mult-half.c (revision 182703) +++ vect-widen-mult-half.c (working copy) @@ -43,7 +43,7 @@ int main (void) } /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target vect_widen_mult_hi_to_si } } } */ -/* { dg-final { scan-tree-dump-times "vect_recog_widen_mult_pattern: detected" 1 "vect" { target vect_widen_mult_hi_to_si_pattern } } } */ +/* { dg-final { scan-tree-dump "vect_recog_widen_mult_pattern: detected" "vect" { target vect_widen_mult_hi_to_si_pattern } } } */