From patchwork Sun Nov 24 13:29:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 293745 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 097542C00DE for ; Mon, 25 Nov 2013 00:31:21 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=UnxfLeh+VUG569Q7rh /vjfw06LF0c4CYgU+3kxYz3XX58s8CbTcRzY1gBY+LMNrJ09dWQjcZ6wusCZnEm1 +ECwRKSvEcwpI7V913jLYp0P0fVlLJibMs4/zzdsv6jDVyWOgorjQr1qXbfgQkwx mPGROTR/nM6FHpypP77t9VhhE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=KfxIXIOjV+Rb/7Nu4HjIRgDJ N+A=; b=UVwu9Fzorpnv1bXQznmOAQwPy/riMu/7qBD/S9lAv1ACkdfIIH4/KlcI iv9dgf/82W68Ta8/uLcX87L3x8LejOo0OiAhJ6aFrzgkTUXPjNZ02RabnGlw0Ssa q+cGgUrvqMYQ54JTBNtHVYKPBNjQZLAiyGXZrY7ot4LfotpOOEk= Received: (qmail 32004 invoked by alias); 24 Nov 2013 13:30:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 31979 invoked by uid 89); 24 Nov 2013 13:30:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL, BAYES_50, FREEMAIL_FROM, RDNS_NONE, SPF_PASS, URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-ob0-f181.google.com Received: from Unknown (HELO mail-ob0-f181.google.com) (209.85.214.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 24 Nov 2013 13:29:17 +0000 Received: by mail-ob0-f181.google.com with SMTP id uy5so3096308obc.26 for ; Sun, 24 Nov 2013 05:29:09 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.182.113.195 with SMTP id ja3mr500703obb.46.1385299749132; Sun, 24 Nov 2013 05:29:09 -0800 (PST) Received: by 10.76.171.1 with HTTP; Sun, 24 Nov 2013 05:29:09 -0800 (PST) In-Reply-To: References: Date: Sun, 24 Nov 2013 05:29:09 -0800 Message-ID: Subject: Re: [PATCH] C++-ify and simplify loop iterators From: "H.J. Lu" To: Richard Biener Cc: GCC Patches X-IsSubscribed: yes On Tue, Nov 19, 2013 at 7:19 PM, H.J. Lu wrote: > On Tue, Nov 19, 2013 at 7:01 AM, Richard Biener wrote: >> >> $subject - the following turns >> >> loop_iterator li; >> FOR_EACH_LOOP (li, loop, LI_ONLY_INNERMOST) >> { >> ... >> if () >> FOR_EACH_LOOP_BREAK; >> } >> >> into >> >> FOR_EACH_LOOP (loop, LI_ONLY_INNERMOST) >> { >> ... >> if () >> break; >> } >> >> Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. >> >> Richard. >> >> 2013-11-19 Richard Biener >> >> * cfgloop.h (struct loop_iterator): C++-ify, add constructor >> and destructor and make fel_next a member function. >> (fel_next): Transform into ... >> (loop_iterator::next): ... this. >> (fel_init): Transform into ... >> (loop_iterator::loop_iterator): ... this. >> (loop_iterator::~loop_iterator): New. >> (FOR_EACH_LOOP): Remove loop-iterator argument. >> (FOR_EACH_LOOP_BREAK): Remove no longer necessary macro. >> * cfgloop.c, cfgloopmanip.c, config/mn10300/mn10300.c, >> graphite-clast-to-gimple.c, graphite-scop-detection.c, >> graphite-sese-to-poly.c, ipa-inline-analysis.c, ipa-pure-const.c, >> loop-init.c, loop-invariant.c, loop-unroll.c, loop-unswitch.c, >> modulo-sched.c, predict.c, sel-sched-ir.c, tree-cfg.c, tree-data-ref.c, >> tree-if-conv.c, tree-loop-distribution.c, tree-parloops.c, >> tree-predcom.c, tree-scalar-evolution.c, tree-ssa-dce.c, >> tree-ssa-loop-ch.c, tree-ssa-loop-im.c, tree-ssa-loop-ivcanon.c, >> tree-ssa-loop-ivopts.c, tree-ssa-loop-manip.c, tree-ssa-loop-niter.c, >> tree-ssa-loop-prefetch.c, tree-ssa-loop-unswitch.c, >> tree-ssa-threadupdate.c, tree-vectorizer.c, tree-vrp.c: Adjust >> uses of FOR_EACH_LOOP and remove loop_iterator variables. Replace >> FOR_EACH_LOOP_BREAK with break. >> > > This caused: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59199 > > H.J. The checkin contains: which isn't in the patch and isn't necessary. I am checking a patch to remove it. --- trunk/gcc/graphite-sese-to-poly.c 2013/11/19 15:02:27 205031 +++ trunk/gcc/graphite-sese-to-poly.c 2013/11/19 15:19:09 205032 @@ -56,6 +56,7 @@ #include "domwalk.h" #include "sese.h" #include "tree-ssa-propagate.h" +#include "expr.h" #ifdef HAVE_cloog #include "expr.h"