From patchwork Thu Oct 13 15:40:58 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: "H.J. Lu" <hjl.tools@gmail.com>
X-Patchwork-Id: 119555
Return-Path: 
 <gcc-patches-return-304348-incoming=patchwork.ozlabs.org@gcc.gnu.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	by ozlabs.org (Postfix) with SMTP id A86FBB71A4
	for <incoming@patchwork.ozlabs.org>;
	Fri, 14 Oct 2011 02:41:22 +1100 (EST)
Received: (qmail 19957 invoked by alias); 13 Oct 2011 15:41:17 -0000
Received: (qmail 19942 invoked by uid 22791); 13 Oct 2011 15:41:14 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0	tests=AWL, BAYES_00,
	DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM,
	RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com)
	(209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with
	ESMTP; Thu, 13 Oct 2011 15:40:59 +0000
Received: by qadc1 with SMTP id c1so157049qad.20 for
	<gcc-patches@gcc.gnu.org>; Thu, 13 Oct 2011 08:40:58 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.229.37.135 with SMTP id x7mr940387qcd.18.1318520458095;
	Thu, 13 Oct 2011 08:40:58 -0700 (PDT)
Received: by 10.229.83.146 with HTTP; Thu, 13 Oct 2011 08:40:58 -0700 (PDT)
In-Reply-To: <alpine.LNX.2.00.1110131353510.308@zhemvz.fhfr.qr>
References: <alpine.LNX.2.00.1110131353510.308@zhemvz.fhfr.qr>
Date: Thu, 13 Oct 2011 08:40:58 -0700
Message-ID: 
 <CAMe9rOpO63gv3HFa+KV67Ad6Y+zjN4souG-a0LR76p9fo9qfWg@mail.gmail.com>
Subject: Re: [PATCH] Fix PR50712
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Richard Guenther <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Unsubscribe: 
 <mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Delivered-To: mailing list gcc-patches@gcc.gnu.org

On Thu, Oct 13, 2011 at 4:55 AM, Richard Guenther <rguenther@suse.de> wrote:
>
> This fixes PR50712, an issue with IPA split uncovered by adding
> verifier calls after it ... we need to also gimplify reads of
> register typed memory when passing it as argument.
>
> Bootstrapped on x86_64-unknown-linux-gnu, testing in progress.
>
> Richard.
>
> 2011-10-13  Richard Guenther  <rguenther@suse.de>
>
>        PR tree-optimization/50712
>        * ipa-split.c (split_function): Always re-gimplify parameters
>        when they are not gimple vals before passing them.  Properly
>        check for type compatibility.
>
>        * gcc.target/i386/pr50712.c: New testcase.
>

This test is valid only for ia32, not ilp32. I checked in this patch
to fix it.

Index: gcc.target/i386/pr50712.c
===================================================================
--- gcc.target/i386/pr50712.c	(revision 179925)
+++ gcc.target/i386/pr50712.c	(working copy)
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { dg-require-effective-target ilp32 } */
+/* { dg-require-effective-target ia32 } */
 /* { dg-options "-O2" } */

 typedef __builtin_va_list __va_list;
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 179925)
+++ ChangeLog	(working copy)
@@ -1,3 +1,7 @@
+2011-10-13  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* gcc.target/i386/pr50712.c: Check ia32 instead of ilp32.
+
 2011-10-13  Eric Botcazou  <ebotcazou@adacore.com>

 	* gcc.dg/builtins-67.c: Guard iround and irint with HAVE_C99_RUNTIME.