| Message ID | CAKwh3qjbz9jgPhSg47KsjCXXeMdFJxXGHoZBMdYMqahw0uBK9g@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
Janus Weil wrote: > attached is a close-to-trivial patch which rejects the declaration of > 'abstract procedure pointers' (which is not a valid Fortran concept), > and thereby fixes an ICE-on-invalid. > > Regtested on x86_64-unknown-linux-gnu. Ok for trunk? Looks good to me. Thanks for the patch! > [In principle the ICE is a regression, but I don't think the patch is > worth backporting.] I concur. Tobias > 2013-12-16 Janus Weil <janus@gcc.gnu.org> > > PR fortran/54949 > * symbol.c (check_conflict): Forbid abstract procedure pointers. > (gfc_add_abstract): Check for attribute conflicts. > > > 2013-12-16 Janus Weil <janus@gcc.gnu.org> > > PR fortran/54949 > * gfortran.dg/proc_ptr_44.f90: New.
>> attached is a close-to-trivial patch which rejects the declaration of >> 'abstract procedure pointers' (which is not a valid Fortran concept), >> and thereby fixes an ICE-on-invalid. >> >> Regtested on x86_64-unknown-linux-gnu. Ok for trunk? > > Looks good to me. Thanks for the patch! Thanks! Committed as r206033. Cheers, Janus
Index: gcc/fortran/symbol.c =================================================================== --- gcc/fortran/symbol.c (revision 206019) +++ gcc/fortran/symbol.c (working copy) @@ -363,6 +363,7 @@ check_conflict (symbol_attribute *attr, const char *cray_pointee = "CRAY POINTEE", *data = "DATA", *value = "VALUE", *volatile_ = "VOLATILE", *is_protected = "PROTECTED", *is_bind_c = "BIND(C)", *procedure = "PROCEDURE", + *proc_pointer = "PROCEDURE POINTER", *abstract = "ABSTRACT", *asynchronous = "ASYNCHRONOUS", *codimension = "CODIMENSION", *contiguous = "CONTIGUOUS", *generic = "GENERIC"; static const char *threadprivate = "THREADPRIVATE"; @@ -593,6 +594,8 @@ check_conflict (symbol_attribute *attr, const char conf (procedure, asynchronous) conf (procedure, entry) + conf (proc_pointer, abstract) + a1 = gfc_code2string (flavors, attr->flavor); if (attr->in_namelist @@ -1440,7 +1443,8 @@ gfc_add_abstract (symbol_attribute* attr, locus* w } attr->abstract = 1; - return true; + + return check_conflict (attr, NULL, where); }
Hi all, attached is a close-to-trivial patch which rejects the declaration of 'abstract procedure pointers' (which is not a valid Fortran concept), and thereby fixes an ICE-on-invalid. Regtested on x86_64-unknown-linux-gnu. Ok for trunk? [In principle the ICE is a regression, but I don't think the patch is worth backporting.] Cheers, Janus 2013-12-16 Janus Weil <janus@gcc.gnu.org> PR fortran/54949 * symbol.c (check_conflict): Forbid abstract procedure pointers. (gfc_add_abstract): Check for attribute conflicts. 2013-12-16 Janus Weil <janus@gcc.gnu.org> PR fortran/54949 * gfortran.dg/proc_ptr_44.f90: New.