diff mbox

[ARM,testsuite] Fix gcc.target/arm/thumb-ifcvt.c

Message ID CAKdteOawBPiXJDoaSs7rcSzworcPvhNbauJhzL_-MhksN3_n7w@mail.gmail.com
State New
Headers show

Commit Message

Christophe Lyon June 16, 2015, 10:09 a.m. UTC
Hi,

Since Kyrill's r224367 (Restrict MAX_CONDITIONAL_EXECUTE when
-mrestrict-it is in place), gcc.target/arm/thumb-ifcvt.c fails when
testing a compiler configured to generate armv8 code by default (I
used --with-cpu=cortex-a57 for instance).

This is because -mrestrict-it is on by default for armv8-a. This patch
adds -mno-restrict-it to dg-options to remove this restriction.

The test now passes for arm-none-linux-gnueabihf --with-cpu=cortex-a57.

Ok to commit?

Thanks,

Christophe.

2015-06-16  Christophe Lyon  <christophe.lyon@linaro.org>

    * gcc.target/arm/thumb-ifcvt.c: Add -mno-restrict-it to
    dg-options.

Comments

Kyrylo Tkachov June 16, 2015, 10:12 a.m. UTC | #1
On 16/06/15 11:09, Christophe Lyon wrote:
> Hi,
>
> Since Kyrill's r224367 (Restrict MAX_CONDITIONAL_EXECUTE when
> -mrestrict-it is in place), gcc.target/arm/thumb-ifcvt.c fails when
> testing a compiler configured to generate armv8 code by default (I
> used --with-cpu=cortex-a57 for instance).
>
> This is because -mrestrict-it is on by default for armv8-a. This patch
> adds -mno-restrict-it to dg-options to remove this restriction.
>
> The test now passes for arm-none-linux-gnueabihf --with-cpu=cortex-a57.
>
> Ok to commit?

Ok.
Thanks,
Kyrill

>
> Thanks,
>
> Christophe.
>
> 2015-06-16  Christophe Lyon  <christophe.lyon@linaro.org>
>
>      * gcc.target/arm/thumb-ifcvt.c: Add -mno-restrict-it to
>      dg-options.
diff mbox

Patch

Index: gcc/testsuite/gcc.target/arm/thumb-ifcvt.c
===================================================================
--- gcc/testsuite/gcc.target/arm/thumb-ifcvt.c	(revision 224505)
+++ gcc/testsuite/gcc.target/arm/thumb-ifcvt.c	(working copy)
@@ -1,7 +1,7 @@ 
 /* Check that Thumb 16-bit shifts can be if-converted.  */
 /* { dg-do compile } */
 /* { dg-require-effective-target arm_thumb2_ok } */
-/* { dg-options "-O2 -mthumb" } */
+/* { dg-options "-O2 -mthumb -mno-restrict-it" } */
 
 int
 foo (int a, int b)