From patchwork Tue Apr 11 16:26:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 749558 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w2XW60ZXlz9sNS for ; Wed, 12 Apr 2017 02:26:41 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="bjxNlk2L"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; q=dns; s=default; b=mWTCvE3wy38dH6e wtzaivrRAPgCcwMy5rZC959Or/08ATjuRwJSU303lcKKaB7VwpefV5MZSOUOvyrj mkVrMRkOA1tzdVZO5+71wAdQ05JsrCGxvDYT+a98gfmoGAzThWjrmbby1Fj9EH4+ w9fzkMWtgwxVr4Me4CCQVUagq3jY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; s=default; bh=vAXkSlz1iqmk+DD8l6We8 YQ0aG8=; b=bjxNlk2Lx6HPBTpGKKpzNvkTTUgxRgWNPifnYNPjpP2OXVjFeHNpJ G8uZR9QLCvjaQhn304nApPg+kmYBjezzCuPAZhsKYlXD+2kDRTX6D0sjV/k3+YVM 79z75DOicZS+mkk6E8yfnT6hDhFVoK+k0+amDAuObCueOQiHM2cSJ0= Received: (qmail 119041 invoked by alias); 11 Apr 2017 16:26:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 118571 invoked by uid 89); 11 Apr 2017 16:26:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=649 X-HELO: mail-qt0-f181.google.com Received: from mail-qt0-f181.google.com (HELO mail-qt0-f181.google.com) (209.85.216.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Apr 2017 16:26:17 +0000 Received: by mail-qt0-f181.google.com with SMTP id c45so2010526qtb.1 for ; Tue, 11 Apr 2017 09:26:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6ZBCaN3eg42yNNswP+YYoTcbgAv0KenG17CHcNgQk+o=; b=DQrNKPd7lebmyvs3avSVXUiRqyVNyrsCCKg4Q5nOs3Sp0z+9U32jBLx2YNcTBun9Dr +5+egQtRieCVLRXrk2gtN19UDZOtxXfcqkfvT6D/ad6GjQh5Px0JVFHC+EAfUlBhwVgk UQIlZG2iyVi6XL/4ucGiAq0IWg5ErIorsT6IcNZ2iZrqT64N2B3+nXnimOgFi0Y/FqL1 FFvicJRGases1UcqFjXdkJefXh3cMyFMa3iIZyYjQHZ9ExQZUwhv8TyWXKYg8XSUPUPf fTCn5zCQFL/EhsHH/37l4HC1iZujV140kwq/5mm2kSaZHpT15sXSD5uLrN7V0KchDOGN EMUQ== X-Gm-Message-State: AFeK/H0y1Y2d+vPiDhtQR/w2D/CgQcV5TWn4khIEYxz1t4aOwiJPmzHAOLBUPj3L1Yh6HtNXdA/i12Tc7LHnhmkt X-Received: by 10.200.45.57 with SMTP id n54mr62319851qta.212.1491927976958; Tue, 11 Apr 2017 09:26:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.104.76 with HTTP; Tue, 11 Apr 2017 09:26:16 -0700 (PDT) In-Reply-To: References: <930934bd-0341-6607-3d7e-96c34cebbabc@redhat.com> From: Christophe Lyon Date: Tue, 11 Apr 2017 18:26:16 +0200 Message-ID: Subject: Re: One more path to fix PR70478 To: Vladimir Makarov Cc: gcc-patches X-IsSubscribed: yes On 11 April 2017 at 17:42, Vladimir Makarov wrote: > > > On 04/11/2017 03:30 AM, Christophe Lyon wrote: >> >> Hi Vladimir, >> >> On 10 April 2017 at 17:05, Vladimir Makarov wrote: >>> >>> This is the second try to fix >>> >>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70478 >>> >>> The first try patch triggered a latent bug and broke one Fortran >>> testcase >>> on x86-64. >>> >>> The patch was successfully bootstrapped on x86-64 and tested on >>> x86-64, >>> ppc64, and aarch64. >>> >>> Committed as rev. 246808. >>> >>> >> I would have to re--run the build/test manually to get the generated >> code, let me know if it's needed. > > Yes, Christophe. It would be helpful. I've tried to reproduce it but I > don't see the difference in the generated code. > Here is what I observed (the "with-patch file is with your commit r246808, the other is r246807) Christophe --- armv8_2-fp16-move-1.s 2017-04-11 16:23:46.795264234 +0000 +++ armv8_2-fp16-move-1.s.with-patch 2017-04-11 15:54:52.563210963 +0000 @@ -37,8 +37,8 @@ @ frame_needed = 0, uses_anonymous_args = 0 @ link register save eliminated. lsl r1, r1, #1 - add r3, r0, r1 - vld1.16 {d0[0]}, [r3] + ldrh r3, [r0, r1] @ __fp16 + vmov.f16 s0, r3 @ __fp16 bx lr .size test_load_2, .-test_load_2 .align 2 @@ -64,9 +64,9 @@ @ args = 0, pretend = 0, frame = 0 @ frame_needed = 0, uses_anonymous_args = 0 @ link register save eliminated. + vmov.f16 r3, s0 @ __fp16 lsl r1, r1, #1 - add r3, r0, r1 - vst1.16 {d0[0]}, [r3] + strh r3, [r0, r1] @ __fp16 bx lr .size test_store_2, .-test_store_2 .align 2