From patchwork Tue Jan 26 18:02:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 1431836 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=l8d+b+w9; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DQF2k4m6cz9sVn for ; Wed, 27 Jan 2021 05:03:09 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C0FA23870867; Tue, 26 Jan 2021 18:03:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C0FA23870867 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1611684187; bh=96SR/eWAkDzOo+EHlJU5+3UhLMbIgq6+6JC0h4z0sAs=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=l8d+b+w9g4eaMhdciINwZAMCdBgJ7Pv80i4X/Eq1W82gX/qia6+aEolk4hcTLQRpU LGSlaobYSZKbsUKjzyaTHYe17Gd94wYXvHsyRY/7xpg20Kvy7+0xKiP7I6uQr1jc9a MyJhdsRw2KPJf5RRGPH0ozMuk+ZgjoiQAA52SMBw= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id B3B42386F406 for ; Tue, 26 Jan 2021 18:03:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B3B42386F406 Received: by mail-oi1-x232.google.com with SMTP id a77so2090128oii.4 for ; Tue, 26 Jan 2021 10:03:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=96SR/eWAkDzOo+EHlJU5+3UhLMbIgq6+6JC0h4z0sAs=; b=NhFFmPj1rDgIhXOQhdlPFo1RGn5hvTbPVihN5k5ZHGh7Zi+gwjiPD5+jEKH3hm3L8W Hcu0HzGTAr/ahrbEmYuhR8mhcbuIfhSyLbyzgIlkhXQPi8pUihXAzmau6S/xJZO6AQRM 0T1YZklTVrJ/RNQSLvjIF2RqN/CK90RuX5afnazldeAWe5LZl1F9eya/SKVVTJbJju5a 0ePTS32vYsgNbp6MHjP4Tiuy/k7uYNLEuM46DXk4mjwEpasK9RgpD3gUwvDMcn/Mnvjg pW1D8tEJIqQFRydLuaduqO/YcObX2ckcrotmbhPFJCXVON8R8eAaPqrNAJRLYiXwlygc lSEw== X-Gm-Message-State: AOAM530SWJ2TFV23iCmE6PUZOOGPU1d/RxSQVhtoMQaDqW5AWVVDUqhW TIlPWflff0MKXX5JKnJU2pW7TDJbFgc2bXG6LCrWzCYOnjzWZA== X-Google-Smtp-Source: ABdhPJxrRFX2Q2ikHeEKIMvtTcxwmsvQCKZU+biSuG1qWLdT5pwVqcSSFp4nOxzwBcFuvMJ0U/qGz2dh5GfFZM8I+MY= X-Received: by 2002:aca:d5c5:: with SMTP id m188mr599119oig.114.1611684183397; Tue, 26 Jan 2021 10:03:03 -0800 (PST) MIME-Version: 1.0 Date: Tue, 26 Jan 2021 19:02:52 +0100 Message-ID: Subject: arm: Adjust cost of vector of constant zero To: gcc Patches X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christophe Lyon via Gcc-patches From: Christophe Lyon Reply-To: Christophe Lyon Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Neon vector comparisons have a dedicated version when comparing with constant zero: it means its cost is free. Adjust the cost in arm_rtx_costs_internal accordingly, for Neon only, since MVE does not support this. 2021-01-26 Christophe Lyon gcc/ PR target/98730 * config/arm/arm.c (arm_rtx_costs_internal): Adjust cost of vector of constant zero for comparisons. gcc/testsuite/ PR target/98730 * gcc.target/arm/simd/vceqzq_p64.c: Update expected result. +/* { dg-final { scan-assembler-times "vceq\.i32\[ \t\]+\[dD\]\[0-9\]+, ?\[dD\]\[0-9\]+, #0\n" 2 } } */ diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 4a5f265..9c5c0df 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -11544,7 +11544,28 @@ arm_rtx_costs_internal (rtx x, enum rtx_code code, enum rtx_code outer_code, && (VALID_NEON_DREG_MODE (mode) || VALID_NEON_QREG_MODE (mode))) || TARGET_HAVE_MVE) && simd_immediate_valid_for_move (x, mode, NULL, NULL)) - *cost = COSTS_N_INSNS (1); + { + *cost = COSTS_N_INSNS (1); + + /* Neon has special instructions when comparing with 0 (vceq, vcge, + vcgt, vcle and vclt). */ + if (TARGET_NEON && (x == CONST0_RTX (mode))) + { + switch (outer_code) + { + case EQ: + case GE: + case GT: + case LE: + case LT: + *cost = COSTS_N_INSNS (0); + break; + + default: + break; + } + } + } else *cost = COSTS_N_INSNS (4); return true; diff --git a/gcc/testsuite/gcc.target/arm/simd/vceqzq_p64.c b/gcc/testsuite/gcc.target/arm/simd/vceqzq_p64.c index 640754c..a99bb8a 100644 --- a/gcc/testsuite/gcc.target/arm/simd/vceqzq_p64.c +++ b/gcc/testsuite/gcc.target/arm/simd/vceqzq_p64.c @@ -15,4 +15,4 @@ void func() result2 = vceqzq_p64 (v2); } -/* { dg-final { scan-assembler-times "vceq\.i32\[ \t\]+\[dD\]\[0-9\]+, ?\[dD\]\[0-9\]+, ?\[dD\]\[0-9\]+\n" 2 } } */