From patchwork Thu Jan 9 17:59:22 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 308903 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5369A2C00B8 for ; Fri, 10 Jan 2014 04:59:32 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=CIrpRFBQzZlbP5g5qW 1GGQkHURekfV4HjvgNq+EUVhQjl7NyyQV3muTOjLcK+7/uSsikAGNg+0k8+7XAbD PjzNmtR3be/QWUfMsBsLT6OtJ5qUlPJWNJ/I7+qJx0wgrV74aTiA6pEr/C1Ffz0N DowiKC413GKwkEq1RXpUJEfp4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=SBeIzWUOqIAh9endXGPIBAhH gjA=; b=hVJ0xNUY5WHWD5Zpi8lTS7T+jbJkQObOwuI8Bi+TsbS5pRQ02xExrfrW I47BP5Kf3OryYqqiTvNaLtCwD9zElReFXUnaNNe5k+CCU/th8wirH0gWSNbnN9+q 0WPh4sreOEVs82TtnzwJB5kfC8FXw14+aop2w4vWM0wkfMIgYGg= Received: (qmail 13766 invoked by alias); 9 Jan 2014 17:59:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 13752 invoked by uid 89); 9 Jan 2014 17:59:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f53.google.com Received: from mail-oa0-f53.google.com (HELO mail-oa0-f53.google.com) (209.85.219.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 09 Jan 2014 17:59:24 +0000 Received: by mail-oa0-f53.google.com with SMTP id h16so3821585oag.12 for ; Thu, 09 Jan 2014 09:59:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=GvOl6vtgNdrvcFKu88fjw6NawtL5ukhCHqzoYwudXm4=; b=fSpFiWKBa23u2gDSY54sUW9QmRYqIB9MDZXjeiC9I1kGGUI/+AqyxRUjLLOBKK7sBh wlOXsyEL7WOKb/UHGY5VskUOC8CW5QZNV2U19nJ32iZy4RgJeHaPGP6cPYxsRMRoWl9L g95YMjEDsnyaBQ6myf6b/EDyIHj5eN65MMQzn3GErXCv3HbvQ+kjvrB60eFqo1pwhL5q 9ig3CUfzECT5MojwcDBoV9nGqRBy3YPc4/DtJzsSeoP88VXCHuvxLK3Q0SX+cF9xBZhh KkOnJt7p2d8Loahcj1O+orKOucCRZpDBeTNkplvqhYYD9ap7vH52MEFo6LpZ9RawYT5l iZAw== X-Gm-Message-State: ALoCoQkCRkI/A4srnJqVRwgQXZiW/MceJ1FGFULbsHg1Q1uwoV5yBY+ieHn70+liO/5tb//LqUbY9WY+h2mQ2/++f3VSiYQwaTdcU3OXdDearklEzNY4RKlnDX8ffpcOXFuHt2CTJUvkqLMGXOlFWlDxVOGPLkxCqTWv58550Oths5W1m5w0IFLFXJt6Nr+EL04Ed7Nvu6VvgqqeCDQIVo3YWZhaRCZDCQ== MIME-Version: 1.0 X-Received: by 10.60.62.199 with SMTP id a7mr2287812oes.64.1389290362155; Thu, 09 Jan 2014 09:59:22 -0800 (PST) Received: by 10.60.39.170 with HTTP; Thu, 9 Jan 2014 09:59:22 -0800 (PST) In-Reply-To: References: Date: Thu, 9 Jan 2014 09:59:22 -0800 Message-ID: Subject: Re: [PATCH, go]: Skip some go tests From: Ian Lance Taylor To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" X-IsSubscribed: yes On Thu, Jan 9, 2014 at 2:54 AM, Uros Bizjak wrote: > > There are two remaining warnings: > > go.test/test/nilcheck.go: unrecognized test line: // errorcheck -0 -N -d=nil > go.test/test/nilptr3.go: unrecognized test line: // errorcheck -0 -d=nil Thanks, not sure how I missed those. Those tests are really testing specific gc compiler behaviour anyhow, so we should just skip them with gccgo. This patch does that. Committed to mainline. Ian 2014-01-09 Ian Lance Taylor * go.test/go-test.exp (go-gc-tests): Skip nilptr tests that test the other Go compiler. unsupported $name Index: go.test/go-test.exp =================================================================== --- go.test/go-test.exp (revision 206473) +++ go.test/go-test.exp (working copy) @@ -1143,6 +1143,10 @@ proc go-gc-tests { } { || $test_line == "// \$G \$D/pkg.go && pack grcS pkg.a pkg.\$A 2> /dev/null && rm pkg.\$A && \$G -I. -u \$D/main.go" } { # This tests the gc -u option, which gccgo does not # support. + } elseif { $test_line == "// errorcheck -0 -N -d=nil" \ + || $test_line == "// errorcheck -0 -d=nil" } { + # This tests gc nil pointer checks using -d=nil, which + # gccgo does not support. } else { clone_output "$name: unrecognized test line: $test_line"