From patchwork Mon Jun 12 01:18:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Edelsohn X-Patchwork-Id: 1793739 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=vP0+bpT6; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QfYk04hL9z20Vx for ; Mon, 12 Jun 2023 11:19:03 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CCCD13858433 for ; Mon, 12 Jun 2023 01:19:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CCCD13858433 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1686532740; bh=JAKHRKkz9u4MyzJGI9mRx9/pH9uIRhywYs5pVjqVmUM=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=vP0+bpT6KAZ1w4la34cFAI+3GeOOtPCsrn5BEQvBU9Wo+eO5ZhPKjzc8jD6qir1iM 3HruyA1g7laCbQJRt2XtV8cMQ32v146QHRcMJGhhpfk0J4Xkb6/ifJeDBjSLe98ZxJ cWGe7OQ56XH7FAgH6XppouhoBoBbMBAdayce/jsc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id DF0E33858D32 for ; Mon, 12 Jun 2023 01:18:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF0E33858D32 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-51494659d49so6784002a12.3 for ; Sun, 11 Jun 2023 18:18:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686532720; x=1689124720; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JAKHRKkz9u4MyzJGI9mRx9/pH9uIRhywYs5pVjqVmUM=; b=O9whQts29eXNRfboVOLBR6i5RFdK4GHq3AACDEZ4Ti94CpGFrAcpoOmKukcyBUb3YT 6pCEl7Kry73uqQcTfK6fdjawGdIrSdSGVm4gaYiCUEC6uoDVn6x2EDyv/bb6xfx4yR9H HnKGr6uDvtPL1YCx+AIlGd7m6OEpUP+mZvA8rmAKHzmXIkQuBIuIEUuztKWPzYLTP1b1 2rJDQga8jB76YWY/FWyHQy62ekTBaBcjmGUoCk7Sp81uc6ISD491uhdUvtZv3kmp8AuL huPq5vGtEAiGtgbT9DSFQkOGBnWnRM7Eo+fcMPNz+hdcuojJ0nKuvRgL8xO1JWin2cSP ZzPA== X-Gm-Message-State: AC+VfDy7aN2Z+a04tQ1O83eqUG8FBLaZHddcIo4ScQDzdO840++2EN0P JI0GAv4Gg3YcNlL54jhssJZwbd/+6d+Eg2/1wUsYB/I3YOY= X-Google-Smtp-Source: ACHHUZ4iq5Wl6mJMXG+D3qfUHVDtza0WyiC+YmjVSZDbnOzQfjxco3hvI0xN4bcnHzHM0OPCFpMp+BsCFh4BEiGJNyI= X-Received: by 2002:a17:907:8a12:b0:978:928:3b99 with SMTP id sc18-20020a1709078a1200b0097809283b99mr8685654ejc.46.1686532719786; Sun, 11 Jun 2023 18:18:39 -0700 (PDT) MIME-Version: 1.0 Date: Sun, 11 Jun 2023 21:18:28 -0400 Message-ID: Subject: [PATCH, AIX] Debugging does not require a stack frame. To: GCC Patches X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Edelsohn via Gcc-patches From: David Edelsohn Reply-To: David Edelsohn Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" The rs6000 port has allocated a stack frame when debugging is enabled on AIX since the earliest versions of the port. Apparently the earliest versions of the debuggers for AIX had difficulty with stackless frames. Both AIX DBX and GDB support stackless frames on AIX, and IBM XLC, OpenXL and LLVM for AIX do not generate an extraneous stack frame when debugging is enabled. This patch updates the rs6000 stack info function to not set the.stack frame flag when debugging is enabled for AIX. Bootstrapped on powerpc-ibm-aix7.2.5.0 Committed. Thanks, David * gcc/config/rs6000/rs6000-logue.cc (rs6000_stack_info): Do not require a stack frame when debugging is enabled for AIX. index bc6b153b59f..98846f781ec 100644 --- a/gcc/config/rs6000/rs6000-logue.cc +++ b/gcc/config/rs6000/rs6000-logue.cc @@ -928,9 +928,6 @@ rs6000_stack_info (void) else if (frame_pointer_needed) info->push_p = 1; - else if (TARGET_XCOFF && write_symbols != NO_DEBUG && !flag_compare_debug) - info->push_p = 1; - else info->push_p = non_fixed_size > (TARGET_32BIT ? 220 : 288);