From patchwork Thu Aug 26 18:57:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Edelsohn X-Patchwork-Id: 1521298 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=dKookO/g; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GwXDL5WHhz9sPf for ; Fri, 27 Aug 2021 04:58:10 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9D3EA3857C71 for ; Thu, 26 Aug 2021 18:58:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D3EA3857C71 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1630004287; bh=M115AddNPax9axnVCJ41FjFEoTOlSQ98LQLTxq72tWo=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dKookO/gilENNKEVriAujkCEkjnruTIXOAtN+yoA6L08ZozwBJ7vuWuOOdtOQf/gT cDraqQ7rS+PMKq1kfp7yXSuIVXkrvs7Gfqa3vjOIag4HAz8gR7EbN3xidhqUJ8Hus7 m835Cl9GR1RyS63Yw9BYNZoe4dJUN6pzYUbuXaS4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by sourceware.org (Postfix) with ESMTPS id D8DC43858D3C for ; Thu, 26 Aug 2021 18:57:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D8DC43858D3C Received: by mail-vs1-xe33.google.com with SMTP id i23so2797680vsj.4 for ; Thu, 26 Aug 2021 11:57:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M115AddNPax9axnVCJ41FjFEoTOlSQ98LQLTxq72tWo=; b=Fg9K5NVweDWVJFcECw6piEtBAjs7fI8FzdfeFrZtaQaYmed/O31N/yT7jhRq9vVLtY mT8+37a//+w/9XLYgSpBCUqYNhNA4AF7iF08RMXq47gYzMNU8at2OS/N6ZpOfFZ9XsvU kULvMbKJdOFVghHqP0SXj/Mjz2Fd2GXxeL+ICj6TN21RMcJKkAmeeSovBvzYXj4dYdvB /LKoNldmjN3OYQwTFP+Ht1NLSaBmmHquvCuN8HUBmu9dchgCOF05AkuTqdMSmLB5DIn5 ULQ06n3LgJN/f5iWYPfOLK49411hnlIBmkq/P8d6PrH8mmttfy/sGNP8nMYvqzZ6sWBx cILg== X-Gm-Message-State: AOAM530uFHvzy9l6taKbzKfRgfMTaBtecu4J9ycp6Ez6RfpU/S7O4njK I87JR6c92Y5rN/1FPoVKwMs8b+70hZIOPWfu+uQKBkeQ4lDBEA== X-Google-Smtp-Source: ABdhPJxb2lvdr082N9L0cFsjMyT3hbor0p5dP8BmfL7nJn+dR/RtGgOusIgfwbRyVC4eKwO5jotlJ5VO28+nfsbTfxU= X-Received: by 2002:a67:e8d0:: with SMTP id y16mr4201346vsn.51.1630004266368; Thu, 26 Aug 2021 11:57:46 -0700 (PDT) MIME-Version: 1.0 References: <87pmu0wt52.fsf@igel.home> In-Reply-To: <87pmu0wt52.fsf@igel.home> Date: Thu, 26 Aug 2021 14:57:35 -0400 Message-ID: Subject: [PATCH v2] Inline IBM long double __gcc_qsub To: Andreas Schwab , Segher Boessenkool X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Edelsohn via Gcc-patches From: David Edelsohn Reply-To: David Edelsohn Cc: David Edelsohn via Gcc-patches Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" While performing some tests of IEEE 128 float for PPC64LE, Michael Meissner noticed that __gcc_qsub is substantially slower than __gcc_qadd. __gcc_qsub calls __gcc_add with the second operand negated. Because the functions normally are invoked through libgcc shared object, the extra PLT overhead has a large impact on the overall time of the function. This patch converts __gcc_qadd to a static inline function invoked by __gcc_qadd and __gcc_qsub. libgcc/ChangeLog: * config/rs6000/ibm-ldouble.c (ldouble_qadd_internal): Rename from __gcc_qadd. (__gcc_qadd): Call ldouble_qadd_internal. (__gcc_qsub): Call ldouble_qadd_internal with second long double argument negated. diff --git a/libgcc/config/rs6000/ibm-ldouble.c b/libgcc/config/rs6000/ibm-ldouble.c index 4c13453f975..0b385aa940b 100644 --- a/libgcc/config/rs6000/ibm-ldouble.c +++ b/libgcc/config/rs6000/ibm-ldouble.c @@ -118,8 +118,8 @@ pack_ldouble (double dh, double dl) } /* Add two 'IBM128_TYPE' values and return the result. */ -IBM128_TYPE -__gcc_qadd (double a, double aa, double c, double cc) +static inline IBM128_TYPE +ldouble_qadd_internal (double a, double aa, double c, double cc) { double xh, xl, z, q, zz; @@ -158,9 +158,15 @@ __gcc_qadd (double a, double aa, double c, double cc) } IBM128_TYPE -__gcc_qsub (double a, double b, double c, double d) +__gcc_qadd (double a, double aa, double c, double cc) +{ + return ldouble_qadd_internal (a, aa, c, cc); +} + +IBM128_TYPE +__gcc_qsub (double a, double aa, double c, double cc) { - return __gcc_qadd (a, b, -c, -d); + return ldouble_qadd_internal (a, aa, -c, -cc); } #ifdef __NO_FPRS__