From patchwork Fri May 7 09:18:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 1475411 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=MYq1Xg6p; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fc4cr3jd6z9sj5 for ; Fri, 7 May 2021 19:18:34 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 15CDD3835815; Fri, 7 May 2021 09:18:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 15CDD3835815 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1620379112; bh=kzaUQVPUiy4q4y+3fpsO0VSRUBO/8ax9fMcXSzWEpow=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=MYq1Xg6pAaUNgZ21r0bm5GbbG2ukrgYRTnEZ5RkL9QauyWLGtNSYoQuySYX5IWmCW Kpf7i6sRcOya00i3h79+OYckJdHnR2BRHa3j4XnxfaY2qZtZzKiVXfFTmaXUGwyWkQ /8oIXBXkkhv7tbQ+lsBtp5tB7KX0Ss4lNYwfvCvQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by sourceware.org (Postfix) with ESMTPS id 1B5403858024 for ; Fri, 7 May 2021 09:18:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1B5403858024 Received: by mail-qt1-x836.google.com with SMTP id 1so6154352qtb.0 for ; Fri, 07 May 2021 02:18:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=kzaUQVPUiy4q4y+3fpsO0VSRUBO/8ax9fMcXSzWEpow=; b=rbp35bbJKU7Km1oDMCeMVuEtMhBo6a1IdAot7Ca5uUeIK2UuNPF1tuz2z6vd178zv0 32rVHPI7No3HUqo6+kFEzPV0hKUegwQwkEwQUBmGSj8bmIt0t+ADrk8Qg2aUhJZQqyE+ qwvUq2xZtqCZQYaOrvHAX2FvCiy/4XTU04Lm8xDyJiBvJ27a9t0WRUZ6pcpMMR884jq9 Q9tG5HJ7Niovle9B/2+qjewmLZYJoSzxiLC8SlXhjEzMfyyNGHhjybpQBF/A+pw7X3DV zc8jusIQS2CiH4cQz0H6I8WujwP65+6kn0yUngrszau2qy/aGpQ8knYqRQsJUwQ8jDfw Tl8A== X-Gm-Message-State: AOAM532CB8aNyViesfv2K6w6bL6a5lGAf4nKsQEa/ZDOog3oYjm2iubp 22BzTH5bcMOdwyg03gGqLeCYlNBP9hbMsbEXzm1X5fx3lBSiaw== X-Google-Smtp-Source: ABdhPJznUPd93zKRSoW/rJc36TqKkoim2SLwoYnYbaMAYymyhiTSi7DMPlxYyIvU+VRKQ6RU8DYE4FRTRPbIGr9TVdg= X-Received: by 2002:ac8:5781:: with SMTP id v1mr8643878qta.51.1620379109396; Fri, 07 May 2021 02:18:29 -0700 (PDT) MIME-Version: 1.0 Date: Fri, 7 May 2021 11:18:18 +0200 Message-ID: Subject: [PATCH] i386: Do not emit mask compares for mode sizes < 16 [PR100445] To: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Uros Bizjak via Gcc-patches From: Uros Bizjak Reply-To: Uros Bizjak Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Recent addition of v*cond* patterns for MMXMODEI modes allows 64bit MMX modes to enter ix86_expand_sse_cmp. ix86_use_mask_cmp_p was not prepared to reject mode sizes < 16, resulting in ICE due to unavailability of 64bit masked PCOM instructions. 2021-05-07 Uroš Bizjak gcc/ PR target/100445 * config/i386/i386-expand.c (ix86_use_mask_cmp_p): Return false for mode sizes < 16. gcc/testsuite/ PR target/100445 * gcc.target/i386/pr100445-1.c: New test. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Pushed to master. Uros. diff --git a/gcc/config/i386/i386-expand.c b/gcc/config/i386/i386-expand.c index 4dfe7d6c282..61b2f921f41 100644 --- a/gcc/config/i386/i386-expand.c +++ b/gcc/config/i386/i386-expand.c @@ -3490,7 +3490,11 @@ static bool ix86_use_mask_cmp_p (machine_mode mode, machine_mode cmp_mode, rtx op_true, rtx op_false) { - if (GET_MODE_SIZE (mode) == 64) + int vector_size = GET_MODE_SIZE (mode); + + if (vector_size < 16) + return false; + else if (vector_size == 64) return true; /* When op_true is NULL, op_false must be NULL, or vice versa. */ diff --git a/gcc/testsuite/gcc.target/i386/pr100445-1.c b/gcc/testsuite/gcc.target/i386/pr100445-1.c new file mode 100644 index 00000000000..a1c18aff0f9 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr100445-1.c @@ -0,0 +1,5 @@ +/* PR target/100445 */ +/* { dg-do compile } */ +/* { dg-options "-O3 -mavx512vl" } */ + +#include "pr96827.c"