From patchwork Sun May 14 19:55:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 1781059 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=Vuov0dUN; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QKCsz6qhtz20dR for ; Mon, 15 May 2023 05:55:51 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BE1D4385701D for ; Sun, 14 May 2023 19:55:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE1D4385701D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684094148; bh=UPlxflW//tZyECEytQJwXcEmBDhKFJ+PjVTH79VKiEk=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Vuov0dUNP1zLJKRJHhTZwoRsoHtpr6y2Aw7zb2KmMAn0zJh9PakfMO9YttPDWLgDZ EnK0ChQ4TDChYY7v1iHwc115GDIgu1in0iyc5O2RFmvPtAhQ79P64lxftYVfRIqCst NYiaMKCen6kyaeMx4LkWJIFCF2QXlimZaJlALet0= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by sourceware.org (Postfix) with ESMTPS id A10E33857BB2 for ; Sun, 14 May 2023 19:55:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A10E33857BB2 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-759413d99afso192764485a.1 for ; Sun, 14 May 2023 12:55:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684094129; x=1686686129; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UPlxflW//tZyECEytQJwXcEmBDhKFJ+PjVTH79VKiEk=; b=eh3EJpVjTT/EuFACu2nBMZAMz4oa8WhvIoLab34Ce3g60jrBu/PsZ03J4lWZdYJ6YG TP7e9LW2M0hs8c+JsALNrm7nqgT1ekFoJ/i9PciVRfiOnJ+hx3GgQMgQYWn0+oMNFJxK h1VbC266Ji6Ch0Q05g6nUVKEFQiQdaDUAs/fK2JVmaI7QlqqWUUumCrYUpg028kgjA8Z rmcxaOKXDg8H941UX4fvf7s/hQQMQNBchCnLFkA6/MDQWRpeOjUojHVQG8zklF+Doj0f 7wT0m3cjAZMbi8vIu/aZUpV75/laY5uBLH0zNr0dpimApATYougKXG2LYzc20ULJljGW WqdQ== X-Gm-Message-State: AC+VfDxecBZJuD8dWfLXI7h4y8L9pV5zrCs+jlUVPVotS0qv7uiQJcpD dA9SlzfB3vut2CmUdMRVsiult4FLbZCUoB6B3ZUjEP/jeAbcgA== X-Google-Smtp-Source: ACHHUZ6rMrwg7yeI91hFPBd3jQ8TIvsLcqBNNtxEIiwZeLNKN7nupFmazRAves45t45jOk0+ZnnaRzevRf3tR20SInA= X-Received: by 2002:a05:6214:1301:b0:5df:d35d:20fb with SMTP id pn1-20020a056214130100b005dfd35d20fbmr46068949qvb.7.1684094128614; Sun, 14 May 2023 12:55:28 -0700 (PDT) MIME-Version: 1.0 Date: Sun, 14 May 2023 21:55:16 +0200 Message-ID: Subject: [PATCH] i386: Handle unsupported modes from ix86_widen_mult_cost [PR109807] To: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Uros Bizjak via Gcc-patches From: Uros Bizjak Reply-To: Uros Bizjak Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Revert my previous change that faked handling of V4HI and V2SImodes in ix86_widen_mult_cost and rather return arbitrary high value for unsupported modes. This should prevent cost estimator from selecting non-existent vector widen multiply operation. gcc/ChangeLog: PR target/109807 * config/i386/i386.cc: Revert the 2023-05-11 change. (ix86_widen_mult_cost): Return high value instead of ICEing for unsupported modes. gcc/testsuite/ChangeLog: PR target/109807 * gcc.target/i386/pr109825.c: New test. Bootstrapped and regression tested on x86_64-linux-gnu {,--m32}. Pushed to master. Uros. diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index 4011203486b..498fac468b5 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -20417,14 +20417,12 @@ ix86_widen_mult_cost (const struct processor_costs *cost, int basic_cost = 0; switch (mode) { - case V4HImode: case V8HImode: case V16HImode: if (!uns_p || mode == V16HImode) extra_cost = cost->sse_op * 2; basic_cost = cost->mulss * 2 + cost->sse_op * 4; break; - case V2SImode: case V4SImode: case V8SImode: /* pmulhw/pmullw can be used. */ @@ -20441,7 +20439,8 @@ ix86_widen_mult_cost (const struct processor_costs *cost, basic_cost = cost->mulss * 2 + cost->sse_op * 4; break; default: - gcc_unreachable(); + /* Not implemented. */ + return 100; } return ix86_vec_cost (mode, basic_cost + extra_cost); } diff --git a/gcc/testsuite/gcc.target/i386/pr109825.c b/gcc/testsuite/gcc.target/i386/pr109825.c new file mode 100644 index 00000000000..a8f7ca94641 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr109825.c @@ -0,0 +1,4 @@ +/* { dg-do compile { target { ! ia32 } } } */ +/* { dg-options "-Os -ftree-slp-vectorize -mavx512vl" } */ + +#include "../../gcc.dg/vect/slp-widen-mult-u8.c"