From patchwork Mon May 13 10:15:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 1098784 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-500532-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="TIiYDmw4"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nKxYiBLK"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 452cD65KQSz9s4V for ; Mon, 13 May 2019 20:16:22 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:references:in-reply-to:from:date:message-id :subject:to:cc:content-type; q=dns; s=default; b=BJ3upUAVLaWmnSw t9xmakLljvqnfIr7ZzorijlIspNIQW7RjVpeVyweA7Xg7GwZDpZqz32PrJ9eACBI tDOngDIRsW+PtbUtKuADxs5a76SHyqbPqXubx2Jn0EnKGwfmil6PJfHldfpES7p5 NI86C4JYuYIIOma5McgWMHLpVvig= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:references:in-reply-to:from:date:message-id :subject:to:cc:content-type; s=default; bh=Ty4ybTXPiI3x+9UeTJEoa T1XCZY=; b=TIiYDmw48C0IFO3iDdruBz/Z/G++D12sqMzeLYUM73LulxF/ziesM 2JSpCxSJZeRcPbC7ws8CnGs7Twjc4MLyNjbtatyVfaOkYA/SNTBtvjU4/rJ42jdb if+o3mFMYh+CP3E7Pws268za/LV81/WavzYRROuDstzlfXfmfhNWhw= Received: (qmail 130920 invoked by alias); 13 May 2019 10:16:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 130907 invoked by uid 89); 13 May 2019 10:16:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.6 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:CAFULd4, survived, U*thomas, HX-HELO:sk:mail-it X-HELO: mail-it1-f178.google.com Received: from mail-it1-f178.google.com (HELO mail-it1-f178.google.com) (209.85.166.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 May 2019 10:16:09 +0000 Received: by mail-it1-f178.google.com with SMTP id q132so19325469itc.5 for ; Mon, 13 May 2019 03:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8tHEPVXc7USb1Q7I2ePye6EYD8RBYVZQnh+cmtdUKpg=; b=nKxYiBLK2iIcEo/xx0+TAo8R7/pIYlVB2x+3tUO4XowJsddQdjkrCyMPSdzyZgODM5 JLDV/reCzgi/TyT2RsYw5TcRtoBcCZQ+G6qdOlGf8BLYdCaDC3DsFk/cF/1ddn6YYxrm yGDKypemPKMGMROvs7uobRaRbhFThV1cKiiw6TJUF3aLA7W2uLYGFJmtPpI5UgYlqo2a 7eE7SLyTk1dhPOKYJynUIbgQLTKt9SnVjXXPc6ggk0+MldHzvgPB6VfGS3xBz7KagXdZ jdxqwNamL7hFJfn4Cy666YYzR4NttE0cxtnofSVcnEcXPBPx2KnDCSkNqy++3wFelOUN H1jg== MIME-Version: 1.0 References: <87zhnwdkaa.fsf@euler.schwinge.homeip.net> In-Reply-To: <87zhnwdkaa.fsf@euler.schwinge.homeip.net> From: Uros Bizjak Date: Mon, 13 May 2019 12:15:56 +0200 Message-ID: Subject: [PATCH, i386]: --enable-frame-pointer for cygwin and mingw To: Thomas Schwinge Cc: "gcc-patches@gcc.gnu.org" , Rainer Orth , Eric Botcazou , "H. J. Lu" , Jonathan Yong <10walls@gmail.com>, bug-hurd@gnu.org, debian-bsd@lists.debian.org On Thu, May 9, 2019 at 11:55 AM Thomas Schwinge wrote: > On Sun, 10 Feb 2019 20:51:39 +0100, Uros Bizjak wrote: > > On Fri, Feb 8, 2019 at 1:24 PM Uros Bizjak wrote: > > > Attached patch fixes --enable-frame-pointer handling [...] > > ACK. > > > Please note that this fix will re-enable frame pointer for all targets > > but linux* or darwin[[8912]]. However, since builds for e.g. cygwin > > and mingw survived just well without frame pointers in the mean time, > > we should probably list these targets as targets without frame > > pointers by default. > > I agree, this would cause the least surprise, to simply keep the previous > default of '--disable-frame-pointer'. Until such a global change is > agreed on, and made... I plan to commit the attached patch later today. 2019-05-13 Uroš Bizjak PR target/89221 * configure.ac (--enable-frame-pointer): Disable by default for cygwin and mingw. * configure: Regenerate. Uros. diff --git a/gcc/configure b/gcc/configure index 947d263a6174..3cab176e5018 100755 --- a/gcc/configure +++ b/gcc/configure @@ -12197,7 +12197,7 @@ if test "${enable_frame_pointer+set}" = set; then : else case $target_os in -linux* | gnu* | darwin[8912]*) +linux* | gnu* | darwin[8912]* | cygwin* | mingw*) # Enable -fomit-frame-pointer by default for these systems with DWARF2. enable_frame_pointer=no ;; diff --git a/gcc/configure.ac b/gcc/configure.ac index bfcdf526e446..264f36fb78a8 100644 --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -1884,7 +1884,7 @@ AC_ARG_ENABLE(frame-pointer, [enable -fno-omit-frame-pointer by default for x86])], [], [ case $target_os in -linux* | gnu* | darwin[[8912]]*) +linux* | gnu* | darwin[[8912]]* | cygwin* | mingw*) # Enable -fomit-frame-pointer by default for these systems with DWARF2. enable_frame_pointer=no ;;