From patchwork Tue Dec 9 05:36:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chung-Ju Wu X-Patchwork-Id: 418956 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 89667140082 for ; Tue, 9 Dec 2014 16:36:52 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:cc:content-type; q=dns; s=default; b=pfpfEPuxjSEPU0pCFiBtlz2EateXAZS39dBQnmqDjm+ GLauk/xTuF5PTsC1c0HnVgctVUst4YXmwt5lT1XUrrcwIzt0pbG9qYxrrVYJaiJm 22qd04QctkRa+RVJhTxoodwtm++T7CpYKBVtAgJuz8q9vwlWNCs8Fb9J2nz6/gcg = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:cc:content-type; s=default; bh=w364aMpgdOC8EUz3mQX3/WA198c=; b=AfMDWsmX0/lm5BJd7 Oyyzv6H8HupRoM2QRkbSoVyVcJbgYfDKcHNZbCboH90xAsyx7Ed+clQpR9g6ogBa eaAcUl6661P55NMCDyXaKn+1U8Y8++7dbrmlX6RRk9358Xl0V34OY5S4qUTOZJuW gulGxz7+5HC7uyB8HEf6fZ/1RU= Received: (qmail 26986 invoked by alias); 9 Dec 2014 05:36:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 26974 invoked by uid 89); 9 Dec 2014 05:36:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f41.google.com Received: from mail-qa0-f41.google.com (HELO mail-qa0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 09 Dec 2014 05:36:43 +0000 Received: by mail-qa0-f41.google.com with SMTP id f12so4458519qad.14 for ; Mon, 08 Dec 2014 21:36:41 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.140.42.120 with SMTP id b111mr2012587qga.102.1418103401529; Mon, 08 Dec 2014 21:36:41 -0800 (PST) Received: by 10.140.21.228 with HTTP; Mon, 8 Dec 2014 21:36:41 -0800 (PST) Date: Tue, 9 Dec 2014 13:36:41 +0800 Message-ID: Subject: [PATCH] Do not download packages for graphite loop optimizations by default when using ./contrib/download_prerequisites From: Chung-Ju Wu To: gcc patches , Paolo Bonzini Cc: Jonathan Wakely X-IsSubscribed: yes Hi, all, In the discussion thread last year: https://gcc.gnu.org/ml/gcc-patches/2013-05/msg01334.html I extended the script ./contrib/download_prerequisites so that it can download isl and cloog packages for graphite loop optimizations. The patch was proposed to use GRAPHITE_LOOP_OPT=no by default. However, the change I committed into trunk is setting GRAPHITE_LOOP_OPT=yes: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=199297 I am sorry about my carelessness and I would like to propose a new patch to fix it. The plaintext ChangeLog and patch are as follow: Is this patch OK for trunk? Or we can still keep it "yes" since it has been using GRAPHITE_LOOP_OPT=yes for a long time. In that case, I will help to update the comment accordingly. Any comment? :) Best regards, jasonwucj Index: contrib/ChangeLog =================================================================== --- contrib/ChangeLog (revision 218505) +++ contrib/ChangeLog (working copy) @@ -1,3 +1,7 @@ +2014-12-09 Chung-Ju Wu + + * download_prerequisites: Set GRAPHITE_LOOP_OPT=no by default. + 2014-12-04 Thomas Preud'homme * check_GNU_style.sh: Warn for incorrect number of spaces in function Index: contrib/download_prerequisites =================================================================== --- contrib/download_prerequisites (revision 218505) +++ contrib/download_prerequisites (working copy) @@ -22,7 +22,7 @@ # If you want to build GCC with the Graphite loop optimizations, # set GRAPHITE_LOOP_OPT=yes to download optional prerequisties # ISL Library and CLooG. -GRAPHITE_LOOP_OPT=yes +GRAPHITE_LOOP_OPT=no # Necessary to build GCC. MPFR=mpfr-2.4.2