| Message ID | CAD_=9DTWq0F2Z9a0a9fB_u1gTEpB0mHa1JJgbmOzcFO1x-FiFg@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Nov 28, 2013 at 3:14 PM, Diego Novillo <dnovillo@google.com> wrote: > Fixed quotation as per IRC feedback. > > Index: htdocs/svnwrite.html > =================================================================== > RCS file: /cvs/gcc/wwwdocs/htdocs/svnwrite.html,v > retrieving revision 1.29 > diff -u -d -u -p -r1.29 svnwrite.html > --- htdocs/svnwrite.html 24 Sep 2013 18:26:29 -0000 1.29 > +++ htdocs/svnwrite.html 28 Nov 2013 14:12:18 -0000 > @@ -147,10 +147,13 @@ list.</p> > > <p>The following changes can be made by everyone with SVN write access:</p> > > -<p>Fixes for obvious typos in ChangeLog files, docs, web pages, comments > -and similar stuff. Just check in the fix and copy it to > -<code>gcc-patches</code>. We don't want to get overly anal-retentive > -about checkin policies.</p> > +<p>Obvious fixes to documentation, code and test cases can be > +committed without prior approval. Why remove ChangeLog files, web pages and comments? Either enumerate everything or just enumerate nothing and simply say "Obvious fixes can be committed without prior approval." Richard. Just check in the fix and copy it > +to <code>gcc-patches</code>. A good test to determine whether a fix > +is obvious: <q>will the person who objects to my work the most be able > +to find a fault with my fix?</q> If the fix is later found to be > +faulty, it can always be rolled back. We don't want to get overly > +restrictive about checkin policies.</p> > > <p>Similarly, no outside approval is needed to revert a patch that you > checked in.</p>
Index: htdocs/svnwrite.html =================================================================== RCS file: /cvs/gcc/wwwdocs/htdocs/svnwrite.html,v retrieving revision 1.29 diff -u -d -u -p -r1.29 svnwrite.html --- htdocs/svnwrite.html 24 Sep 2013 18:26:29 -0000 1.29 +++ htdocs/svnwrite.html 28 Nov 2013 14:12:18 -0000 @@ -147,10 +147,13 @@ list.</p> <p>The following changes can be made by everyone with SVN write access:</p> -<p>Fixes for obvious typos in ChangeLog files, docs, web pages, comments -and similar stuff. Just check in the fix and copy it to -<code>gcc-patches</code>. We don't want to get overly anal-retentive -about checkin policies.</p> +<p>Obvious fixes to documentation, code and test cases can be +committed without prior approval. Just check in the fix and copy it +to <code>gcc-patches</code>. A good test to determine whether a fix +is obvious: <q>will the person who objects to my work the most be able +to find a fault with my fix?</q> If the fix is later found to be +faulty, it can always be rolled back. We don't want to get overly +restrictive about checkin policies.</p> <p>Similarly, no outside approval is needed to revert a patch that you checked in.</p>