From patchwork Mon Jan 23 08:51:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 137301 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id E7D91B6FA4 for ; Mon, 23 Jan 2012 19:51:53 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1327913515; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:In-Reply-To:References:Date: Message-ID:Subject:From:To:Cc:Content-Type: Content-Transfer-Encoding:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=M71s0DUD9E6kDk/I5usFxuBvNN4=; b=EvGXfNuPy4C30Eb bISqJ++tWwnonJkLmfPrVlnbEDq80cPhe6x5qluFAwfEvS2eQHFBAX+rMZBrbAxO Gxt8jLKhx8vSQYS7V9IKEEa1/e0LuNTIFTJqHNWTBn/3zJtahbO5p1wCB8rh526i aVRIg5IjU1W9mrrhvybdmhSygXWI= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:X-Gm-Message-State:Content-Type:Content-Transfer-Encoding:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Eju8Gw7EThdT6TVnzzuojbgtDsMWXZ3W6cePWeQBxWfHPDM3EwAoD4oIJeA0xS SHc2oOEZ0cF3jKVnYg8z4OU2zTnzlaCYmxxX0P9gNK+gAkRVIOYEl2Yj6G0GnSh8 AP3VylhshpU5Nz9yKJHr3K/Bvvbem7jSZu0Xe3ozPSf/A=; Received: (qmail 32185 invoked by alias); 23 Jan 2012 08:51:50 -0000 Received: (qmail 32177 invoked by uid 22791); 23 Jan 2012 08:51:50 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-tul01m020-f175.google.com (HELO mail-tul01m020-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jan 2012 08:51:30 +0000 Received: by obbuo9 with SMTP id uo9so3032007obb.20 for ; Mon, 23 Jan 2012 00:51:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.159.105 with SMTP id xb9mr1781462obb.63.1327308689940; Mon, 23 Jan 2012 00:51:29 -0800 (PST) Received: by 10.182.88.7 with HTTP; Mon, 23 Jan 2012 00:51:29 -0800 (PST) In-Reply-To: <201201221153.32801.ebotcazou@adacore.com> References: <201201211816.15317.ebotcazou@adacore.com> <201201221153.32801.ebotcazou@adacore.com> Date: Mon, 23 Jan 2012 08:51:29 +0000 Message-ID: Subject: Re: [RFC combine] PR48308 - Fix issue with missing(?) LOG_LINKS From: Ramana Radhakrishnan To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org, Patch Tracking X-Gm-Message-State: ALoCoQkft6fSsu0aDUzxiCLDJIh4S5vWqIWRPLFhgk7MVlmI9nqBLAJt1H4DjI9bWr7TWNjufSxh X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 22 January 2012 10:53, Eric Botcazou wrote: >> The un-combining thing around line 2800 is somewhat of a kludge and I >> wouldn't be surprised if there were other fallouts.  But your change is >> clearly correct and looks relatively safe, so OK for trunk and 4.6 branch >> after full testing. > > I overlooked something though: it might be possible for combine_instructions to > try to combine i2 again if the previous combination fails (if it succeeds, i1 > is deleted so this is OK) so the stall LOG_LINKS could be problematic.  That's > why LOG_LINKS (i2) needs to SUBST-ituted like the two lines just above Do you mean something like this instead ? I'm testing this - Ok if no regressions ? Ramana . > > -- > Eric Botcazou === modified file 'gcc/combine.c' --- gcc/combine.c 2012-01-11 22:59:12 +0000 +++ gcc/combine.c 2012-01-23 08:50:14 +0000 @@ -2865,6 +2865,7 @@ SUBST (PATTERN (i2), XVECEXP (PATTERN (i2), 0, 0)); SUBST (XEXP (SET_SRC (PATTERN (i2)), 0), SET_DEST (PATTERN (i1))); + SUBST (LOG_LINKS (i2), alloc_insn_link (i1, LOG_LINKS (i2))); } } #endif