From patchwork Wed Feb 13 23:41:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Bosscher X-Patchwork-Id: 220302 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C0E3E2C0084 for ; Thu, 14 Feb 2013 10:42:21 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1361403742; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:In-Reply-To:References:From:Date: Message-ID:Subject:To:Cc:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=bHdUfr+xepSiabBjGWaPkXxufcU=; b=HiI+Z4eMNeGeJ/p coDYzZxPEBIWz3ZjO6gKTBKyY314Km/aCFdDKxZDDIV8ZPflPkvO+fb/LjXi2eqi ppbvVylmC9u53JqcTgLK0G71uvK3VSHZagMWwAt2KeZFARVirjyzdcur8yElR/Cw lw4J5HdBJv4AJyRIO7iUlQF9EGyo= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Received:MIME-Version:Received:In-Reply-To:References:From:Date:Message-ID:Subject:To:Cc:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=L4rxcwuAGLgeGNIlSej051CbMU0F0B9J2+5u9ka3n65mVp1qdogj+Ijj7wGz0m dqwzusAUeKqs8liGvS+Ducc7gBVxLnVLg9Yb/UUElh5c3722LRgxokNFdrl1zf2p ZMxyvLXU4pjmyZr69RiV9ErR+rTSgaYJHprwwpvwepQ4Y=; Received: (qmail 9639 invoked by alias); 13 Feb 2013 23:42:17 -0000 Received: (qmail 9626 invoked by uid 22791); 13 Feb 2013 23:42:16 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vc0-f170.google.com (HELO mail-vc0-f170.google.com) (209.85.220.170) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Feb 2013 23:42:11 +0000 Received: by mail-vc0-f170.google.com with SMTP id p16so1142519vcq.15 for ; Wed, 13 Feb 2013 15:42:11 -0800 (PST) X-Received: by 10.220.108.2 with SMTP id d2mr32303343vcp.60.1360798931073; Wed, 13 Feb 2013 15:42:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.58.215.38 with HTTP; Wed, 13 Feb 2013 15:41:30 -0800 (PST) In-Reply-To: References: <20130213155423.GW4385@tucnak.redhat.com> From: Steven Bosscher Date: Thu, 14 Feb 2013 00:41:30 +0100 Message-ID: Subject: Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117) To: John David Anglin Cc: David Edelsohn , GCC Patches , Jeff Law , John David Anglin , rupp@gnat.com, "Joseph S. Myers" , Jakub Jelinek X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Thu, Feb 14, 2013 at 12:17 AM, John David Anglin wrote: > On 2013-02-13 3:33 PM, David Edelsohn wrote: >> >> Perhaps Dave can explain what would have to be done to move this >> > platform to DWARF2...? >> > > > I had looked at this a bit in the past. I don't think it's that difficult > to add DWARF2 support > to GCC on hppa. Although we don't support named sections, we can create > named subspaces > for the dwarf info. More of an issue in my mind is the changes needed to > gdb to recognize > this support. > > I agree with David that it might be better to give up pch. That'd be a really a good start. How about something like the attached patch for trunk? Tested on powerpc64-linux pch.exp with -gstabs. Ciao! Steven c-family/ * c-opts.c (c_common_handle_option): Warn that pre-compiled headers with debug formats other than DWARF are deprecated. testsuite/ * lib/dg-pch.exp: Compile the PCH with extra flag -Wno-deprecated. c-family/ * c-opts.c (c_common_handle_option): Warn that pre-compiled headers with debug formats other than DWARF are deprecated. testsuite/ * lib/dg-pch.exp: Compile the PCH with extra flag -Wno-deprecated. Index: c-family/c-opts.c =================================================================== --- c-family/c-opts.c (revision 196032) +++ c-family/c-opts.c (working copy) @@ -268,6 +268,10 @@ c_common_handle_option (size_t scode, const char * break; case OPT__output_pch_: + if (write_symbols != NO_DEBUG && write_symbols != DWARF2_DEBUG) + warning (OPT_Wdeprecated, + "the \"%s\" debug format cannot be used with pre-compiled headers", + debug_type_names[write_symbols]); pch_file = arg; break; Index: testsuite/lib/dg-pch.exp =================================================================== --- testsuite/lib/dg-pch.exp (revision 196032) +++ testsuite/lib/dg-pch.exp (working copy) @@ -39,8 +39,12 @@ proc dg-flags-pch { subdir test otherflags options set dg-do-what-default precompile catch { file_on_host delete "$bname$suffix" } gcc_copy_files "[file rootname $test]${suffix}s" "$bname$suffix" - dg-test -keep-output "./$bname$suffix" "$otherflags $flags" "" + # Suppress -Wdeprecated to allow PCH tests to work with non-DWARF2 + # debug formats. Support for such combinations has been deprecated + # for GCC 4.8. + dg-test -keep-output "./$bname$suffix" "$otherflags $flags -Wno-deprecated" "" + # For the rest, the default is to compile to .s. set dg-do-what-default compile