From patchwork Sat Jul 14 21:40:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Bosscher X-Patchwork-Id: 171028 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C5E002C00E2 for ; Sun, 15 Jul 2012 07:40:50 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1342906852; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: MIME-Version:Received:From:Date:Message-ID:Subject:To: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=A4dq8hP K0f1m/EpZaot9Y4kpME4=; b=PscsakM0+B1y6d5WEjcOdyFSWCT7GxH1JbENWA5 lOaf1kZIvE3zdbaziqUH58vzJNgZf6qfzqyEjf1VuMCQPPsd5SMb3qgaHS0fTS4z 1d/V0hKiVXuRKPZQ82Ks6rTaQJ6KBF8VdPtLey4g8izyE0ImDh6zjL+2t3ELcwAw Acz4= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:MIME-Version:Received:From:Date:Message-ID:Subject:To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=IgWWOEQKt1LMdhJ1Zjy4EPGWWSdga+53kx4qplZ9cSoaR5Ifm6XzxFhP30hDp3 63ef7eP/4hjaKbihh4vd28yw2E83yB097j6+UgMFQ1HUPKlbMc5aPtJoKlcf9kq6 yFRrBKLcbSNTbvBP9wyjMPa0f35gewYOgsY7P04twOF0E=; Received: (qmail 23850 invoked by alias); 14 Jul 2012 21:40:46 -0000 Received: (qmail 23836 invoked by uid 22791); 14 Jul 2012 21:40:45 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-lb0-f175.google.com (HELO mail-lb0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 14 Jul 2012 21:40:23 +0000 Received: by lbol5 with SMTP id l5so6570763lbo.20 for ; Sat, 14 Jul 2012 14:40:21 -0700 (PDT) Received: by 10.112.42.41 with SMTP id k9mr2959383lbl.90.1342302021484; Sat, 14 Jul 2012 14:40:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.4.229 with HTTP; Sat, 14 Jul 2012 14:40:01 -0700 (PDT) From: Steven Bosscher Date: Sat, 14 Jul 2012 23:40:01 +0200 Message-ID: Subject: [patch] Remove useless sets/clears of EDGE_CAN_FALLTHRU To: GCC Patches X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello, EDGE_CAN_FALLTHRU is internal to bb-reorder.c, set_edge_can_fallthru_flag() clears it on all edges and computes it fresh for bb-reorder. The test in rtl_verify_flow_info_1 has to stay because bb-reorder doesn't clean up the flag after it's done. Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK? Ciao! Steven * haifa-sched.c (init_before_recovery): Do not set EDGE_CAN_FALLTHRU. * cfgrtl.c (force_nonfallthru_and_redirect): Likewise. Index: haifa-sched.c =================================================================== --- haifa-sched.c (revision 189478) +++ haifa-sched.c (working copy) @@ -7193,8 +7193,7 @@ init_before_recovery (basic_block *before_recovery redirect_edge_succ (e, single); make_single_succ_edge (single, empty, 0); - make_single_succ_edge (empty, EXIT_BLOCK_PTR, - EDGE_FALLTHRU | EDGE_CAN_FALLTHRU); + make_single_succ_edge (empty, EXIT_BLOCK_PTR, EDGE_FALLTHRU); label = block_label (empty); x = emit_jump_insn_after (gen_jump (label), BB_END (single)); Index: cfgrtl.c =================================================================== --- cfgrtl.c (revision 189478) +++ cfgrtl.c (working copy) @@ -1365,8 +1365,8 @@ force_nonfallthru_and_redirect (edge e, basic_bloc one and create separate abnormal edge to original destination. This allows bb-reorder to make such edge non-fallthru. */ gcc_assert (e->dest == target); - abnormal_edge_flags = e->flags & ~(EDGE_FALLTHRU | EDGE_CAN_FALLTHRU); - e->flags &= EDGE_FALLTHRU | EDGE_CAN_FALLTHRU; + abnormal_edge_flags = e->flags & ~EDGE_FALLTHRU; + e->flags &= EDGE_FALLTHRU; } else {