From patchwork Wed Oct 16 21:34:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sriraman Tallam X-Patchwork-Id: 284031 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7843E2C00CA for ; Thu, 17 Oct 2013 08:35:06 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:content-type:content-transfer-encoding; q=dns; s= default; b=sIrhO6mAvxgehpNlhBIdl/BwIuh3IT596+nYLI2WHXMRJWWfpaHvI 9k/GKWYkDUmxvR5nGjxBjAuagWCY3I4AUhhMnWD7xl4R8xuwBXygaB9Cb7jHd+iF 87rW5TpCrgthdTqoUSbf8FFNFc7Eo9AT2Sz5v6QvkBCJnb/Mwgn+BI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:content-type:content-transfer-encoding; s=default; bh=w LihpFMd25qIOVweFz1HyNhXjOM=; b=moo75CGP14gBF+7d+Pj3tPnG6v0AxqqAB 0RCyDu0OVNNnh62SINaKKU0r4+PorHSqyUNTlgsyvhSSrkIfcxOzNI2zTk65wRnC iT5U0VkgBJlNAw1m+4ekb4vOsBaS4Ps/es/ypKY9MxmbPd8Kt4WoLPl8XPpVWeB3 pt6xAWctos= Received: (qmail 32037 invoked by alias); 16 Oct 2013 21:35:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 32018 invoked by uid 89); 16 Oct 2013 21:35:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f174.google.com Received: from mail-vc0-f174.google.com (HELO mail-vc0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 16 Oct 2013 21:34:59 +0000 Received: by mail-vc0-f174.google.com with SMTP id ie18so707787vcb.33 for ; Wed, 16 Oct 2013 14:34:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type:content-transfer-encoding; bh=RTI2mOLwRBD2TZOwqCsiW2KiKU450NUXXr9r+mO90eg=; b=Vp5+qx7kj3R9L5HqGrgEcx5ZJwOx9SitdJKg2ZWHbi5eNExRp981YoaMSEJxESzmY3 IArO/ER5fVWw/IBjIhrdSdK/SCn9d6h53BclP+BdHTuoOqd+zexQIAyzIODKWHwqLLnV xz+1paHI7C/Ep+cplSIqnoOMHJwdtaob8FTt0qU2yfNAqrTHTnsFWTHOfedkVHr9kRBf nn8OuR6DkIjITzrkDJJE2RoH/I8vdC9fv2hKlmUduRgoi99DsaFjODRoDl8XnbLwurfg gVfAtPP0BnnJIijAP+sqpzGjgCCdOLEydYhoKyj0W869VMxWU4sYoB7fUCMTobguj6Uy gM9w== X-Gm-Message-State: ALoCoQmtZMr4yC0Xns9D0UmtWs2/jDfjO1uemAtciYBYj0HXID1rPMAgLiGE6eqqyHxGjErGBwT7AIkJlCJgV95gfmkNHNMw83YgfPtiNAVs2gYu++99kZAKdiFi79X/1lZeVB5LwXT+Bo3iECffp8qCjNGGZ2yHN2uknFJq8+D9L3ldpyT9NvfT46bP0h13h2COTbvv6+UqvAPPwRQewdx0EHiJaeoPPw== MIME-Version: 1.0 X-Received: by 10.220.174.200 with SMTP id u8mr4116451vcz.6.1381959296785; Wed, 16 Oct 2013 14:34:56 -0700 (PDT) Received: by 10.52.167.35 with HTTP; Wed, 16 Oct 2013 14:34:56 -0700 (PDT) In-Reply-To: <20131016055411.GJ20756@bubble.grove.modra.org> References: <20131016055411.GJ20756@bubble.grove.modra.org> Date: Wed, 16 Oct 2013 14:34:56 -0700 Message-ID: Subject: Re: [PATCH][i386]Fix PR 57756 From: Sriraman Tallam To: Sriraman Tallam , GCC Patches , David Edelsohn , David Li X-IsSubscribed: yes On Tue, Oct 15, 2013 at 10:54 PM, Alan Modra wrote: > On Tue, Oct 15, 2013 at 02:45:23PM -0700, Sriraman Tallam wrote: >> I committed this patch after making the above change. > > /src/gcc-virgin/gcc/config/rs6000/rs6000.c: At global scope: > /src/gcc-virgin/gcc/config/rs6000/rs6000.c:31122:29: error: invalid conversion from ‘void (*)(cl_target_option*)’ to ‘void (*)(cl_target_option*, gcc_options*)’ [-fpermissive] > /src/gcc-virgin/gcc/config/rs6000/rs6000.c:31122:29: error: invalid conversion from ‘void (*)(cl_target_option*)’ to ‘void (*)(gcc_options*, cl_target_option*)’ [-fpermissive] This patch fixes it, ok to submit? * config/rs6000/rs6000.c (rs6000_function_specific_save): New unused parameter. (rs6000_function_specifc_restore): Ditto. Thanks Sri > > > -- > Alan Modra > Australia Development Lab, IBM Index: config/rs6000/rs6000.c =================================================================== --- config/rs6000/rs6000.c (revision 203711) +++ config/rs6000/rs6000.c (working copy) @@ -29995,7 +29995,8 @@ rs6000_set_current_function (tree fndecl) /* Save the current options */ static void -rs6000_function_specific_save (struct cl_target_option *ptr) +rs6000_function_specific_save (struct cl_target_option *ptr, + struct gcc_options *ARG_UNUSED (opts)) { ptr->x_rs6000_isa_flags = rs6000_isa_flags; ptr->x_rs6000_isa_flags_explicit = rs6000_isa_flags_explicit; @@ -30004,7 +30005,8 @@ static void /* Restore the current options */ static void -rs6000_function_specific_restore (struct cl_target_option *ptr) +rs6000_function_specific_restore (struct gcc_options *ARG_UNUSED (opts), + struct cl_target_option *ptr) { rs6000_isa_flags = ptr->x_rs6000_isa_flags; rs6000_isa_flags_explicit = ptr->x_rs6000_isa_flags_explicit;