From patchwork Wed May 18 11:17:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prathamesh Kulkarni X-Patchwork-Id: 1632770 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=XCQj3zY2; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L39Wn184Vz9sGS for ; Wed, 18 May 2022 21:20:21 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25E74385741C for ; Wed, 18 May 2022 11:20:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25E74385741C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1652872818; bh=JLg8W1YrvR4bUCn815AiKhtPWEaUlQ05QEO6YO3lNsM=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=XCQj3zY2Jo/JE3460hPTqX6h7EOa6KDIcSRaFGaaPA4UVYhznUmP6kQ3FT92/k3Cq tAVu8qHU2kICaKFo2Zi1N5d/tNEAgXVMPwiMAfGECGpIRzbLa6d9MIitsinisMBemy OhXDjsbN/z9fDhOh8p46SJvN3EHWx++WHlyAh1fE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id BB2C5385742A for ; Wed, 18 May 2022 11:17:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB2C5385742A Received: by mail-ed1-x52e.google.com with SMTP id j28so2501943eda.13 for ; Wed, 18 May 2022 04:17:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=JLg8W1YrvR4bUCn815AiKhtPWEaUlQ05QEO6YO3lNsM=; b=3Q11NnUwrQkELRCi4GWCKSH27Ez83LdwskmG1R28+lznrBBOxMZmeA5v22CCK5eSpu pvbyukcHkECC/ynDthSYQDONyp6c3z5NoCVK5z+1EXyVwtgNEaouAjvCM/FqBtdhsvlK xzU2RrB9NhdrMk5JsR2MLQOkhzY1ZwX7FSclHCfoyNHgD6h51ahWZhqvC+jEr1fQ2lbd 78QwZyivcTxfmJ4IcAMu/B+AuCU3c4Gr6E2Y12QUMsiPJdTsuJ5POZc26blCIMRxgRdt /kpw2G7ylteTBivF0xEmly7XWxxHdsTf7nyPsk0mU0UdQWOUjQ/oJDuJ4cskroScNUR0 fbog== X-Gm-Message-State: AOAM531Elr0uet5Yclf0b0fT5q370g5gkoAWSJ7Mt4B11SQl8JCfNMKS AaWFoaCtHsFABguyW2vwLLlZv0rsBlUzboKRrspn6LIVa5/3PA== X-Google-Smtp-Source: ABdhPJwNc50QT5qWaj6NDjv4uhdnW9cA0uPdM45XuiDZfy6g3uOTXeZaxOGcMFGfgm16J2KxKsR4h6hZnCoqAxZiBJQ= X-Received: by 2002:a05:6402:6d9:b0:42a:b514:a992 with SMTP id n25-20020a05640206d900b0042ab514a992mr14974827edy.209.1652872658451; Wed, 18 May 2022 04:17:38 -0700 (PDT) MIME-Version: 1.0 Date: Wed, 18 May 2022 16:47:02 +0530 Message-ID: Subject: [3/9] i386 changes to adjust vec_perm_const hook To: gcc Patches , Uros Bizjak X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Prathamesh Kulkarni via Gcc-patches From: Prathamesh Kulkarni Reply-To: Prathamesh Kulkarni Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi, The attached patch adjusts vec_perm_const hook to accommodate the new parameter. For rationale, please see: https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595128.html Bootstrapped+tested on x86_64-linux-gnu. OK to commit ? Thanks, Prathamesh diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc index 806e1f5aaa3..87f02d62338 100644 --- a/gcc/config/i386/i386-expand.cc +++ b/gcc/config/i386/i386-expand.cc @@ -22060,9 +22060,12 @@ canonicalize_perm (struct expand_vec_perm_d *d) /* Implement TARGET_VECTORIZE_VEC_PERM_CONST. */ bool -ix86_vectorize_vec_perm_const (machine_mode vmode, rtx target, rtx op0, - rtx op1, const vec_perm_indices &sel) +ix86_vectorize_vec_perm_const (machine_mode vmode, machine_mode op_mode, rtx target, + rtx op0, rtx op1, const vec_perm_indices &sel) { + if (vmode != op_mode) + return false; + struct expand_vec_perm_d d; unsigned char perm[MAX_VECT_LEN]; unsigned int i, nelt, which; diff --git a/gcc/config/i386/i386-expand.h b/gcc/config/i386/i386-expand.h index 9d320c29552..6c650196c9c 100644 --- a/gcc/config/i386/i386-expand.h +++ b/gcc/config/i386/i386-expand.h @@ -48,8 +48,9 @@ rtx gen_push (rtx arg); rtx gen_pop (rtx arg); rtx ix86_expand_builtin (tree exp, rtx target, rtx subtarget, machine_mode mode, int ignore); -bool ix86_vectorize_vec_perm_const (machine_mode vmode, rtx target, rtx op0, - rtx op1, const vec_perm_indices &sel); +bool ix86_vectorize_vec_perm_const (machine_mode vmode, machine_mode op_mode, + rtx target, rtx op0, rtx op1, + const vec_perm_indices &sel); bool ix86_notrack_prefixed_insn_p (rtx_insn *); machine_mode ix86_split_reduction (machine_mode mode); void ix86_expand_divmod_libfunc (rtx libfunc, machine_mode mode, rtx op0, diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index 175ce013e5d..50112a8efee 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -15836,7 +15836,7 @@ sel[7] = 15; } vec_perm_indices indices (sel, 2, 8); - bool ok = targetm.vectorize.vec_perm_const (V8SImode, target, + bool ok = targetm.vectorize.vec_perm_const (V8SImode, V8SImode, target, arg0, arg1, indices); gcc_assert (ok); emit_move_insn (operands[0], @@ -24569,7 +24569,7 @@ sel[3] = 7; } vec_perm_indices indices (sel, arg0 != arg1 ? 2 : 1, 4); - bool ok = targetm.vectorize.vec_perm_const (V4SImode, target, + bool ok = targetm.vectorize.vec_perm_const (V4SImode, V4SImode, target, arg0, arg1, indices); gcc_assert (ok); emit_move_insn (operands[0],