diff mbox series

Allow `gcc_jit_type_get_size` to work with pointers

Message ID CAAOQCfRP5n1d+LCx-HsWMqd5DtpJ1c=SN-F2K0upxKVYYeS9=Q@mail.gmail.com
State New
Headers show
Series Allow `gcc_jit_type_get_size` to work with pointers | expand

Commit Message

Guillaume Gomez March 28, 2024, 10:47 p.m. UTC 
Hi,

Here's a little fix to allow the `gcc_jit_type_get_size` function to
work on pointer types as well.

Cordially.

Comments

David Malcolm March 29, 2024, 5:48 p.m. UTC | #1 
On Thu, 2024-03-28 at 23:47 +0100, Guillaume Gomez wrote:
> Hi,
> 
> Here's a little fix to allow the `gcc_jit_type_get_size` function to
> work on pointer types as well.
> 
Thanks, looks good to me.

Are you able to push this, or do you want me to?

Dave
Guillaume Gomez March 29, 2024, 5:50 p.m. UTC | #2 
I can push it. Thanks for the (very quick) review!

Le ven. 29 mars 2024 à 18:48, David Malcolm <dmalcolm@redhat.com> a écrit :
>
> On Thu, 2024-03-28 at 23:47 +0100, Guillaume Gomez wrote:
> > Hi,
> >
> > Here's a little fix to allow the `gcc_jit_type_get_size` function to
> > work on pointer types as well.
> >
> Thanks, looks good to me.
>
> Are you able to push this, or do you want me to?
>
> Dave
>
Guillaume Gomez March 29, 2024, 7:10 p.m. UTC | #3 
Pushed as commit 4c18ace1cb69a31af4ac719850a66de79ed12e93.

Le ven. 29 mars 2024 à 18:50, Guillaume Gomez
<guillaume1.gomez@gmail.com> a écrit :
>
> I can push it. Thanks for the (very quick) review!
>
> Le ven. 29 mars 2024 à 18:48, David Malcolm <dmalcolm@redhat.com> a écrit :
> >
> > On Thu, 2024-03-28 at 23:47 +0100, Guillaume Gomez wrote:
> > > Hi,
> > >
> > > Here's a little fix to allow the `gcc_jit_type_get_size` function to
> > > work on pointer types as well.
> > >
> > Thanks, looks good to me.
> >
> > Are you able to push this, or do you want me to?
> >
> > Dave
> >
diff mbox series

Patch

From 21e6e2d5ea897fc74d0e3194973093c58157e6fa Mon Sep 17 00:00:00 2001
From: Guillaume Gomez <guillaume1.gomez@gmail.com>
Date: Tue, 26 Mar 2024 17:56:36 +0100
Subject: [PATCH] [PATH] Allow `gcc_jit_type_get_size` to work with pointers
 gcc/jit/ChangeLog:

	* libgccjit.cc (gcc_jit_type_get_size): Add pointer support
---
 gcc/jit/libgccjit.cc                     |  4 ++--
 gcc/testsuite/jit.dg/test-pointer_size.c | 27 ++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 2 deletions(-)
 create mode 100644 gcc/testsuite/jit.dg/test-pointer_size.c

diff --git a/gcc/jit/libgccjit.cc b/gcc/jit/libgccjit.cc
index a2cdc01a3a4..58d47723e38 100644
--- a/gcc/jit/libgccjit.cc
+++ b/gcc/jit/libgccjit.cc
@@ -575,8 +575,8 @@  gcc_jit_type_get_size (gcc_jit_type *type)
 {
   RETURN_VAL_IF_FAIL (type, -1, NULL, NULL, "NULL type");
   RETURN_VAL_IF_FAIL
-    (type->is_int () || type->is_float (), -1, NULL, NULL,
-     "only getting the size of integer or floating-point types is supported for now");
+    (type->is_int () || type->is_float () || type->is_pointer (), -1, NULL, NULL,
+     "only getting the size of integer or floating-point or pointer types is supported for now");
   return type->get_size ();
 }
 
diff --git a/gcc/testsuite/jit.dg/test-pointer_size.c b/gcc/testsuite/jit.dg/test-pointer_size.c
new file mode 100644
index 00000000000..337796acc2a
--- /dev/null
+++ b/gcc/testsuite/jit.dg/test-pointer_size.c
@@ -0,0 +1,27 @@ 
+/* { dg-do compile { target x86_64-*-* } } */
+
+#include <assert.h>
+#include "libgccjit.h"
+
+#include "harness.h"
+
+void
+create_code (gcc_jit_context *ctxt, void *user_data)
+{}
+
+void
+verify_code (gcc_jit_context *ctxt, gcc_jit_result *result)
+{
+  gcc_jit_type *int_type =
+    gcc_jit_context_get_type (ctxt, GCC_JIT_TYPE_INT);
+  gcc_jit_type *int_ptr_type = gcc_jit_type_get_pointer (int_type);
+
+  int int_ptr_size = gcc_jit_type_get_size (int_ptr_type);
+  CHECK_VALUE (int_ptr_size, 8);
+
+  gcc_jit_type *void_type =
+    gcc_jit_context_get_type (ctxt, GCC_JIT_TYPE_VOID);
+  gcc_jit_type *void_ptr_type = gcc_jit_type_get_pointer (void_type);
+
+  CHECK_VALUE (int_ptr_size, gcc_jit_type_get_size (void_ptr_type));
+}
-- 
2.24.1.2762.gfe2e4819b8