diff mbox series

Synchronize Rocket Lake's processor_names and processor_cost_table with processor_type

Message ID BY5PR11MB4008B501BC6CEA3F36D841B79E449@BY5PR11MB4008.namprd11.prod.outlook.com
State New
Headers show
Series Synchronize Rocket Lake's processor_names and processor_cost_table with processor_type | expand

Commit Message

Li, Pan2 via Gcc-patches April 24, 2021, 1:43 p.m. UTC 
Hi Uros,

This patch is  to synchronize Rocket Lake's processor_names and processor_cost_table with processor_type.

Bootstrap is ok, and no regressions for i386/x86-64 testsuite.

OK for master?

[PATCH] Synchronize Rocket Lake's processor_names and
 processor_cost_table with processor_type

gcc/ChangeLog

	* common/config/i386/i386-common.c (processor_names):
	Sync processor_names with processor_type.
	* config/i386/i386-options.c (processor_cost_table):
	Sync processor_cost_table with processor_type.
---
 gcc/common/config/i386/i386-common.c | 2 +-
 gcc/config/i386/i386-options.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Uros Bizjak April 26, 2021, 11:16 a.m. UTC | #1 
On Sat, Apr 24, 2021 at 3:43 PM Cui, Lili <lili.cui@intel.com> wrote:
>
> Hi Uros,
>
> This patch is  to synchronize Rocket Lake's processor_names and processor_cost_table with processor_type.
>
> Bootstrap is ok, and no regressions for i386/x86-64 testsuite.
>
> OK for master?
>
> [PATCH] Synchronize Rocket Lake's processor_names and
>  processor_cost_table with processor_type
>
> gcc/ChangeLog
>
>         * common/config/i386/i386-common.c (processor_names):
>         Sync processor_names with processor_type.
>         * config/i386/i386-options.c (processor_cost_table):
>         Sync processor_cost_table with processor_type.

OK.

Thanks,
Uros.

> ---
>  gcc/common/config/i386/i386-common.c | 2 +-
>  gcc/config/i386/i386-options.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/common/config/i386/i386-common.c b/gcc/common/config/i386/i386-common.c
> index 1e6c1590ac4..6a7b5c8312f 100644
> --- a/gcc/common/config/i386/i386-common.c
> +++ b/gcc/common/config/i386/i386-common.c
> @@ -1743,13 +1743,13 @@ const char *const processor_names[] =
>    "skylake-avx512",
>    "cannonlake",
>    "icelake-client",
> -  "rocketlake",
>    "icelake-server",
>    "cascadelake",
>    "tigerlake",
>    "cooperlake",
>    "sapphirerapids",
>    "alderlake",
> +  "rocketlake",
>    "intel",
>    "geode",
>    "k6",
> diff --git a/gcc/config/i386/i386-options.c b/gcc/config/i386/i386-options.c
> index 7e59ccd988d..eafa3d4f715 100644
> --- a/gcc/config/i386/i386-options.c
> +++ b/gcc/config/i386/i386-options.c
> @@ -726,12 +726,12 @@ static const struct processor_costs *processor_cost_table[] =
>    &icelake_cost,
>    &icelake_cost,
>    &icelake_cost,
> -  &icelake_cost,
>    &skylake_cost,
>    &icelake_cost,
>    &skylake_cost,
>    &icelake_cost,
>    &icelake_cost,
> +  &icelake_cost,
>    &intel_cost,
>    &geode_cost,
>    &k6_cost,
> --
> 2.17.1
>
> Thanks,
> Lili.
Hongtao Liu April 27, 2021, 1:28 a.m. UTC | #2 
On Mon, Apr 26, 2021 at 8:35 PM Uros Bizjak via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Sat, Apr 24, 2021 at 3:43 PM Cui, Lili <lili.cui@intel.com> wrote:
> >
> > Hi Uros,
> >
> > This patch is  to synchronize Rocket Lake's processor_names and processor_cost_table with processor_type.
> >
> > Bootstrap is ok, and no regressions for i386/x86-64 testsuite.
> >
> > OK for master?
> >
> > [PATCH] Synchronize Rocket Lake's processor_names and
> >  processor_cost_table with processor_type
> >
> > gcc/ChangeLog
> >
> >         * common/config/i386/i386-common.c (processor_names):
> >         Sync processor_names with processor_type.
> >         * config/i386/i386-options.c (processor_cost_table):
> >         Sync processor_cost_table with processor_type.
>
> OK.
>

Ok for backport to GCC11 ?

> Thanks,
> Uros.
>
> > ---
> >  gcc/common/config/i386/i386-common.c | 2 +-
> >  gcc/config/i386/i386-options.c       | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/gcc/common/config/i386/i386-common.c b/gcc/common/config/i386/i386-common.c
> > index 1e6c1590ac4..6a7b5c8312f 100644
> > --- a/gcc/common/config/i386/i386-common.c
> > +++ b/gcc/common/config/i386/i386-common.c
> > @@ -1743,13 +1743,13 @@ const char *const processor_names[] =
> >    "skylake-avx512",
> >    "cannonlake",
> >    "icelake-client",
> > -  "rocketlake",
> >    "icelake-server",
> >    "cascadelake",
> >    "tigerlake",
> >    "cooperlake",
> >    "sapphirerapids",
> >    "alderlake",
> > +  "rocketlake",
> >    "intel",
> >    "geode",
> >    "k6",
> > diff --git a/gcc/config/i386/i386-options.c b/gcc/config/i386/i386-options.c
> > index 7e59ccd988d..eafa3d4f715 100644
> > --- a/gcc/config/i386/i386-options.c
> > +++ b/gcc/config/i386/i386-options.c
> > @@ -726,12 +726,12 @@ static const struct processor_costs *processor_cost_table[] =
> >    &icelake_cost,
> >    &icelake_cost,
> >    &icelake_cost,
> > -  &icelake_cost,
> >    &skylake_cost,
> >    &icelake_cost,
> >    &skylake_cost,
> >    &icelake_cost,
> >    &icelake_cost,
> > +  &icelake_cost,
> >    &intel_cost,
> >    &geode_cost,
> >    &k6_cost,
> > --
> > 2.17.1
> >
> > Thanks,
> > Lili.
Hongtao Liu April 28, 2021, 1:43 a.m. UTC | #3 
On Tue, Apr 27, 2021 at 9:28 AM Hongtao Liu <crazylht@gmail.com> wrote:
>
> On Mon, Apr 26, 2021 at 8:35 PM Uros Bizjak via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> > On Sat, Apr 24, 2021 at 3:43 PM Cui, Lili <lili.cui@intel.com> wrote:
> > >
> > > Hi Uros,
> > >
> > > This patch is  to synchronize Rocket Lake's processor_names and processor_cost_table with processor_type.
> > >
> > > Bootstrap is ok, and no regressions for i386/x86-64 testsuite.
> > >
> > > OK for master?
> > >
> > > [PATCH] Synchronize Rocket Lake's processor_names and
> > >  processor_cost_table with processor_type
> > >
> > > gcc/ChangeLog
> > >
> > >         * common/config/i386/i386-common.c (processor_names):
> > >         Sync processor_names with processor_type.
> > >         * config/i386/i386-options.c (processor_cost_table):
> > >         Sync processor_cost_table with processor_type.
> >
> > OK.
> >
>
> Ok for backport to GCC11 ?
>
I've backported this patch to GCC11 as an obvious fix.
> > Thanks,
> > Uros.
> >
> > > ---
> > >  gcc/common/config/i386/i386-common.c | 2 +-
> > >  gcc/config/i386/i386-options.c       | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/gcc/common/config/i386/i386-common.c b/gcc/common/config/i386/i386-common.c
> > > index 1e6c1590ac4..6a7b5c8312f 100644
> > > --- a/gcc/common/config/i386/i386-common.c
> > > +++ b/gcc/common/config/i386/i386-common.c
> > > @@ -1743,13 +1743,13 @@ const char *const processor_names[] =
> > >    "skylake-avx512",
> > >    "cannonlake",
> > >    "icelake-client",
> > > -  "rocketlake",
> > >    "icelake-server",
> > >    "cascadelake",
> > >    "tigerlake",
> > >    "cooperlake",
> > >    "sapphirerapids",
> > >    "alderlake",
> > > +  "rocketlake",
> > >    "intel",
> > >    "geode",
> > >    "k6",
> > > diff --git a/gcc/config/i386/i386-options.c b/gcc/config/i386/i386-options.c
> > > index 7e59ccd988d..eafa3d4f715 100644
> > > --- a/gcc/config/i386/i386-options.c
> > > +++ b/gcc/config/i386/i386-options.c
> > > @@ -726,12 +726,12 @@ static const struct processor_costs *processor_cost_table[] =
> > >    &icelake_cost,
> > >    &icelake_cost,
> > >    &icelake_cost,
> > > -  &icelake_cost,
> > >    &skylake_cost,
> > >    &icelake_cost,
> > >    &skylake_cost,
> > >    &icelake_cost,
> > >    &icelake_cost,
> > > +  &icelake_cost,
> > >    &intel_cost,
> > >    &geode_cost,
> > >    &k6_cost,
> > > --
> > > 2.17.1
> > >
> > > Thanks,
> > > Lili.
>
>
>
> --
> BR,
> Hongtao
diff mbox series

Patch

diff --git a/gcc/common/config/i386/i386-common.c b/gcc/common/config/i386/i386-common.c
index 1e6c1590ac4..6a7b5c8312f 100644
--- a/gcc/common/config/i386/i386-common.c
+++ b/gcc/common/config/i386/i386-common.c
@@ -1743,13 +1743,13 @@  const char *const processor_names[] =
   "skylake-avx512",
   "cannonlake",
   "icelake-client",
-  "rocketlake",
   "icelake-server",
   "cascadelake",
   "tigerlake",
   "cooperlake",
   "sapphirerapids",
   "alderlake",
+  "rocketlake",
   "intel",
   "geode",
   "k6",
diff --git a/gcc/config/i386/i386-options.c b/gcc/config/i386/i386-options.c
index 7e59ccd988d..eafa3d4f715 100644
--- a/gcc/config/i386/i386-options.c
+++ b/gcc/config/i386/i386-options.c
@@ -726,12 +726,12 @@  static const struct processor_costs *processor_cost_table[] =
   &icelake_cost,
   &icelake_cost,
   &icelake_cost,
-  &icelake_cost,
   &skylake_cost,
   &icelake_cost,
   &skylake_cost,
   &icelake_cost,
   &icelake_cost,
+  &icelake_cost,
   &intel_cost,
   &geode_cost,
   &k6_cost,