From patchwork Sun Dec 11 18:44:50 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Sandoe X-Patchwork-Id: 130615 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 43ADFB6FD7 for ; Mon, 12 Dec 2011 05:45:14 +1100 (EST) Received: (qmail 31028 invoked by alias); 11 Dec 2011 18:45:12 -0000 Received: (qmail 31017 invoked by uid 22791); 11 Dec 2011 18:45:11 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from c2bthomr14.btconnect.com (HELO mail.btconnect.com) (213.123.20.132) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 11 Dec 2011 18:44:55 +0000 Received: from host81-138-1-83.in-addr.btopenworld.com (EHLO thor.office) ([81.138.1.83]) by c2bthomr14.btconnect.com with ESMTP id FMK77047; Sun, 11 Dec 2011 18:44:53 +0000 (GMT) Cc: gcc-patches@gcc.gnu.org, richard.earnshaw@arm.com, ramana.radhakrishnan@linaro.org, jakub@redhat.com, dje.gcc@gmail.com, sje@cup.hp.com, rdsandiford@googlemail.com, mingjie.xing@gmail.com, meissner@linux.vnet.ibm.com Message-Id: From: Iain Sandoe To: Richard Henderson In-Reply-To: <1323378383-9824-5-git-send-email-rth@redhat.com> Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: [PATCH 4/6] rs6000: Cleanup interleave/even_odd/vec_perm. Date: Sun, 11 Dec 2011 18:44:50 +0000 References: <1323378383-9824-1-git-send-email-rth@redhat.com> <1323378383-9824-5-git-send-email-rth@redhat.com> X-Mirapoint-IP-Reputation: reputation=Good-1, source=Queried, refid=tid=0001.0A0B0302.4EE4FA23.0005, actions=tag X-Junkmail-Premium-Raw: score=7/50, refid=2.7.2:2011.12.11.180315:17:7.944, ip=81.138.1.83, rules=__MULTIPLE_RCPTS_CC_X2, __HAS_MSGID, __SANE_MSGID, __MSGID_APPLEMAIL, __TO_MALFORMED_2, __CT, __CT_TEXT_PLAIN, __CTE, __MIME_VERSION, __MIME_VERSION_APPLEMAIL, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __HAS_X_MAILER, __X_MAILER_APPLEMAIL, BODYTEXTP_SIZE_3000_LESS, BODY_SIZE_1000_1099, __MIME_TEXT_ONLY, RDNS_GENERIC_POOLED, BODY_SIZE_5000_LESS, RDNS_SUSP_GENERIC, __USER_AGENT_APPLEMAIL, MULTIPLE_RCPTS, RDNS_SUSP, BODY_SIZE_2000_LESS, BODY_SIZE_7000_LESS, NO_URI_FOUND X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A0B0205.4EE4FA25.0117, ss=1, re=0.000, fgs=0, ip=0.0.0.0, so=2011-07-25 19:15:43, dmn=2011-05-27 18:58:46, mode=multiengine X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 8 Dec 2011, at 21:06, Richard Henderson wrote: > ; > + > + high = (highp == TARGET_BIG_ENDIAN ? 0 : nelt); > + This breaks bootstrap on ppc-darwin, which came as a bit f a surprise to me... ... however, it would appear that TARGET_BIG_ENDIAN is not used anywhere else... (plenty of {BYTES,WORDS}_BIG_ENDIAN). Note that there is no default for TARGET_BIG_ENDIAN in rs600.h - it is only defined in config/rs6000/sysv4.h. So is the patch below the correct 'obvious' fix, or was something else intended. cheers Iain gcc: * config/rs6000/darwin.h (TARGET_BIG_ENDIAN): Define to 1. Index: gcc/config/rs6000/darwin.h =================================================================== --- gcc/config/rs6000/darwin.h (revision 182204) +++ gcc/config/rs6000/darwin.h (working copy) @@ -39,6 +39,8 @@ #define TARGET_OBJECT_FORMAT OBJECT_MACHO +#define TARGET_BIG_ENDIAN 1 + /* Size of the Obj-C jump buffer. */ #define OBJC_JBLEN ((TARGET_64BIT) ? (26*2 + 18*2 + 129 + 1) : (26 + 18*2 + 129 + 1))