From patchwork Sat May 7 23:18:07 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 94524 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 48D89B6FD6 for ; Sun, 8 May 2011 09:18:27 +1000 (EST) Received: (qmail 10529 invoked by alias); 7 May 2011 23:18:24 -0000 Received: (qmail 10520 invoked by uid 22791); 7 May 2011 23:18:23 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-pz0-f47.google.com (HELO mail-pz0-f47.google.com) (209.85.210.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 07 May 2011 23:18:08 +0000 Received: by pzk36 with SMTP id 36so2209842pzk.20 for ; Sat, 07 May 2011 16:18:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.154.13 with SMTP id b13mr2694341wfe.161.1304810287230; Sat, 07 May 2011 16:18:07 -0700 (PDT) Received: by 10.142.114.13 with HTTP; Sat, 7 May 2011 16:18:07 -0700 (PDT) In-Reply-To: References: Date: Sun, 8 May 2011 00:18:07 +0100 Message-ID: Subject: Re: [patch] fix typos and grammar in -fuse-linker-plugin docs From: Jonathan Wakely To: Gerald Pfeifer Cc: gcc-patches Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 7 May 2011 22:33, Gerald Pfeifer wrote: > On Fri, 6 May 2011, Jonathan Wakely wrote: >> 2011-05-06  Jonathan Wakely   >> >>         * doc/invoke.texi (-fuse-linker-plugin): Improve grammar. >> >> I was going to commit a smaller version of this patch as obvious (just >> the second of the three hunks in the patch) but I spotted a few other >> improvements that could be made. I think my changes preserve the >> intended meaning, but improve the English slightly and (I hope) >> clarify it. > > This looks good, thank you!  (Some of the lines touched seem a bit > long? Perhaps wrap them?) Done. >> Would removing "do" from "and shared libraries that do use hidden >> visibility" be a further improvement? > > That I better leave to the native speakers here. :-) I made the call and removed the "do", and committed the attached version to trunk. Thanks, Jonathan 2011-05-08 Jonathan Wakely * doc/invoke.texi (-fuse-linker-plugin): Improve grammar. Index: doc/invoke.texi =================================================================== --- doc/invoke.texi (revision 173528) +++ doc/invoke.texi (working copy) @@ -7701,17 +7701,18 @@ Disabled by default. @item -fuse-linker-plugin -Enables the use of linker plugin during link time optimization. This option -relies on the linker plugin support in linker that is available in gold +Enables the use of a linker plugin during link time optimization. This +option relies on plugin support in the linker, which is available in gold or in GNU ld 2.21 or newer. -This option enables the extraction of object files with GIMPLE bytecode out of -library archives. This improves the quality of optimization by exposing more -code the link time optimizer. This information specify what symbols -can be accessed externally (by non-LTO object or during dynamic linking). -Resulting code quality improvements on binaries (and shared libraries that do -use hidden visibility) is similar to @code{-fwhole-program}. See -@option{-flto} for a description on the effect of this flag and how to use it. +This option enables the extraction of object files with GIMPLE bytecode out +of library archives. This improves the quality of optimization by exposing +more code to the link time optimizer. This information specifies what +symbols can be accessed externally (by non-LTO object or during dynamic +linking). Resulting code quality improvements on binaries (and shared +libraries that use hidden visibility) are similar to @code{-fwhole-program}. +See @option{-flto} for a description of the effect of this flag and how to +use it. Enabled by default when LTO support in GCC is enabled and GCC was compiled with a linker supporting plugins (GNU ld 2.21 or newer or gold).