Message ID | AANLkTin6VXuXO24LTcblnCi__37uW3DeVGdZeE5w9ya4@mail.gmail.com |
---|---|
State | New |
Headers | show |
On 07/02/2010 02:42 AM, H.J. Lu wrote: > > Here is a new patch for PR 44775 to assert *ref != NULL. OK > for trunk? Doesn't it crash anyway if that assert is false? Bernd
On Fri, Jul 2, 2010 at 1:23 AM, Bernd Schmidt <bernds@codesourcery.com> wrote: > On 07/02/2010 02:42 AM, H.J. Lu wrote: >> >> Here is a new patch for PR 44775 to assert *ref != NULL. OK >> for trunk? > > Doesn't it crash anyway if that assert is false? > > One is segmentation fault and one is ICE.
diff --git a/gcc/web.c b/gcc/web.c index ff91733..44e4011 100644 --- a/gcc/web.c +++ b/gcc/web.c @@ -123,6 +123,8 @@ union_match_dups (rtx insn, struct web_entry *def_entry, if (DF_REF_LOC (*ref) == recog_data.operand_loc[op]) break; + gcc_assert (*ref != NULL); + (*fun) (use_entry + DF_REF_ID (*dupref), entry + DF_REF_ID (*ref)); } }