| Message ID | 9b3bf7dc-4eb8-e210-94b7-b5cfc56458ca@codesourcery.com |
|---|---|
| State | New |
| Headers | show |
| Series | libgomp.texi: List GCN's 'gfx803' under OpenMP Context Selectors (was: amdgcn: Support AMD-specific 'isa' traits in OpenMP context selectors) | expand |
On 29/11/2022 18:26, Tobias Burnus wrote: > Hi PA, hi Andrew, hi Jakub, hi all, > > On 29.11.22 16:56, Paul-Antoine Arras wrote: >> This patch adds support for 'gfx803' as an alias for 'fiji' in OpenMP >> context selectors, [...] > > I think this should be documented somewhere. We have > https://gcc.gnu.org/onlinedocs/libgomp/OpenMP-Context-Selectors.html > > For GCN and ISA, it refers to -march= and gfx803 is only a context > selector. Hence: > > How about the attached patch? The wording is a little odd. How about "Additionally, gfx908 is supported as an alias for fiji"? Andrew
On 30.11.22 10:43, Andrew Stubbs wrote: > On 29/11/2022 18:26, Tobias Burnus wrote: >> On 29.11.22 16:56, Paul-Antoine Arras wrote: >>> This patch adds support for 'gfx803' as an alias for 'fiji' in OpenMP >>> context selectors, [...] PA committed that patch as https://gcc.gnu.org/r13-4403-g1fd508744eccda9ad9c6d6fcce5b2ea9c568818d (thanks!) >> I think this should be documented somewhere. We have >> https://gcc.gnu.org/onlinedocs/libgomp/OpenMP-Context-Selectors.html > The wording is a little odd. > How about "Additionally, gfx908 is supported as an alias for fiji"? Committed with the suggested wording: https://gcc.gnu.org/r13-4404-ge0b95c2e8b771b53876321a6a0a9497619af73cd Thanks, Tobias PS: It does not help with finding a good wording if that's the last task before calling it a day... ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
libgomp.texi: List GCN's 'gfx803' under OpenMP Context Selectors libgomp/ChangeLog: * libgomp.texi (OpenMP Context Selectors): Add 'gfx803' to gcn's isa. diff --git a/libgomp/libgomp.texi b/libgomp/libgomp.texi index 85cae742cd4..0066d41fdc5 100644 --- a/libgomp/libgomp.texi +++ b/libgomp/libgomp.texi @@ -4378,5 +4378,6 @@ offloading devices (it's not clear if they should be): @item @code{amdgcn}, @code{gcn} @tab @code{gpu} - @tab See @code{-march=} in ``AMD GCN Options'' + @tab See @code{-march=} in ``AMD GCN Options''@footnote{Additionally + supported is @code{gfx803} as an alias for @code{fiji}.} @item @code{nvptx} @tab @code{gpu}