diff mbox

tm_p.h for bb-reorder.c?

Message ID 93D76812-17DC-4085-A1A2-FBF851B5E31D@comcast.net
State New
Headers show

Commit Message

Mike Stump Nov. 12, 2015, 7:46 p.m. UTC 
My port needs the below patch.  I think this was reduced by someone on a port that didn’t use some features (TARGET_SHORT_BRANCH_CHEAPER) of tm.h. 

So, the question is, is this the preferred way to do this?  I don’t want to hookize TARGET_SHORT_BRANCH_CHEAPER, which is the other fix.

If yes, Ok?

Comments

Jeff Law Nov. 12, 2015, 7:56 p.m. UTC | #1 
On 11/12/2015 12:46 PM, Mike Stump wrote:
> My port needs the below patch.  I think this was reduced by someone on a port that didn’t use some features (TARGET_SHORT_BRANCH_CHEAPER) of tm.h.
>
> So, the question is, is this the preferred way to do this?  I don’t want to hookize TARGET_SHORT_BRANCH_CHEAPER, which is the other fix.
>
> If yes, Ok?
I'd prefer not.  We will likely run the reducers regularly and each time 
someone is going to look at this and have to remember that it's dealing 
with a need that is specific to an out-of-tree port.

I'd recommend hookizing.


Jeff
diff mbox

Patch

diff --git a/gcc/bb-reorder.c b/gcc/bb-reorder.c
index 3dcb82a..7a2b351 100644
--- a/gcc/bb-reorder.c
+++ b/gcc/bb-reorder.c
@@ -114,6 +114,7 @@ 
 #include "bb-reorder.h"
 #include "except.h"
 #include "fibonacci_heap.h"
+#include "tm_p.h"
 
 /* The number of rounds.  In most cases there will only be 4 rounds, but
    when partitioning hot and cold basic blocks into separate sections of