From patchwork Wed Apr 3 12:06:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 1919266 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=HefqdCdF; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V8k5h3Phsz23tl for ; Wed, 3 Apr 2024 23:07:36 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9D6873847718 for ; Wed, 3 Apr 2024 12:07:34 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 34BB1384645B for ; Wed, 3 Apr 2024 12:06:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34BB1384645B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34BB1384645B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712146010; cv=none; b=dI+7ADp7s20s/Jxb2lkV+rQbMe0i+4Iidd4cb4JHujRwRSNzISt3owhlQFY2b3447NtQw4nXMAZD5cv8gywehzkab0EJN4ZYqzmFdadoyiQ5OAKlhbITBekgCsMpnx2MOHs8sPVmuCIObc4MtTn/WE/+yzxmvvZM9+6qXG/9XZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712146010; c=relaxed/simple; bh=b5r/4DYQ5aHh8mMIEWBaELPkScslXWf0yhW3TANVjJU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=gtUCHThHmZIk0aTEPHFOv3XRQuQaDmNaZzq1dkM8iUI4b/3MmMEK8byAXtpW8GHudktqIrGE2BMRFXTrLsXzyRUA63TIOWcYe4HyGZTPcBBWN22n2I0q8Ci25yg9itKbQ3oa3D6t5r0q2wyUFlR+YCJMA8bUA0lJTOQy17m/zWk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a4a3a5e47baso745985166b.2 for ; Wed, 03 Apr 2024 05:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1712146007; x=1712750807; darn=gcc.gnu.org; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=M4VhFENmwDopfQD6+Rv77Ec4gN1bROpVcOGGL3s0zrc=; b=HefqdCdFugj5gVh5K/szRWlfPl1gtV7Cg/OA91Cw5VLnCGjzNYm27KZIXUSVBJI0VJ lMX2ZbLb2fwNM0iUlaBgUa4D+zPn5SYpTRaWBXZi4FJOgnS+l4/MqciE4SE80r6N9nMU kgKksE4ybKLyWOv/SMRDzw8T1hFK8Qw8r9wal4J+7Up49Mk+ETkPO7P0at5Tcy3HJkYU ZhsC46xSVROIN/pK5pq+mM9E1Rjis2UV57hW5a08Q599uDHdx66iWfUEjO8w6erDldJU oDpaAmRJZVpJxE+dQu3X7W/sLoc9gvbuyj3MZFe1fWiTRrdGifI9LAgjIdRzJf3BM37x G1Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712146007; x=1712750807; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M4VhFENmwDopfQD6+Rv77Ec4gN1bROpVcOGGL3s0zrc=; b=u5DeGXigfjRvcdhKg+Owt8eB5N3UgAy2H2ROdwJSFamfIvzITH19gioUtEM4++GF4F NJDMVMWck+RFMDgd6uoSsl7TvAhNNpHjDWUtUQABC+TGoFRhjrAJYw5EKxGN2C2cGGhh Mw4ZR0fWVSD+awOaDNbMY9Z+AGUgfySygqf5w+Bny76q1szEDvM/mLyzf8/EX8iG+Gnq /5Cl7vfy5rYD2yVuM3q33QVYWWKlmY/wqDBXfQniISWU9b8v9Tx/OX1aL1y4IH17CkD7 n6FOyodHfih3qzbj5tITfg+iSw7JEylbMbCNKH9XZxVPlaarJm1rmb8Tf2OmZpR7RhKR fqnw== X-Gm-Message-State: AOJu0YzmuUZdshqE/gR4CcMLx1xWjMQ3SSh3457yks/HQWZsWVrrLL8F +JjzX4b7RlmibRUoZgk4csinqcqRnvpQchyy4iR6IdxJ3TJQ9fkZ+yLSZ5rL7i4PG537cI02FG0 / X-Google-Smtp-Source: AGHT+IF936kZGyaUFhPlKGHZysWJ00wOezOLcbG6pDWdR6tAXcadM9CY7jXvw1Ef6KMUfpJv+1LRsQ== X-Received: by 2002:a17:906:b047:b0:a4e:d27:30ab with SMTP id bj7-20020a170906b04700b00a4e0d2730abmr10909947ejb.59.1712146006733; Wed, 03 Apr 2024 05:06:46 -0700 (PDT) Received: from ?IPV6:2001:16b8:2ad3:b600:23:e49d:37af:1a62? (200116b82ad3b6000023e49d37af1a62.dip.versatel-1u1.de. [2001:16b8:2ad3:b600:23:e49d:37af:1a62]) by smtp.gmail.com with ESMTPSA id bb1-20020a1709070a0100b00a4e7dfb5abasm2595980ejc.171.2024.04.03.05.06.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 05:06:46 -0700 (PDT) Message-ID: <8f2b8bb3-c30d-4d57-9be8-31618c168cf2@baylibre.com> Date: Wed, 3 Apr 2024 14:06:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: gcc-patches , Tom de Vries , Thomas Schwinge From: Tobias Burnus Subject: [Patch] nvptx: In mkoffload.cc, call diagnostic_color_init + gcc_init_libintl X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Nvptx's mkoffload.cc contains 14 'fatal_error' calls and one 'warning_at' call, which stands out more clearly (color, bold) when enabling diagnostic_color_init which this patch does. — Additionally, the call gcc_init_libintl permits that the already translated error messages also show up as translation. OK for mainline? Tobias PS: Example: 'nvptx mkoffload:' is bold and 'fatal error:' is in red in English and some language variants. nvptx mkoffload: fatal error: COLLECT_GCC must be set. nvptx mkoffload: 致命的エラー: COLLECT_GCC must be set. nvptx mkoffload: erreur fatale: COLLECT_GCC doit être défini. nvptx mkoffload: schwerwiegender Fehler: COLLECT_GCC muss gesetzt sein. (BTW: It looks as if many languages did not translate the error string itself, e.g. jp or zh or pl or zh_TW/zh_CN or fi or ...) nvptx: In mkoffload.cc, call diagnostic_color_init + gcc_init_libintl gcc/ChangeLog: * config/nvptx/mkoffload.cc (main): Call gcc_init_libintl and diagnostic_color_init. gcc/config/nvptx/mkoffload.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/config/nvptx/mkoffload.cc b/gcc/config/nvptx/mkoffload.cc index a7fc28cbd3f..503b1abcefd 100644 --- a/gcc/config/nvptx/mkoffload.cc +++ b/gcc/config/nvptx/mkoffload.cc @@ -638,7 +638,9 @@ main (int argc, char **argv) const char *outname = 0; progname = tool_name; + gcc_init_libintl (); diagnostic_initialize (global_dc, 0); + diagnostic_color_init (global_dc); if (atexit (mkoffload_cleanup) != 0) fatal_error (input_location, "atexit failed");