From patchwork Thu Oct 13 20:23:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Schwab X-Patchwork-Id: 681956 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sw2HY62TPz9s9x for ; Fri, 14 Oct 2016 07:23:36 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=YpAhy3gW; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; q=dns; s=default; b=wbSovuYOAiYnXnJe Wts3SKeYXcDffVWKq8RMnBzp+YOG4EKbvrNEQjI3qvWcPiVQ+9cOZyesCBtzmeWN yCPmTSpSupTtxFJSsMjfl8qcGni6Z/qiGXXgu3ET1s5nifXrZgioh7nOOztPwWEJ 6cag7tl28BXp6zR3nedtH6B3oG8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=default; bh=RO+ComlWVgXj63wT4E3VS7 tgi1Q=; b=YpAhy3gWqm86iRqhNVqDXaFNJP/bkHJ0o5ZMTH7XasQn4Zs1wiUnHf nq3jsQJbJmYdEYOhfCWTurYuVE3aqTATGaUazcDPxDRx8MMqe1F9sLf+cs0x9Wx8 iSUuNL5pN59+xsp5WPi+JuiLKWfpCo3H+FToMKL2mSE7E6Xkh1y3k= Received: (qmail 114346 invoked by alias); 13 Oct 2016 20:23:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 114324 invoked by uid 89); 13 Oct 2016 20:23:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=1756, Hx-languages-length:1652, HX-HELO:sk:mail-ou X-HELO: mail-out.m-online.net Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Oct 2016 20:23:15 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3sw2H5114fz3hjNh; Thu, 13 Oct 2016 22:23:12 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3sw2H46VjXzvk91; Thu, 13 Oct 2016 22:23:12 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id 2yt7WQg3eIJ4; Thu, 13 Oct 2016 22:23:11 +0200 (CEST) X-Auth-Info: S+M7SZw8OpGyA9vcCMUmzaPcpToyIcu7Ye5ZFr4OeRhqQ7PJciSRjz/lRQLe/+eh Received: from igel.home (ppp-88-217-0-147.dynamic.mnet-online.de [88.217.0.147]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 13 Oct 2016 22:23:11 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 476662C39B8; Thu, 13 Oct 2016 22:23:11 +0200 (CEST) From: Andreas Schwab To: Bernd Schmidt Cc: Kelvin Nilsen , gcc-patches@gcc.gnu.org, law@redhat.com Subject: Re: [PATCH v4] PR48344: Fix unrecognizable insn error with -fstack-limit-register=r2 References: <56BCA4E4.6030100@linux.vnet.ibm.com> <87shsh88c6.fsf@linux-m68k.org> <53c5ba51-2216-be0f-a574-772d217e7dd0@redhat.com> X-Yow: Tex SEX! The HOME of WHEELS! The dripping of COFFEE!! Take me to Minnesota but don't EMBARRASS me!! Date: Thu, 13 Oct 2016 22:23:11 +0200 In-Reply-To: <53c5ba51-2216-be0f-a574-772d217e7dd0@redhat.com> (Bernd Schmidt's message of "Thu, 13 Oct 2016 12:58:26 +0200") Message-ID: <87wphcaths.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 I've committed this to fix the ICE. Andreas. * config/m68k/m68k.c (m68k_option_override): Check opt_fstack_limit_symbol_arg and opt_fstack_limit_register_no instead of stack_limit_rtx. * gcc.target/m68k/stack-limit-1.c: Expect warning on line 0. diff --git a/gcc/config/m68k/m68k.c b/gcc/config/m68k/m68k.c index e6bcfa0caf..a883e42514 100644 --- a/gcc/config/m68k/m68k.c +++ b/gcc/config/m68k/m68k.c @@ -638,10 +638,12 @@ m68k_option_override (void) } #endif - if (stack_limit_rtx != NULL_RTX && !TARGET_68020) + if ((opt_fstack_limit_symbol_arg != NULL || opt_fstack_limit_register_no >= 0) + && !TARGET_68020) { warning (0, "-fstack-limit- options are not supported on this cpu"); - stack_limit_rtx = NULL_RTX; + opt_fstack_limit_symbol_arg = NULL; + opt_fstack_limit_register_no = -1; } SUBTARGET_OVERRIDE_OPTIONS; diff --git a/gcc/testsuite/gcc.target/m68k/stack-limit-1.c b/gcc/testsuite/gcc.target/m68k/stack-limit-1.c index b1e9b99b26..5086edd77f 100644 --- a/gcc/testsuite/gcc.target/m68k/stack-limit-1.c +++ b/gcc/testsuite/gcc.target/m68k/stack-limit-1.c @@ -1,6 +1,6 @@ /* -fstack-limit- should be ignored without an ICE if not supported. */ /* { dg-do compile } */ /* { dg-options "-fstack-limit-symbol=_stack_limit -m68000" } */ -/* { dg-warning "not supported" "" { target *-*-* } 1 } */ +/* { dg-warning "not supported" "" { target *-*-* } 0 } */ void dummy (void) { }