From patchwork Thu Jun 10 20:32:17 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 55249 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 70033B7D66 for ; Fri, 11 Jun 2010 06:32:33 +1000 (EST) Received: (qmail 4194 invoked by alias); 10 Jun 2010 20:32:31 -0000 Received: (qmail 4185 invoked by uid 22791); 10 Jun 2010 20:32:31 -0000 X-SWARE-Spam-Status: No, hits=0.9 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MEDICAL_SUBJECT X-Spam-Check-By: sourceware.org Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Jun 2010 20:32:27 +0000 Received: by wyi11 with SMTP id 11so281502wyi.20 for ; Thu, 10 Jun 2010 13:32:24 -0700 (PDT) Received: by 10.227.144.141 with SMTP id z13mr802690wbu.154.1276201944110; Thu, 10 Jun 2010 13:32:24 -0700 (PDT) Received: from localhost (rsandifo.gotadsl.co.uk [82.133.89.107]) by mx.google.com with ESMTPS id b17sm2685937wbd.13.2010.06.10.13.32.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 10 Jun 2010 13:32:22 -0700 (PDT) From: Richard Sandiford To: Mark Mitchell Mail-Followup-To: Mark Mitchell , gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Cc: gcc-patches@gcc.gnu.org Subject: Re: Ping^2: .md enums & unspec names in dumps References: <87k4qdc4by.fsf@firetop.home> <4C0E6433.3070801@codesourcery.com> Date: Thu, 10 Jun 2010 21:32:17 +0100 In-Reply-To: <4C0E6433.3070801@codesourcery.com> (Mark Mitchell's message of "Tue, 08 Jun 2010 08:39:31 -0700") Message-ID: <87sk4uzl0u.fsf@firetop.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Mark Mitchell writes: > Richard Sandiford wrote: >> A second ping for this patch series: >> >> http://gcc.gnu.org/ml/gcc-patches/2010-05/msg01168.html >> >> with the follow-ups: >> >> http://gcc.gnu.org/ml/gcc-patches/2010-05/msg02352.html >> http://gcc.gnu.org/ml/gcc-patches/2010-05/msg02353.html >> >> Tested (with the follow-ups) on x86_64-linux-gnu and mipsisa64-elf. > > OK. Thanks a lot for the review! When I updated, I found I needed one further patch to cope with changes since the ping. lto-wrapper.c included defaults.h in order to get the definition of the obstack_* macros. Now that I've moved them to coretypes.h, it has to include that instead. I think this is an improvement. defaults.h is really a target header that should be included through tm.h; nothing is really supposed to include it directly like that. Tested on x86_64-linux-gnu and mipsisa64-elf. Applied as obvious. Richard * Makefile.in ... (lto-wrapper.o): Depend on coretypes.h instead of defaults.h. ... * lto-wrapper.c: Include coretypes.h instead of defaults.h. Index: gcc/Makefile.in =================================================================== --- gcc/Makefile.in 2010-06-08 21:00:52.000000000 +0100 +++ gcc/Makefile.in 2010-06-08 21:07:10.000000000 +0100 @@ -2059,7 +2061,7 @@ lto-wrapper$(exeext): lto-wrapper.o intl $(COMPILER) $(ALL_COMPILERFLAGS) $(LDFLAGS) -o T$@ lto-wrapper.o intl.o $(LIBS) mv -f T$@ $@ -lto-wrapper.o: lto-wrapper.c $(CONFIG_H) $(SYSTEM_H) defaults.h intl.h \ +lto-wrapper.o: lto-wrapper.c $(CONFIG_H) $(SYSTEM_H) coretypes.h intl.h \ $(OBSTACK_H) # Files used by all variants of C. Index: gcc/lto-wrapper.c =================================================================== --- gcc/lto-wrapper.c 2010-06-08 21:07:25.000000000 +0100 +++ gcc/lto-wrapper.c 2010-06-08 21:07:32.000000000 +0100 @@ -39,12 +39,12 @@ Software Foundation; either version 3, o #include "config.h" #include "system.h" +#include "coretypes.h" #include #include #if ! defined( SIGCHLD ) && defined( SIGCLD ) # define SIGCHLD SIGCLD #endif -#include "defaults.h" #include "intl.h" #include "libiberty.h" #include "obstack.h"