Message ID | 87mwndm0gl.fsf@redhat.com |
---|---|
State | New |
Headers | show |
On Sep 16, 2013, at 5:10 AM, Nick Clifton <nickc@redhat.com> wrote: > The new MSP430 target has a few limitations which show up as > unexpected failures in the GCC testsuite. I would like to apply the > patch below to update target-supports.exp with this information. > Applying the patch results in a drop of 133 unexpected failures (per > multilib). > > OK to apply ? Ok, I assume that the changes to hppa and return 0 are intentional and good… > - || [istarget hppa64-hp-hpux11.23] } { > - return 0; > + || [istarget hppa64-hp-hpux11.23] } { > + return 0;
Hi Mike, > Ok, I assume that the changes to hppa and return 0 are intentional and good… > >> - || [istarget hppa64-hp-hpux11.23] } { >> - return 0; >> + || [istarget hppa64-hp-hpux11.23] } { >> + return 0; Sorry - yes - they are just whitespace adjustments so that the entries line up. Cheers Nick
Index: gcc/testsuite/lib/target-supports.exp =================================================================== --- gcc/testsuite/lib/target-supports.exp (revision 202612) +++ gcc/testsuite/lib/target-supports.exp (working copy) @@ -435,9 +435,10 @@ return 0 } if { [istarget avr-*-*] + || [istarget msp430-*-*] || [istarget hppa2.0w-hp-hpux11.23] - || [istarget hppa64-hp-hpux11.23] } { - return 0; + || [istarget hppa64-hp-hpux11.23] } { + return 0; } return 1 } @@ -535,6 +536,7 @@ || [istarget mmix-*-*] || [istarget mn10300-*-elf*] || [istarget moxie-*-elf*] + || [istarget msp430-*-*] || [istarget picochip-*-*] || [istarget powerpc-*-eabi*] || [istarget powerpc-*-elf] @@ -652,6 +654,11 @@ # Return 1 if TLS executables can run correctly, 0 otherwise. proc check_effective_target_tls_runtime {} { + # MSP430 runtime does not have TLS support, but just + # running the test below is insufficient to show this. + if { [istarget msp430-*-*] } { + return 0 + } return [check_runtime tls_runtime { __thread int thr = 0; int main (void) { return thr; }