From patchwork Mon Feb 10 20:38:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 319054 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AFB1F2C00A8 for ; Tue, 11 Feb 2014 07:38:30 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; q=dns; s= default; b=BbawxEX/d0Mh0MRK8fAHNwWU0NfDA3rc5CljtvY9lexZFGvdlM7sT wPqOMLLBmW1M69w8ccmHlfpsA5TAutflMY2SZwRA6wUZZdqVyV5/bzhvbzkJP34T g3AWyVFwFRp+0F8YBG0vGPue8Fqua6TNN2mMR3qDIXe3tODRJzz/Cc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; s= default; bh=6dFgV0bkpgBoiRb5GTWxmXNbhUY=; b=sUjLmhLBtwgijLIqrgVT 8RFIww21/tbJ/shnm0iRS14xQ1v9j6VOT8/BpKcLSH3mElt8/wWSRcgXFsBs6Gay y+I1oPBVogIhhMBSj/3p6ZOKwTapYdV5FIJVUQ/6s9KZopwf5XwKZVmOicxoyOZe bRlB5r5kRC2SRX2KNj6YjL0= Received: (qmail 5962 invoked by alias); 10 Feb 2014 20:38:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5953 invoked by uid 89); 10 Feb 2014 20:38:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f41.google.com Received: from mail-wg0-f41.google.com (HELO mail-wg0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 10 Feb 2014 20:38:22 +0000 Received: by mail-wg0-f41.google.com with SMTP id n12so2909668wgh.4 for ; Mon, 10 Feb 2014 12:38:19 -0800 (PST) X-Received: by 10.181.8.66 with SMTP id di2mr11931300wid.43.1392064699650; Mon, 10 Feb 2014 12:38:19 -0800 (PST) Received: from localhost ([2.28.234.162]) by mx.google.com with ESMTPSA id y18sm39593996wie.11.2014.02.10.12.38.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Feb 2014 12:38:19 -0800 (PST) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Subject: RFA: XFAIL gcc.dg/vect/pr56787.c if vect_no_align Date: Mon, 10 Feb 2014 20:38:18 +0000 Message-ID: <87lhxi3dqd.fsf@talisman.default> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Not 100% sure whether this is the preferred fix, but gcc.dg/vect/pr56787.c has lots of float * parameters that point who-knows-where and so is only vectorised if the target supports misaligned vector accesses: void foo (unsigned long n, const float *__restrict u0, const float *__restrict u1, const float *__restrict u2, const float *__restrict u3, const float *__restrict u4, const float *__restrict s0, const float *__restrict s1, const float *__restrict s2, float *__restrict t3, float *__restrict t4) { unsigned long i; for (i = 0; i < n; i++) { float u[5], f[3][5]; u[0] = u0[i]; u[1] = u1[i]; u[2] = u2[i]; u[3] = u3[i]; u[4] = u4[i]; bar (u, f); t3[i] = s0[i] * f[0][3] + s1[i] * f[1][3] + s2[i] * f[2][3]; } } MIPS paired-single doesn't have any form of vector misalignment. I suppose it would be technically possible to use misaligned integer accesses and an FPR<->GPR move, but that can be expensive. I also don't have any hardware to benchmark it on. So this patch adds an xfail for vect_no_align. Tested on mipsisa64-sde-elf. OK to install? Thanks, Richard gcc/testsuite/ * gcc.dg/vect/pr56787.c: Mark as xfail for vect_no_align. Index: gcc/testsuite/gcc.dg/vect/pr56787.c =================================================================== --- gcc/testsuite/gcc.dg/vect/pr56787.c 2014-02-10 20:26:03.870867802 +0000 +++ gcc/testsuite/gcc.dg/vect/pr56787.c 2014-02-10 20:36:42.072279177 +0000 @@ -31,5 +31,5 @@ foo (unsigned long n, const float *__res } } -/* { dg-final { scan-tree-dump "vectorized 1 loops" "vect" } } */ +/* { dg-final { scan-tree-dump "vectorized 1 loops" "vect" { xfail vect_no_align } } } */ /* { dg-final { cleanup-tree-dump "vect" } } */