From patchwork Wed Jan 25 16:07:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 719723 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3v7qjf6R5Kz9sD5 for ; Thu, 26 Jan 2017 03:08:53 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="VwPkjMbO"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type:content-transfer-encoding; q=dns; s= default; b=OZYY2CBojzmyRNOWjQOFPbwrzPv7ke25p6nkHjWv4VdB0wxzZz/gy 84OHJL3QS1N7XtGT/zmQww6NrmO09WGe2UyK6CEsN+IPWxrrze8rrl/SK5xl9rua eUcmVciqgiCipoh04IpSZyV/AQoqKF7wLBe1rKFVHSQ3qtvqcW94WA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type:content-transfer-encoding; s=default; bh=b5+byHjEhptkYnUbqhzJbabpJXQ=; b=VwPkjMbOHNXxs2HJ2mSZ2pITRf+E CZC4fn/G7nrICTvUJ5gIUtM75lv/0k/BjZSDdiXhUO+5JvtCdXQTmEwUcXXYfQKQ uaUv1In5Gx16OTmC0er88IJrUW+uYvvu4cfuHCQq56N5qgK3pTu1D1KWE8IOeyFv z8pyljSoBHRPJzk= Received: (qmail 30536 invoked by alias); 25 Jan 2017 16:08:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 30516 invoked by uid 89); 25 Jan 2017 16:08:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL, BAYES_50, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=Care, 1, 217, PACKAGE_VERSION, PACKAGE_TARNAME X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jan 2017 16:08:28 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1cWQ7T-00023o-Px from Thomas_Schwinge@mentor.com ; Wed, 25 Jan 2017 08:08:24 -0800 Received: from hertz.schwinge.homeip.net (137.202.0.87) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 25 Jan 2017 16:08:20 +0000 From: Thomas Schwinge To: Jakub Jelinek , Martin Jambor , "GCC Patches" , Pekka =?utf-8?B?SsOkw6Rza2Vsw6RpbmVu?= CC: Subject: Re: [PATCH] BRIG frontend: request for a global review In-Reply-To: <20170125122113.GN1867@tucnak> References: <20170116090746.GM1867@tucnak> <20170123120240.h6kannl7ygryurbj@virgil.suse.cz> <20170124125210.q4red46xdpzechx7@virgil.suse.cz> <87efzrcvcd.fsf@euler.schwinge.homeip.net> <20170125122113.GN1867@tucnak> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 25 Jan 2017 17:07:41 +0100 Message-ID: <87inp3w2b6.fsf@hertz.schwinge.homeip.net> MIME-Version: 1.0 X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) Hi! On Wed, 25 Jan 2017 13:21:13 +0100, Jakub Jelinek wrote: > On Wed, Jan 25, 2017 at 11:00:50AM +0100, Thomas Schwinge wrote: > > On Tue, 24 Jan 2017 13:52:10 +0100, Martin Jambor wrote: > > > [BRIG front end] $ git grep --cached libbrig gcc/brig/config-lang.in:target_libs="target-libbrig target-libhsail-rt" What is "libbrig"; should we remove that (as far as I can tell?) stale reference? $ git show 55a56509bb4ae0c844c27f0679a22844bed3a3c5 -- libhsail-rt/README | filterdiff --- /dev/null +++ libhsail-rt/README @@ -0,0 +1,4 @@ +Run autoconf2.64 && automake-1.11 to regenerate the buildfiles. +You might need to manually tweak the minor automake version number +in configure.ac and aclocal.m4 (search for 1.11.6) in case your +local 1.11 minor version doesn't match. \ No newline at end of file I don't understand that "manually tweak" comment -- you should just install/build the right versions, and run "PATH=[...]:$PATH autoreconf", which is the same for all GCC subdirectories. Instead, the README file should contain a note what the "libhsail-rt" directory is about. $ git show 55a56509bb4ae0c844c27f0679a22844bed3a3c5 -- gcc/builtin-types.def | filterdiff --hunks=1 diff --git gcc/builtin-types.def gcc/builtin-types.def index 91745b4..ee6d052 100644 --- gcc/builtin-types.def +++ gcc/builtin-types.def @@ -67,7 +67,10 @@ DEF_PRIMITIVE_TYPE (BT_LONGLONG, long_long_integer_type_node) DEF_PRIMITIVE_TYPE (BT_ULONGLONG, long_long_unsigned_type_node) DEF_PRIMITIVE_TYPE (BT_INTMAX, intmax_type_node) DEF_PRIMITIVE_TYPE (BT_UINTMAX, uintmax_type_node) -DEF_PRIMITIVE_TYPE (BT_UINT16, uint16_type_node) +DEF_PRIMITIVE_TYPE (BT_INT8, signed_char_type_node) +DEF_PRIMITIVE_TYPE (BT_INT16, short_integer_type_node) +DEF_PRIMITIVE_TYPE (BT_UINT8, char_type_node) +DEF_PRIMITIVE_TYPE (BT_UINT16, short_unsigned_type_node) DEF_PRIMITIVE_TYPE (BT_UINT32, uint32_type_node) DEF_PRIMITIVE_TYPE (BT_UINT64, uint64_type_node) DEF_PRIMITIVE_TYPE (BT_WORD, (*lang_hooks.types.type_for_mode) (word_mode, 1)) Is that change alright? For instance, uint16_type_node is still used elsewhere. Some of these intN/uintN type_nodes apparently don't exist as global_trees; should they, and then be referred to here instead of the C-like type_nodes? The "News" section on , and should also be updated, I guess? :-) By the way, see "Questionable -Wmisleading-indentation diagnostic in HSAIL-Tools" for a build problem with HSAILasm that I ran into. With that resolved (trivial), I'm reporting from "gcc/testsuite/brig/brig.sum": "# of expected passes 95". Just one concern there is output like: [...] PASS: brig.dg/test/gimple/mem.hsail (test for excess errors) PASS: mem.hsail.brig scan-tree-dump original "__args;[\n ]+d0 =" PASS: mem.hsail.brig scan-tree-dump original "\\(__args \\+ 8\\);[\n ]+d2 =" [...] ..., that is, the "scan-tree-dump"s don't print the full filename of the test case. But that problem supposedly isn't specific to the BRIG test cases. (I may look into that later.) > > "contrib/gcc_update" needs to be updated for "libhsail-rt". Done. I suppose that also contrib/update-copyright.py need to be updated? (I never looked into that, so don't know.) > > Here is a patch to fix some Autotools issues in libhsail-rt (currently > > testing); OK for trunk? > Note, lots of this changed in r244895, so your patch doesn't apply any > longer. Still removing AC_CONFIG_MACRO_DIR, removing config.h.in and > regenerating whatever is affected by that (most likely just configure) > is in order. Committed to trunk in r244902: commit c8cd62c4e211f2e2bfabaf25a64842004e611797 Author: tschwinge Date: Wed Jan 25 15:38:01 2017 +0000 libhsail-rt: Fix some Autotools issues contrib/ * gcc_update (files_and_dependencies): Care for "libhsail-rt". libhsail-rt/ * configure.ac: Don't instantiate AC_CONFIG_MACRO_DIR. * configure: Regenerate. libhsail-rt/ * config.h.in: Remove stale file. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@244902 138bc75d-0d04-0410-961f-82ee72b054a4 --- contrib/ChangeLog | 4 + contrib/gcc_update | 4 + libhsail-rt/ChangeLog | 13 +++ libhsail-rt/config.h.in | 217 ----------------------------------------------- libhsail-rt/configure | 6 +- libhsail-rt/configure.ac | 2 - 6 files changed, 23 insertions(+), 223 deletions(-) Grüße Thomas diff --git contrib/ChangeLog contrib/ChangeLog index d429beb..2f862fa 100644 --- contrib/ChangeLog +++ contrib/ChangeLog @@ -1,3 +1,7 @@ +2017-01-25 Thomas Schwinge + + * gcc_update (files_and_dependencies): Care for "libhsail-rt". + 2017-01-23 Gerald Pfeifer * patch_tester.sh (TESTLOGS): Remove diff --git contrib/gcc_update contrib/gcc_update index a3f6d26..fe643af 100755 --- contrib/gcc_update +++ contrib/gcc_update @@ -140,6 +140,10 @@ libgomp/testsuite/Makefile.in: libgomp/testsuite/Makefile.am libgomp/aclocal.m4 libgomp/configure.ac: libgomp/plugin/configfrag.ac libgomp/configure: libgomp/configure.ac libgomp/aclocal.m4 libgomp/config.h.in: libgomp/configure.ac libgomp/aclocal.m4 +libhsail-rt/aclocal.m4: libhsail-rt/configure.ac +libhsail-rt/Makefile.in: libhsail-rt/Makefile.am libhsail-rt/aclocal.m4 +libhsail-rt/configure: libhsail-rt/configure.ac libhsail-rt/aclocal.m4 +libhsail-rt/target-config.h.in: libhsail-rt/configure.ac libhsail-rt/aclocal.m4 libitm/aclocal.m4: libitm/configure.ac libitm/acinclude.m4 libitm/Makefile.in: libitm/Makefile.am libitm/aclocal.m4 libitm/testsuite/Makefile.in: libitm/testsuite/Makefile.am libitm/aclocal.m4 diff --git libhsail-rt/ChangeLog libhsail-rt/ChangeLog index 8264c31..0184c24 100644 --- libhsail-rt/ChangeLog +++ libhsail-rt/ChangeLog @@ -1,3 +1,10 @@ +2017-01-25 Thomas Schwinge + + * config.h.in: Remove stale file. + + * configure.ac: Don't instantiate AC_CONFIG_MACRO_DIR. + * configure: Regenerate. + 2017-01-25 Jakub Jelinek PR other/79046 @@ -36,3 +43,9 @@ * rt/sat_arithmetic.c: Likewise. * rt/segment.c: Likewise. * rt/workitems.c: Likewise. + +Copyright (C) 2017 Free Software Foundation, Inc. + +Copying and distribution of this file, with or without modification, +are permitted in any medium without royalty provided the copyright +notice and this notice are preserved. diff --git libhsail-rt/config.h.in libhsail-rt/config.h.in deleted file mode 100644 index 9dd4110..0000000 --- libhsail-rt/config.h.in +++ /dev/null @@ -1,217 +0,0 @@ -/* config.h.in. Generated from configure.ac by autoheader. */ - -/* Define if building universal (internal helper macro) */ -#undef AC_APPLE_UNIVERSAL_BUILD - -/* Define to 1 if you have the `acosl' function. */ -#undef HAVE_ACOSL - -/* Define to 1 if you have the `asinl' function. */ -#undef HAVE_ASINL - -/* Define to 1 if you have the `atan2l' function. */ -#undef HAVE_ATAN2L - -/* Define to 1 if you have the `atanl' function. */ -#undef HAVE_ATANL - -/* Define to 1 if you have the `cosl' function. */ -#undef HAVE_COSL - -/* Define to 1 if you have the header file. */ -#undef HAVE_DLFCN_H - -/* Define to 1 if you have the `expl' function. */ -#undef HAVE_EXPL - -/* Define to 1 if you have the `expm1l' function. */ -#undef HAVE_EXPM1L - -/* Define to 1 if you have the header file. */ -#undef HAVE_INTTYPES_H - -/* Define to 1 if you have the `ldexpl' function. */ -#undef HAVE_LDEXPL - -/* Define to 1 if you have the header file. */ -#undef HAVE_LINUX_ETHER_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_LINUX_FS_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_LINUX_REBOOT_H - -/* Define to 1 if you have the `log10l' function. */ -#undef HAVE_LOG10L - -/* Define to 1 if you have the `log1pl' function. */ -#undef HAVE_LOG1PL - -/* Define to 1 if you have the `logl' function. */ -#undef HAVE_LOGL - -/* Define to 1 if you have the header file. */ -#undef HAVE_MEMORY_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_NETINET_ICMP6_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_NETINET_IF_ETHER_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_NETINET_IN_SYST_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_NETINET_IP_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_NETINET_IP_MROUTE_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_NETPACKET_PACKET_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_NET_IF_ARP_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_NET_IF_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_NET_ROUTE_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SCHED_H - -/* Define to 1 if you have the `sinl' function. */ -#undef HAVE_SINL - -/* Define to 1 if you have the header file. */ -#undef HAVE_STDINT_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_STDLIB_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_STRINGS_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_STRING_H - -/* Define to 1 if the compiler provides the __sync_bool_compare_and_swap - function for uint32 */ -#undef HAVE_SYNC_BOOL_COMPARE_AND_SWAP_4 - -/* Define to 1 if the compiler provides the __sync_bool_compare_and_swap - function for uint64 */ -#undef HAVE_SYNC_BOOL_COMPARE_AND_SWAP_8 - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYSCALL_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_EPOLL_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_FILE_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_INOTIFY_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_MMAN_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_MOUNT_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_PRCTL_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_PTRACE_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_SELECT_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_SOCKET_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_STATFS_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_STAT_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_SYSCALL_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_SYSINFO_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_TIMEX_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_TYPES_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_USER_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_UTSNAME_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_SYS_VFS_H - -/* Define to 1 if you have the `tanl' function. */ -#undef HAVE_TANL - -/* Define to 1 if you have the header file. */ -#undef HAVE_UNISTD_H - -/* Define to 1 if you have the header file. */ -#undef HAVE_UTIME_H - -/* Define to the sub-directory in which libtool stores uninstalled libraries. - */ -#undef LT_OBJDIR - -/* Name of package */ -#undef PACKAGE - -/* Define to the address where bug reports for this package should be sent. */ -#undef PACKAGE_BUGREPORT - -/* Define to the full name of this package. */ -#undef PACKAGE_NAME - -/* Define to the full name and version of this package. */ -#undef PACKAGE_STRING - -/* Define to the one symbol short name of this package. */ -#undef PACKAGE_TARNAME - -/* Define to the home page for this package. */ -#undef PACKAGE_URL - -/* Define to the version of this package. */ -#undef PACKAGE_VERSION - -/* Define to 1 if you have the ANSI C header files. */ -#undef STDC_HEADERS - -/* Version number of package */ -#undef VERSION - -/* Define WORDS_BIGENDIAN to 1 if your processor stores words with the most - significant byte first (like Motorola and SPARC, unlike Intel). */ -#if defined AC_APPLE_UNIVERSAL_BUILD -# if defined __BIG_ENDIAN__ -# define WORDS_BIGENDIAN 1 -# endif -#else -# ifndef WORDS_BIGENDIAN -# undef WORDS_BIGENDIAN -# endif -#endif diff --git libhsail-rt/configure libhsail-rt/configure index e62d5a0..a490125 100755 --- libhsail-rt/configure +++ libhsail-rt/configure @@ -2409,8 +2409,6 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu - - # Needed to define ${target}. Needs to be very early to avoid annoying # warning about calling AC_ARG_PROGRAM before AC_CANONICAL_SYSTEM ac_aux_dir= @@ -10975,7 +10973,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 10978 "configure" +#line 10976 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -11081,7 +11079,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 11084 "configure" +#line 11082 "configure" #include "confdefs.h" #if HAVE_DLFCN_H diff --git libhsail-rt/configure.ac libhsail-rt/configure.ac index 95b9a4f..ed7e304 100644 --- libhsail-rt/configure.ac +++ libhsail-rt/configure.ac @@ -34,8 +34,6 @@ # POSSIBILITY OF SUCH DAMAGE. AC_INIT([phsa HSAIL runtime library], [1.0], [pekka.jaaskelainen@parmance.com]) -AC_CONFIG_MACRO_DIR([m4]) - AC_PREREQ([2.64]) # Needed to define ${target}. Needs to be very early to avoid annoying