From patchwork Tue May 8 21:42:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 157823 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 395E2B6FA1 for ; Wed, 9 May 2012 07:42:34 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1337118155; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:From:To:Mail-Followup-To:Cc:Subject:References:Date: In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=u04KCRyGZcS7a0DvMM6A O5WxFQI=; b=hclQh090tAGrIXPVy2K6+AMt6NIuSjATmAyJM09mSxrMImxX37B0 Ao/A5zbJGPS5FMdzPHDN02sJQnHYwBoAHzn8e/LjeQpV6/J2k4zg+rj9A13RVM7y ivPPtuFwmgMwlVLkC0tAUVkn7oUole8XRduVtTXrV3RT74jnAN7Perg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:From:To:Mail-Followup-To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=ZJR7/Fg0d+ucTSs4qepPrE8LsDYSXY5Sp9oZiKquWOziUarWcYGzkVFxKVGuq6 kS6XjbtGbQWN3KXLJ2Bg6896WB+23mXhW27ySXd3TUc4z4pFbncXNmWMsrPufVvk 4LxquJhMZ+Ij0Vsmr/GcQ0yvFpdx7tAdMipED9WR4P2sw=; Received: (qmail 2655 invoked by alias); 8 May 2012 21:42:32 -0000 Received: (qmail 2647 invoked by uid 22791); 8 May 2012 21:42:31 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wi0-f169.google.com (HELO mail-wi0-f169.google.com) (209.85.212.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 May 2012 21:42:17 +0000 Received: by wibhn14 with SMTP id hn14so1111154wib.2 for ; Tue, 08 May 2012 14:42:16 -0700 (PDT) Received: by 10.180.102.101 with SMTP id fn5mr19524117wib.6.1336513336307; Tue, 08 May 2012 14:42:16 -0700 (PDT) Received: from localhost (rsandifo.gotadsl.co.uk. [82.133.89.107]) by mx.google.com with ESMTPS id fn2sm1989915wib.0.2012.05.08.14.42.14 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 May 2012 14:42:15 -0700 (PDT) From: Richard Sandiford To: Richard Earnshaw Mail-Followup-To: Richard Earnshaw , Georg-Johann Lay , Mike Stump , gcc-patches , Ian Lance Taylor , Kenneth Zadeck , Kenneth Zadeck , ramana.radhakrishnan@linaro.org, rdsandiford@googlemail.com Cc: Georg-Johann Lay , Mike Stump , gcc-patches , Ian Lance Taylor , Kenneth Zadeck , Kenneth Zadeck , ramana.radhakrishnan@linaro.org Subject: Re: [committed] Fix lower-subreg cost calculation References: <4F67D595.9030700@naturalbridge.com> <4F6881EA.9080306@naturalbridge.com> <4F6889CC.8080302@naturalbridge.com> <4F74CFB3.5090308@naturalbridge.com> <4F75D041.4070206@naturalbridge.com> <4F772EF0.8080509@naturalbridge.com> <4F7B183A.8090903@naturalbridge.com> <87r4w4y647.fsf@talisman.home> <4FA2E181.3010302@gjlay.de> <4FA45FB2.8060307@gjlay.de> <87r4uxdtqr.fsf_-_@talisman.home> <4FA93B08.2050709@arm.com> Date: Tue, 08 May 2012 22:42:15 +0100 In-Reply-To: <4FA93B08.2050709@arm.com> (Richard Earnshaw's message of "Tue, 08 May 2012 16:26:00 +0100") Message-ID: <878vh2pcy0.fsf@talisman.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Richard Earnshaw writes: > FTR, this caused > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53278 Well, this really has been a brown-paper-bag patch. Fixed as below. Tested on x86_64-linux-gnu and applied as obvious. Richard gcc/ PR rtl-optimization/53278 * lower-subreg.c (decompose_multiword_subregs): Remove left-over speed_p code from earlier patch. Index: gcc/lower-subreg.c =================================================================== --- gcc/lower-subreg.c 2012-05-08 19:45:31.000000000 +0100 +++ gcc/lower-subreg.c 2012-05-08 19:45:31.793855523 +0100 @@ -1487,9 +1487,7 @@ decompose_multiword_subregs (void) FOR_EACH_BB (bb) { rtx insn; - bool speed_p; - speed_p = optimize_bb_for_speed_p (bb); FOR_BB_INSNS (bb, insn) { rtx pat;