| Message ID | 81be254c-5f4a-1bb5-3ec3-fdbc539590e9@suse.cz |
|---|---|
| State | New |
| Headers | show |
| Series | Remove unused variable. | expand |
On 5/13/2021 3:06 AM, Martin Liška wrote: > Addresses the following clang warning: > gcc/tree-ssa-dom.c:652:33: warning: private field 'm_simplifier' is > not used [-Wunused-private-field] > > Ready for master? > Thanks > > gcc/ChangeLog: > > * tree-ssa-dom.c: Remove m_simplifier. I wonder if Aldy's refactor accidentally dropped the ephemeral simplifications based on the threading path equivalences which is what I think this is supposed to be supporting. Given that the refactor didn't cause any regressions, if that capability did get dropped, it couldn't be too important anymore. OK for the trunk, Jeff
On Thu, May 13, 2021 at 9:43 AM Jeff Law via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > > On 5/13/2021 3:06 AM, Martin Liška wrote: > > Addresses the following clang warning: > > gcc/tree-ssa-dom.c:652:33: warning: private field 'm_simplifier' is > > not used [-Wunused-private-field] > > > > Ready for master? > > Thanks > > > > gcc/ChangeLog: > > > > * tree-ssa-dom.c: Remove m_simplifier. > > I wonder if Aldy's refactor accidentally dropped the ephemeral > simplifications based on the threading path equivalences which is what I > think this is supposed to be supporting. Given that the refactor didn't > cause any regressions, if that capability did get dropped, it couldn't > be too important anymore. The dom_opt_dom_walker is instantiated with a threader, which contains a simplifier. So it got shuffled around, but the functionality should still be there. Thanks for catching this Martin. Aldy
diff --git a/gcc/tree-ssa-dom.c b/gcc/tree-ssa-dom.c index 11b86b2a326..075b1ccb9de 100644 --- a/gcc/tree-ssa-dom.c +++ b/gcc/tree-ssa-dom.c @@ -649,7 +649,6 @@ private: void test_for_singularity (gimple *, avail_exprs_stack *); - dom_jump_threader_simplifier *m_simplifier; jump_threader *m_threader; evrp_range_analyzer *m_evrp_range_analyzer; };