From patchwork Mon Aug 14 20:14:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Makarov X-Patchwork-Id: 1821119 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=NWH9+sjl; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RPlxk5K1rz1yfZ for ; Tue, 15 Aug 2023 06:15:05 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9CD1A3857711 for ; Mon, 14 Aug 2023 20:15:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9CD1A3857711 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1692044103; bh=P1Lq/HmbaFWhoIqumG7j1TOD1CWz0cPHCb21Xm+t4uo=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=NWH9+sjloNnehBO2hzHXuqOUPPUFOvEa2XX4uH1T+2d6p+Cek6LheFYv1rKSyoZPT GLM1Rhda/CrZGOCxlLzAcSM4rT9pEUfMAUuyq7SsSa+vFWanPYbhpDiTAzfD1+sNKz KUGPD4NSlDmIh0FUBz+h/DMAklLVyEkyJSgP4Hn4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 29CF53858C3A for ; Mon, 14 Aug 2023 20:14:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29CF53858C3A Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-BuGxwbAtMCueTEIKr9N1Xg-1; Mon, 14 Aug 2023 16:14:42 -0400 X-MC-Unique: BuGxwbAtMCueTEIKr9N1Xg-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-5eee6742285so64595606d6.2 for ; Mon, 14 Aug 2023 13:14:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692044081; x=1692648881; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RS6xDz3Xgx5Zi5MwZPBSTCz3lUs6hvNM2z/X9eX/8OY=; b=gprsOgK9OTT8826Ln2rX9V0c5cIkEEM23w8GDi3RawSHnDFcG+vAS6uv/eBdqGisdf 3q/NmneRNbQJWZGm3KUM9YGX0UlHFoGeAmAWarflAapUl9A9Ok5ISZukUMOACaCHrM9G gln2hcpcEniezoesaW0Cs/hDs9IkWHnN4cvm5QuzAmYn+VQ/bf1cQyfUnDTOgqI2coTo MFTQRwpUh/BgyIYif0KfLvKx7k4Zqt/T6vnB5sgGaxsnK80y75wtFzrCc7lb9+ZegIe8 T4r0/PCzC2XFmS3l+ozyA/tcb6Tk6Z6vFnzVdlWPlIbpctioX2QThDNK8L5UKCHDeTQD u9iQ== X-Gm-Message-State: AOJu0YwlNyGMmoYMzbL01P/AfcAikUXpLcUxr/hpfkD88b68DrtmaAO4 qWSbkBFuguDW14q40M7dJ6BfI3F4u86IsYlCGJv3MV2bKjVIfMNPHQT1WtV0zJOO0cbfMTFlQbe iDc3bCKxMyHBe8sfhP+rIkfRU5CM9ymLhfxFaolfHsnh1PAjske+Vc+zqdUUG4/ytujVNk0qNxC 9fRQ== X-Received: by 2002:a0c:b2db:0:b0:63c:eb1e:e004 with SMTP id d27-20020a0cb2db000000b0063ceb1ee004mr10693805qvf.3.1692044081389; Mon, 14 Aug 2023 13:14:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOVazyisqRZHRS9VASbs9HGDJDgvzG0LyfGkDPVV0vBqLlSfSoZ/wQLmvB4tB2U5zBh/ht1A== X-Received: by 2002:a0c:b2db:0:b0:63c:eb1e:e004 with SMTP id d27-20020a0cb2db000000b0063ceb1ee004mr10693794qvf.3.1692044080951; Mon, 14 Aug 2023 13:14:40 -0700 (PDT) Received: from [192.168.1.88] (192-0-143-139.cpe.teksavvy.com. [192.0.143.139]) by smtp.gmail.com with ESMTPSA id s14-20020a0cdc0e000000b006431027ac44sm1213518qvk.83.2023.08.14.13.14.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 13:14:40 -0700 (PDT) Message-ID: <780e30e6-6005-5ff8-bf30-8e65a573d4c3@redhat.com> Date: Mon, 14 Aug 2023 16:14:39 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: "gcc-patches@gcc.gnu.org" Subject: [pushed][LRA]: Process output stack pointer reloads before emitting reload insns X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Vladimir Makarov via Gcc-patches From: Vladimir Makarov Reply-To: Vladimir Makarov Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" The patch fixes a failure of building aarch64 port with my yesterday patch. The patch was successfully bootstrapped on x86-64 and aarch64. commit c4760c0161f92b92361feba11836e3d066bb330c Author: Vladimir N. Makarov Date: Mon Aug 14 16:06:27 2023 -0400 [LRA]: Process output stack pointer reloads before emitting reload insns Previous patch setting up asserts for processing stack pointer reloads caught an error in code moving sp offset. This resulted in failure of building aarch64 port. The code wrongly processed insns beyond the output reloads of the current insn. This patch fixes it. gcc/ChangeLog: * lra-constraints.cc (curr_insn_transform): Process output stack pointer reloads before emitting reload insns. diff --git a/gcc/lra-constraints.cc b/gcc/lra-constraints.cc index 8d9443adeb6..c718bedff32 100644 --- a/gcc/lra-constraints.cc +++ b/gcc/lra-constraints.cc @@ -4840,7 +4840,6 @@ curr_insn_transform (bool check_only_p) /* Most probably there are no enough registers to satisfy asm insn: */ lra_asm_insn_error (curr_insn); } - lra_process_new_insns (curr_insn, before, after, "Inserting insn reload"); if (goal_alt_out_sp_reload_p) { /* We have an output stack pointer reload -- update sp offset: */ @@ -4863,6 +4862,7 @@ curr_insn_transform (bool check_only_p) } lra_assert (done_p); } + lra_process_new_insns (curr_insn, before, after, "Inserting insn reload"); return change_p; }