From patchwork Wed Aug 23 09:26:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Preudhomme X-Patchwork-Id: 804906 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-460769-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="yvpz4Qlh"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xchrd2gtCz9s8V for ; Wed, 23 Aug 2017 19:26:38 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=A492L7EpFbjLgmlbOjFR2T401izBRXlaiwIimnb0cpSy5/os2p O4t0/nF0M6V8jPv/9yXhdMoN4DWV6pKEbhzsUsn/zIx1XEZddry1Ne8ll7YvI3aq 9SRi9ldbJq7TTeqbFYoeYMt36EP6WN5OaT+VgVh99Bd1VEnL/rlzYjqlg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=rl0ijaBhEg9mM+BejNmhmL0l/Nc=; b=yvpz4Qlhve/sOQzX4yJX HRbKLMTnVGBJTJumGrJwC+MDPT7nEYmPxoM1WAfvkWIHv+1ExllemVv9gzd9mqhZ zpdFg4kVfOcL2tU2xKp03UoTIvZWq7vANjHni7BiHW9JehvanscwAA2zKb5VjCpE qhz6y84dpSwYTouIRi8Px4U= Received: (qmail 105127 invoked by alias); 23 Aug 2017 09:26:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 104802 invoked by uid 89); 23 Aug 2017 09:26:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:948 X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 09:26:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1319880D; Wed, 23 Aug 2017 02:26:27 -0700 (PDT) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 45F723F577; Wed, 23 Aug 2017 02:26:26 -0700 (PDT) To: Jonathan Yong <10walls@gmail.com>, Jakub Jelinek , Richard Biener , "gcc-patches@gcc.gnu.org" From: Thomas Preudhomme Subject: [PATCH, GCC, RFC] Fix broken MinGW build Message-ID: <6a0fa6c6-cbef-246f-7479-8836e408f92b@foss.arm.com> Date: Wed, 23 Aug 2017 10:26:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 X-IsSubscribed: yes Hi, Commit r251104 introduced uses of SIGKILL and SIGQUIT which broke MinGW build due to those not being defined. This proposed patch check for the macros availability. ChangeLog entry is as follows: *** gcc/ChangeLog *** 2017-08-23 Thomas Preud'homme * gcc.c (execute): Only test for SIGKILL and SIGQUIT if available. Is this an appropriate fix for the issue? Best regards, Thomas diff --git a/gcc/gcc.c b/gcc/gcc.c index 96152dec87278f7f9491db4dbd2a03124547c42b..832a2e0c6caddac6aae526c0e8466d07b31725c8 100644 --- a/gcc/gcc.c +++ b/gcc/gcc.c @@ -3154,8 +3154,13 @@ execute (void) switch (WTERMSIG (status)) { case SIGINT: + /* SIGQUIT and SIGKILL are not available on MinGW. */ +#ifdef SIGQUIT case SIGQUIT: +#endif +#ifdef SIGKILL case SIGKILL: +#endif case SIGTERM: /* The user (or environment) did something to the inferior. Making this an ICE confuses the user