From patchwork Sat Dec 10 10:15:42 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Sandoe X-Patchwork-Id: 130518 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 904B41007D7 for ; Sat, 10 Dec 2011 21:16:11 +1100 (EST) Received: (qmail 5691 invoked by alias); 10 Dec 2011 10:16:08 -0000 Received: (qmail 5682 invoked by uid 22791); 10 Dec 2011 10:16:07 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from c2beaomr07.btconnect.com (HELO mail.btconnect.com) (213.123.26.185) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Dec 2011 10:15:51 +0000 Received: from host81-138-1-83.in-addr.btopenworld.com (EHLO thor.office) ([81.138.1.83]) by c2beaomr07.btconnect.com with ESMTP id FMI17257; Sat, 10 Dec 2011 10:15:43 +0000 (GMT) Cc: Jakub Jelinek , Dominique Dhumieres , GCC Patches Message-Id: <69E4112B-C062-42EF-86A7-6674888D1582@sandoe-acoustics.co.uk> From: Iain Sandoe To: Aldy Hernandez In-Reply-To: <62756D2C-85B1-4DAA-AA5A-82F43B699C0C@sandoe-acoustics.co.uk> Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin Date: Sat, 10 Dec 2011 10:15:42 +0000 References: <20111209191704.6F9AC3BE1B@mailhost.lps.ens.fr> <20111209191929.GB1957@tyan-ft48-01.lab.bos.redhat.com> <4EE2656C.4080801@redhat.com> <62756D2C-85B1-4DAA-AA5A-82F43B699C0C@sandoe-acoustics.co.uk> X-Mirapoint-IP-Reputation: reputation=Fair-1, source=Queried, refid=tid=0001.0A0B0302.4EE3314F.0033, actions=tag X-Junkmail-Premium-Raw: score=8/50, refid=2.7.2:2011.12.10.93614:17:8.129, ip=81.138.1.83, rules=__MULTIPLE_RCPTS_CC_X2, __HAS_MSGID, __SANE_MSGID, __MSGID_APPLEMAIL, __TO_MALFORMED_2, __CT, __CTYPE_HAS_BOUNDARY, __CTYPE_MULTIPART, CTYPE_MULTIPART_NO_QUOTE, __CTYPE_MULTIPART_MIXED, __MIME_VERSION, __MIME_VERSION_APPLEMAIL, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __HAS_X_MAILER, __X_MAILER_APPLEMAIL, TXT_ATTACHED, __CP_MEDIA_BODY, BODY_SIZE_1700_1799, BODYTEXTP_SIZE_3000_LESS, __MIME_TEXT_ONLY, RDNS_GENERIC_POOLED, BODY_SIZE_5000_LESS, RDNS_SUSP_GENERIC, __USER_AGENT_APPLEMAIL, MULTIPLE_RCPTS, RDNS_SUSP, BODY_SIZE_2000_LESS, BODY_SIZE_7000_LESS, NO_URI_FOUND, MIME_TEXT_ONLY_MP_MIXED X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A0B0205.4EE3314F.0165, ss=1, re=0.000, fgs=0, ip=0.0.0.0, so=2011-07-25 19:15:43, dmn=2011-05-27 18:58:46, mode=multiengine X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 9 Dec 2011, at 20:56, Iain Sandoe wrote: > > [[** I'm checking out whether it's feasible to switch off PIC for > m64 Darwin .. so one could just do the test -fno-PIC .. > ... works for m32 - but PIC is jammed on for x86/m64 ... ]] I guess the problem is that, whilst we *could* arrange to allow PIC to be switched off for x86-64 darwin, it is not supported by the system, which could open up a different can of worms with Users trying something that is bound to fail.... so what about this as a compromise - - the test that Jakub identifies as not particularly strong is only applied to Darwin - for which it would seem to check the output adequately. does this work elsewhere? Iain Index: gcc/testsuite/c-c++-common/cxxbitfields-3.c =================================================================== --- gcc/testsuite/c-c++-common/cxxbitfields-3.c (revision 182177) +++ gcc/testsuite/c-c++-common/cxxbitfields-3.c (working copy) @@ -18,4 +18,5 @@ void setit() var.j = 5; } -/* { dg-final { scan-assembler "movl.*, var" } } */ +/* { dg-final { scan-assembler "movl.*, _?var" { target { ! *-*-darwin* } } } } */ +/* { dg-final { scan-assembler "movl.*, (_?var|\\(%)" { target *-*-darwin* } } } */