diff mbox

Fix anonymous code atoms problem on Darwin.

Message ID 6466C461-AC3F-42AD-A0E3-52F24BA1E2C4@sandoe-acoustics.co.uk
State New
Headers show

Commit Message

Iain Sandoe Feb. 8, 2011, 8:19 a.m. UTC 
On 8 Feb 2011, at 03:01, Mike Stump wrote:

> On Dec 20, 2010, at 3:07 AM, IainS wrote:
>> This problem became apparent during the resolution of PR46904/46916  
>> (we have had to switch off freorder-and-partition to avoid  
>> regression).
>
>> gcc:
>>
>> 	* target.def (function_switched_text_sections): New Hook.
>> 	* doc/tm.texi Regenerated.
>> 	* doc/tm.texi.in (TARGET_ASM_FUNCTION_SWITCHED_TEXT_SECTIONS)
>> 	New.
>> 	* final.c (default_function_switched_text_sections): New.
>> 	(final_scan_insn): Call function_switched_text_sections when a mid- 
>> function section
>> 	change occurs.
>> 	* output.h (default_function_switched_text_sections): Declare.
>> 	* config/darwin-protos.h  
>> (darwin_function_switched_text_sections) : Likewise.
>> 	* config/darwin.c (darwin_function_switched_text_sections): New.
>> 	* config/darwin.h (TARGET_ASM_FUNCTION_SWITCHED_TEXT_SECTIONS)
>> 	New.
>
> This posted patch does not match what was checked in r168571.  Could  
> you please audit what was checked in and ensure it is as you  
> wanted.  Thanks.

Yes, the commit matches what was intended.

(and as per the comment in http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00354.html 
  in this thread).

I attached the wrong file (test results instead of the diff) for the  
actual commit :-( sorry.

Looking at it with fresh eyes, I see that there is a comment that is  
incorrect (the code is as intended).
I'll fix that up - as below.

cheers
Iain

        we will switch off -freorder-blocks-and-partition when unwind  
tables will be
        generated".  If the User specifically sets flags... we assume  
(s)he knows
diff mbox

Patch

Index: gcc/config/darwin.c
===================================================================
--- gcc/config/darwin.c (revision 169878)
+++ gcc/config/darwin.c (working copy)
@@ -2581,7 +2581,7 @@  darwin_override_options (void)
      global_options.x_flag_asynchronous_unwind_tables = 0;

     /* Disable -freorder-blocks-and-partition when unwind tables are  
being emitted
-      for Darwin < 10 (OSX 10.6).
+      for Darwin < 9 (OSX 10.5).
        The strategy is, "Unless the User has specifically set/unset  
an unwind flag