From patchwork Thu Jun 30 16:25:23 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 102780 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id BD093B6F18 for ; Fri, 1 Jul 2011 02:25:47 +1000 (EST) Received: (qmail 13277 invoked by alias); 30 Jun 2011 16:25:45 -0000 Received: (qmail 13264 invoked by uid 22791); 30 Jun 2011 16:25:43 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from qmta06.emeryville.ca.mail.comcast.net (HELO qmta06.emeryville.ca.mail.comcast.net) (76.96.30.56) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Jun 2011 16:25:29 +0000 Received: from omta16.emeryville.ca.mail.comcast.net ([76.96.30.72]) by qmta06.emeryville.ca.mail.comcast.net with comcast id 2GMV1h0061ZMdJ4A6GRT2F; Thu, 30 Jun 2011 16:25:27 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta16.emeryville.ca.mail.comcast.net with comcast id 2GPo1h00A0BKwT48cGPooR; Thu, 30 Jun 2011 16:23:49 +0000 Subject: Re: [PATCH][Revised] Pass -no_pie on SYSTEMSPEC for darwin11 Mime-Version: 1.0 (Apple Message framework v1084) From: Mike Stump In-Reply-To: <20110619235544.GA32119@bromo.med.uc.edu> Date: Thu, 30 Jun 2011 09:25:23 -0700 Cc: GCC Patches Message-Id: <61DAD638-A211-4731-AB84-1537228AAD36@comcast.net> References: <20110618024913.GA29537@bromo.med.uc.edu> <8035A572-9078-46F4-9172-8CB269E1E854@comcast.net> <20110619194319.GA30493@bromo.med.uc.edu> <2E904208-081C-4223-80BA-921240A0CCDF@comcast.net> <20110619230732.GB31789@bromo.med.uc.edu> <47DFC4C2-9E8E-40BD-BA97-2314A8263A68@comcast.net> <20110619235544.GA32119@bromo.med.uc.edu> To: Jack Howarth X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Jun 19, 2011, at 4:55 PM, Jack Howarth wrote: >>> This is definitely a problem in current gcc-4_5-branch without the backport of the SYSTEMSPEC fix... >> >> Excellent... and does the patch fix it? > > Yes... Ok, applied to the 4.5 branch. Scream loud and soon if for any reason you notice anything that isn't release quality. I think we have enough bake time on 4.6 and mainline to avoid any downsides, but, also nice to be careful with the release branches. Thanks for all your help. Index: configure.ac =================================================================== --- configure.ac (revision 175709) +++ configure.ac (working copy) @@ -882,8 +882,13 @@ case "${host}" in SYSTEMSPEC="-lunicows $SYSTEMSPEC" fi ;; - *-*-darwin[[912]]*) - SYSTEMSPEC="-allow_stack_execute" + *-*-darwin9*) + SYSTEMSPEC="%{!Zdynamiclib:%{!Zbundle:-allow_stack_execute}}" + ;; + *-*-darwin[[12]]*) + # Something is incompatible with pie, would be nice to fix it and + # remove -no_pie. PR49461 + SYSTEMSPEC="-no_pie %{!Zdynamiclib:%{!Zbundle:-allow_stack_execute}}" ;; *) SYSTEMSPEC= Index: ChangeLog =================================================================== --- ChangeLog (revision 175709) +++ ChangeLog (working copy) @@ -1,3 +1,9 @@ +2011-06-30 Jack Howarth + + PR target/49461 + * libjava/configure.ac (SYSTEMSPEC): Pass -no_pie for darwin11. + * libjava/configure: Regenerate. + 2011-04-28 Release Manager * GCC 4.5.3 released. Index: configure =================================================================== --- configure (revision 175709) +++ configure (working copy) @@ -19754,8 +19754,13 @@ case "${host}" in SYSTEMSPEC="-lunicows $SYSTEMSPEC" fi ;; - *-*-darwin[912]*) - SYSTEMSPEC="-allow_stack_execute" + *-*-darwin9*) + SYSTEMSPEC="%{!Zdynamiclib:%{!Zbundle:-allow_stack_execute}}" + ;; + *-*-darwin[12]*) + # Something is incompatible with pie, would be nice to fix it and + # remove -no_pie. PR49461 + SYSTEMSPEC="-no_pie %{!Zdynamiclib:%{!Zbundle:-allow_stack_execute}}" ;; *) SYSTEMSPEC=