| Message ID | 56EADDCE.7020104@arm.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Mar 17, 2016 at 4:39 PM, Andre Vieira (lists) <Andre.SimoesDiasVieira@arm.com> wrote: > Hello, > > This patch skips four tests that assume a target supports ARM mode when > testing M-profiles. > Tested it by running the four tests for A-profiles and M-profiles. > > Is this ok? OK. Ramana > > Cheers, > Andre > > gcc/testsuite/ChangeLog: > 2016-03-17 Andre Vieira <andre.simoesdiasvieira@arm> > > * gcc/testsuite/gcc.target/arm/attr-align1.c: Skip if M-profile. > * gcc/testsuite/gcc.target/arm/attr-align3.c: Likewise. > * gcc/testsuite/gcc.target/arm/attr_arm.c: Likewise. > * gcc/testsuite/gcc.target/arm/flip-thumb.c: Likewise.
On 21/03/16 10:39, Ramana Radhakrishnan wrote: > On Thu, Mar 17, 2016 at 4:39 PM, Andre Vieira (lists) > <Andre.SimoesDiasVieira@arm.com> wrote: >> Hello, >> >> This patch skips four tests that assume a target supports ARM mode when >> testing M-profiles. >> Tested it by running the four tests for A-profiles and M-profiles. >> >> Is this ok? > > OK. > > Ramana >> >> Cheers, >> Andre >> >> gcc/testsuite/ChangeLog: >> 2016-03-17 Andre Vieira <andre.simoesdiasvieira@arm> >> >> * gcc/testsuite/gcc.target/arm/attr-align1.c: Skip if M-profile. >> * gcc/testsuite/gcc.target/arm/attr-align3.c: Likewise. >> * gcc/testsuite/gcc.target/arm/attr_arm.c: Likewise. >> * gcc/testsuite/gcc.target/arm/flip-thumb.c: Likewise. > Committed by Thomas on revision r234373 with fixed ChangeLog (removed the 'gcc/testsuite' parts. Cheers, Andre
diff --git a/gcc/testsuite/gcc.target/arm/attr-align1.c b/gcc/testsuite/gcc.target/arm/attr-align1.c index 96d29a9eed5a81306cb90393a2eb4fe7236ae50b..a53f16706860b69fcc60071b818fbc9f89fc33c7 100644 --- a/gcc/testsuite/gcc.target/arm/attr-align1.c +++ b/gcc/testsuite/gcc.target/arm/attr-align1.c @@ -2,6 +2,7 @@ Verify alignment when both attribute optimize and target are used. */ /* { dg-do compile } */ /* { dg-skip-if "" { ! { arm_thumb1_ok || arm_thumb2_ok } } } */ +/* { dg-skip-if "" arm_cortex_m } */ void __attribute__ ((target ("arm"))) diff --git a/gcc/testsuite/gcc.target/arm/attr-align3.c b/gcc/testsuite/gcc.target/arm/attr-align3.c index edcf64b45e053eca4ae5f0be2de3afd7b674f464..593d7fbc2b999d264cb06f54363c471480117f32 100644 --- a/gcc/testsuite/gcc.target/arm/attr-align3.c +++ b/gcc/testsuite/gcc.target/arm/attr-align3.c @@ -2,6 +2,7 @@ Verify alignment when attribute target is used. */ /* { dg-do compile } */ /* { dg-skip-if "" { ! { arm_thumb1_ok || arm_thumb2_ok } } } */ +/* { dg-skip-if "" arm_cortex_m } */ /* { dg-options "-Os -mthumb" } */ /* Check that arm code is always 4 bytes aligned. */ diff --git a/gcc/testsuite/gcc.target/arm/attr_arm.c b/gcc/testsuite/gcc.target/arm/attr_arm.c index f5c70ef690fc68425e0c4a0f458cd73ebde2f0ab..d765d121e2965a440234a1793688bc97aa60d831 100644 --- a/gcc/testsuite/gcc.target/arm/attr_arm.c +++ b/gcc/testsuite/gcc.target/arm/attr_arm.c @@ -1,5 +1,6 @@ /* Check that attribute target arm is recognized. */ /* { dg-do compile } */ +/* { dg-skip-if "" arm_cortex_m } */ /* { dg-final { scan-assembler "\\.arm" } } */ /* { dg-final { scan-assembler-not "\\.thumb_func" } } */ diff --git a/gcc/testsuite/gcc.target/arm/flip-thumb.c b/gcc/testsuite/gcc.target/arm/flip-thumb.c index 355d66377558d9007f58056180940122fcf148e0..4bbe546b6325b2cbc9f9b7f7c52c29815c231916 100644 --- a/gcc/testsuite/gcc.target/arm/flip-thumb.c +++ b/gcc/testsuite/gcc.target/arm/flip-thumb.c @@ -2,6 +2,7 @@ /* { dg-do compile } */ /* Make sure the current multilib supports thumb. */ /* { dg-skip-if "" { ! { arm_thumb1_ok || arm_thumb2_ok } } } */ +/* { dg-skip-if "" arm_cortex_m } */ /* { dg-options "-O2 -mflip-thumb -mno-restrict-it" } */ /* { dg-final { scan-assembler "\\.arm" } } */ /* { dg-final { scan-assembler-times "\\.thumb_func" 1} } */
Hello, This patch skips four tests that assume a target supports ARM mode when testing M-profiles. Tested it by running the four tests for A-profiles and M-profiles. Is this ok? Cheers, Andre gcc/testsuite/ChangeLog: 2016-03-17 Andre Vieira <andre.simoesdiasvieira@arm> * gcc/testsuite/gcc.target/arm/attr-align1.c: Skip if M-profile. * gcc/testsuite/gcc.target/arm/attr-align3.c: Likewise. * gcc/testsuite/gcc.target/arm/attr_arm.c: Likewise. * gcc/testsuite/gcc.target/arm/flip-thumb.c: Likewise.