diff mbox

[ARM] testcase memset-inline-10.c uses -mfloat-abi=hard but does not check whether target supports it

Message ID 5644AD4E.2060004@arm.com
State New
Headers show

Commit Message

Andre Vieira Nov. 12, 2015, 3:16 p.m. UTC 
On 12/11/15 15:08, Andre Vieira wrote:
> Hi,
>
>    This patch changes the memset-inline-10.c testcase to make sure that
> it is only compiled for ARM targets that support -mfloat-abi=hard using
> the fact that all non-thumb1 targets do.
>
>    This is correct because all targets for which -mthumb causes the
> compiler to use thumb2 will support the generation of FP instructions.
>
>    Tested by running regressions for this testcase for various ARM targets.
>
>    Is this OK to commit?
>
>    Thanks,
>    Andre Vieira
>
> gcc/testsuite/ChangeLog:
> 2015-11-06  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>
>          * gcc.target/arm/memset-inline-10.c: Added
>          dg-require-effective-target arm_thumb2_ok.
>
Now with attachment, sorry about that.

Cheers,
Andre

Comments

Andre Vieira Nov. 27, 2015, 2:28 p.m. UTC | #1 
On 12/11/15 15:16, Andre Vieira wrote:
> On 12/11/15 15:08, Andre Vieira wrote:
>> Hi,
>>
>>    This patch changes the memset-inline-10.c testcase to make sure that
>> it is only compiled for ARM targets that support -mfloat-abi=hard using
>> the fact that all non-thumb1 targets do.
>>
>>    This is correct because all targets for which -mthumb causes the
>> compiler to use thumb2 will support the generation of FP instructions.
>>
>>    Tested by running regressions for this testcase for various ARM
>> targets.
>>
>>    Is this OK to commit?
>>
>>    Thanks,
>>    Andre Vieira
>>
>> gcc/testsuite/ChangeLog:
>> 2015-11-06  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>>
>>          * gcc.target/arm/memset-inline-10.c: Added
>>          dg-require-effective-target arm_thumb2_ok.
>>
> Now with attachment, sorry about that.
>
> Cheers,
> Andre

Ping.
Andre Vieira Jan. 5, 2016, 5:40 p.m. UTC | #2 
On 27/11/15 14:28, Andre Vieira wrote:
> On 12/11/15 15:16, Andre Vieira wrote:
>> On 12/11/15 15:08, Andre Vieira wrote:
>>> Hi,
>>>
>>>    This patch changes the memset-inline-10.c testcase to make sure that
>>> it is only compiled for ARM targets that support -mfloat-abi=hard using
>>> the fact that all non-thumb1 targets do.
>>>
>>>    This is correct because all targets for which -mthumb causes the
>>> compiler to use thumb2 will support the generation of FP instructions.
>>>
>>>    Tested by running regressions for this testcase for various ARM
>>> targets.
>>>
>>>    Is this OK to commit?
>>>
>>>    Thanks,
>>>    Andre Vieira
>>>
>>> gcc/testsuite/ChangeLog:
>>> 2015-11-06  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>>>
>>>          * gcc.target/arm/memset-inline-10.c: Added
>>>          dg-require-effective-target arm_thumb2_ok.
>>>
>> Now with attachment, sorry about that.
>>
>> Cheers,
>> Andre
>
> Ping.
>

Ping.
Andre Vieira Jan. 19, 2016, 11:36 a.m. UTC | #3 
On 05/01/16 17:40, Andre Vieira wrote:
> On 27/11/15 14:28, Andre Vieira wrote:
>> On 12/11/15 15:16, Andre Vieira wrote:
>>> On 12/11/15 15:08, Andre Vieira wrote:
>>>> Hi,
>>>>
>>>>    This patch changes the memset-inline-10.c testcase to make sure that
>>>> it is only compiled for ARM targets that support -mfloat-abi=hard using
>>>> the fact that all non-thumb1 targets do.
>>>>
>>>>    This is correct because all targets for which -mthumb causes the
>>>> compiler to use thumb2 will support the generation of FP instructions.
>>>>
>>>>    Tested by running regressions for this testcase for various ARM
>>>> targets.
>>>>
>>>>    Is this OK to commit?
>>>>
>>>>    Thanks,
>>>>    Andre Vieira
>>>>
>>>> gcc/testsuite/ChangeLog:
>>>> 2015-11-06  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>>>>
>>>>          * gcc.target/arm/memset-inline-10.c: Added
>>>>          dg-require-effective-target arm_thumb2_ok.
>>>>
>>> Now with attachment, sorry about that.
>>>
>>> Cheers,
>>> Andre
>>
>> Ping.
>>
>
> Ping.
>
Ping.
Ramana Radhakrishnan Jan. 19, 2016, 11:51 a.m. UTC | #4 
On Thu, Nov 12, 2015 at 3:16 PM, Andre Vieira
<Andre.SimoesDiasVieira@arm.com> wrote:
> On 12/11/15 15:08, Andre Vieira wrote:
>>
>> Hi,
>>
>>    This patch changes the memset-inline-10.c testcase to make sure that
>> it is only compiled for ARM targets that support -mfloat-abi=hard using
>> the fact that all non-thumb1 targets do.
>>
>>    This is correct because all targets for which -mthumb causes the
>> compiler to use thumb2 will support the generation of FP instructions.
>>
>>    Tested by running regressions for this testcase for various ARM
>> targets.
>>
>>    Is this OK to commit?

This is OK - Sorry about the delay in reviewing this.

I'd like to restructure gcc.target/arm if I could at some point to be
more resilient to multilib testing and prevent such long lists of
directives in tests.

regards
Ramana

>>
>>    Thanks,
>>    Andre Vieira
>>
>> gcc/testsuite/ChangeLog:
>> 2015-11-06  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>>
>>          * gcc.target/arm/memset-inline-10.c: Added
>>          dg-require-effective-target arm_thumb2_ok.
>>
> Now with attachment, sorry about that.
>
> Cheers,
> Andre
Christophe Lyon Jan. 20, 2016, 12:56 p.m. UTC | #5 
On 19 January 2016 at 12:51, Ramana Radhakrishnan
<ramana.gcc@googlemail.com> wrote:
> On Thu, Nov 12, 2015 at 3:16 PM, Andre Vieira
> <Andre.SimoesDiasVieira@arm.com> wrote:
>> On 12/11/15 15:08, Andre Vieira wrote:
>>>
>>> Hi,
>>>
>>>    This patch changes the memset-inline-10.c testcase to make sure that
>>> it is only compiled for ARM targets that support -mfloat-abi=hard using
>>> the fact that all non-thumb1 targets do.
>>>
>>>    This is correct because all targets for which -mthumb causes the
>>> compiler to use thumb2 will support the generation of FP instructions.
>>>
>>>    Tested by running regressions for this testcase for various ARM
>>> targets.
>>>
>>>    Is this OK to commit?
>
> This is OK - Sorry about the delay in reviewing this.
>
> I'd like to restructure gcc.target/arm if I could at some point to be
> more resilient to multilib testing and prevent such long lists of
> directives in tests.
>
Indeed, as this patch makes this test now unsupported if one forces
runtestflags to include -marm or -march=armv5t.
thumb2_ok returns false in these cases, but the test used to pass.

Or maybe it's simpler to agree on not using this kind of flags during
validation, and rely on gcc configure flags to set them instead.


> regards
> Ramana
>
>>>
>>>    Thanks,
>>>    Andre Vieira
>>>
>>> gcc/testsuite/ChangeLog:
>>> 2015-11-06  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>>>
>>>          * gcc.target/arm/memset-inline-10.c: Added
>>>          dg-require-effective-target arm_thumb2_ok.
>>>
>> Now with attachment, sorry about that.
>>
>> Cheers,
>> Andre
diff mbox

Patch

From f6515d9cceacf99d213aea1236b7027c7839ab4b Mon Sep 17 00:00:00 2001
From: Andre Simoes Dias Vieira <andsim01@arm.com>
Date: Fri, 6 Nov 2015 14:48:27 +0000
Subject: [PATCH] added check for thumb2_ok

---
 gcc/testsuite/gcc.target/arm/memset-inline-10.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/gcc.target/arm/memset-inline-10.c b/gcc/testsuite/gcc.target/arm/memset-inline-10.c
index c1087c8e693fb723ca9396108f5fe872ede167e9..ce51c1d9eeb800cf67790fe06817ae23215399e9 100644
--- a/gcc/testsuite/gcc.target/arm/memset-inline-10.c
+++ b/gcc/testsuite/gcc.target/arm/memset-inline-10.c
@@ -1,4 +1,5 @@ 
 /* { dg-do compile } */
+/* { dg-require-effective-target arm_thumb2_ok } */
 /* { dg-options "-march=armv7-a -mfloat-abi=hard -mfpu=neon -O2" } */
 /* { dg-skip-if "need SIMD instructions" { *-*-* } { "-mfloat-abi=soft" } { "" } } */
 /* { dg-skip-if "need SIMD instructions" { *-*-* } { "-mfpu=vfp*" } { "" } } */
-- 
1.9.1