diff mbox

[5,regression] re-enable biarch for powerpc-linux-gnu

Message ID 555A11B4.8020605@codesourcery.com
State New
Headers show

Commit Message

Sandra Loosemore May 18, 2015, 4:22 p.m. UTC 
We've found that configuring a powerpc-linux-gnu cross toolchain with 
--enable-targets=all no longer enables -m64 support in GCC 5, due to the 
patch for PR target/65286.  (We want to build with a -m64 multilib, in 
particular.)

The attached patch seems to fix the breakage, but I'm not sure that it 
might not break some other configuration.  If this isn't the right fix, 
can one of the target experts suggest a better one?

Here's a link to the discussion of the patch that caused the breakage:

https://gcc.gnu.org/ml/gcc-patches/2015-03/msg00321.html

-Sandra

Comments

David Edelsohn May 19, 2015, 6:18 p.m. UTC | #1 
This seems reasonable to me.

Alan, any thoughts from you?

Thanks, David


On Mon, May 18, 2015 at 12:22 PM, Sandra Loosemore
<sandra@codesourcery.com> wrote:
> We've found that configuring a powerpc-linux-gnu cross toolchain with
> --enable-targets=all no longer enables -m64 support in GCC 5, due to the
> patch for PR target/65286.  (We want to build with a -m64 multilib, in
> particular.)
>
> The attached patch seems to fix the breakage, but I'm not sure that it might
> not break some other configuration.  If this isn't the right fix, can one of
> the target experts suggest a better one?
>
> Here's a link to the discussion of the patch that caused the breakage:
>
> https://gcc.gnu.org/ml/gcc-patches/2015-03/msg00321.html
>
> -Sandra
>
Alan Modra May 19, 2015, 11:34 p.m. UTC | #2 
On Tue, May 19, 2015 at 02:18:23PM -0400, David Edelsohn wrote:
> This seems reasonable to me.
> 
> Alan, any thoughts from you?

Looks good.
Sandra Loosemore May 20, 2015, 12:03 a.m. UTC | #3 
On 05/19/2015 05:34 PM, Alan Modra wrote:
> On Tue, May 19, 2015 at 02:18:23PM -0400, David Edelsohn wrote:
>> This seems reasonable to me.
>>
>> Alan, any thoughts from you?
>
> Looks good.

Thanks.  I've checked the patch into mainline (r223418).  I assume this 
is also a candidate for backporting to the same branches where the PR 
target/65286 patch went?

-Sandra
David Edelsohn May 20, 2015, 2:36 a.m. UTC | #4 
On Tue, May 19, 2015 at 8:03 PM, Sandra Loosemore
<sandra@codesourcery.com> wrote:
> On 05/19/2015 05:34 PM, Alan Modra wrote:
>>
>> On Tue, May 19, 2015 at 02:18:23PM -0400, David Edelsohn wrote:
>>>
>>> This seems reasonable to me.
>>>
>>> Alan, any thoughts from you?
>>
>>
>> Looks good.
>
>
> Thanks.  I've checked the patch into mainline (r223418).  I assume this is
> also a candidate for backporting to the same branches where the PR
> target/65286 patch went?

Okay.

Thanks, David
diff mbox

Patch

Index: gcc/config.gcc
===================================================================
--- gcc/config.gcc	(revision 449971)
+++ gcc/config.gcc	(working copy)
@@ -2376,6 +2379,7 @@  powerpc*-*-linux*)
 	maybe_biarch=${cpu_is_64bit}
 	case ${enable_targets} in
 	    *powerpc64*) maybe_biarch=yes ;;
+	    all) maybe_biarch=yes ;;
 	esac
 	case ${target} in
 	    powerpc64*-*-linux*spe* | powerpc64*-*-linux*paired*)