From patchwork Sat May 16 19:58:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jerry DeLisle X-Patchwork-Id: 473089 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 12D6D14077A for ; Sun, 17 May 2015 05:58:57 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=XGIXCkym; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; q=dns; s= default; b=SsiPSkGw0dhxpr7IsMa4Kyleq1mzqy5l7/EgT5TBiB1A4i6GaVF13 TIe/unMxzK1TOO0jJAF1bdd0r5+JyvDwD3Jm3dLqDt34FVcnz702Drol1wRKaXgJ Y26Y2mBID5bEWypb1Dv1VRZK+oxDW3yq9Q8OIxC+Vc6EWM79/hVg1o= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=default; bh=DRRZAwVlzFFl3sVcoubM4v9aOrc=; b=XGIXCkym6SpG0elt/+i+V5roc+jP OyfjaGBpjVmKuB8/nniM/LkEGIDAn8QjzCiePUiYYIGgru7UZnnYzOtjwOSlkv84 HV3qwCXB2UjA1MpMgpkAjTPjWsa3wNlqcQHiEVmFQ3V2dkl3jDd+hMRnntw1k1WA hqq05MdUs6MLO9E= Received: (qmail 65818 invoked by alias); 16 May 2015 19:58:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 65798 invoked by uid 89); 16 May 2015 19:58:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mta31.charter.net Received: from mta31.charter.net (HELO mta31.charter.net) (216.33.127.82) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 16 May 2015 19:58:47 +0000 Received: from imp09 ([10.20.200.9]) by mta31.charter.net (InterMail vM.8.01.05.02 201-2260-151-103-20110920) with ESMTP id <20150516195845.SZGO10321.mta31.charter.net@imp09>; Sat, 16 May 2015 15:58:45 -0400 Received: from mtaout003.msg.strl.va.charter.net ([68.114.190.28]) by imp09 with smtp.charter.net id Ujyl1q0010dCcRg05jylmn; Sat, 16 May 2015 15:58:45 -0400 Received: from impout003 ([68.114.189.18]) by mtaout003.msg.strl.va.charter.net (InterMail vM.9.00.015.01 201-2473-143-101) with ESMTP id <20150516195845.YUMM11160.mtaout003.msg.strl.va.charter.net@impout003>; Sat, 16 May 2015 14:58:45 -0500 Received: from amda8.localdomain ([70.209.205.249]) by impout003 with charter.net id Ujyb1q00J5PNqty01jydf1; Sat, 16 May 2015 14:58:45 -0500 X-Authority-Analysis: v=2.1 cv=QJPmR27L c=1 sm=1 tr=0 a=DAmnlGlbQeIyYR8+cr31Fg==:117 a=DAmnlGlbQeIyYR8+cr31Fg==:17 a=hOpmn2quAAAA:8 a=KOg_qkMfzZkA:10 a=N659UExz7-8A:10 a=2HKPbedXSztXyvAXE6UA:9 a=pILNOxqGKmIA:10 X-Auth-id: anZkZWxpc2xlQGNoYXJ0ZXIubmV0 Message-ID: <5557A15D.3020205@charter.net> Date: Sat, 16 May 2015 12:58:21 -0700 From: Jerry DeLisle User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Steve Kargl CC: gfortran , gcc patches Subject: Re: [patch, fortran] [5/6 Regression] Line continuation followed by comment character in string fails to compile References: <55540130.5080206@charter.net> <555759B6.1070901@charter.net> <20150516151156.GA89083@troutmask.apl.washington.edu> <55578226.60701@charter.net> In-Reply-To: <55578226.60701@charter.net> On 05/16/2015 10:45 AM, Jerry DeLisle wrote: --- snip --- > Thanks Steve, > > Committed revision 223248. > > I had some time to play with this a little more this afternoon. I am going to commit the following little patchlet that gives us the nice warning we should have. (After full regression testing of course) gfc -Wall continuation_13.f90 continuation_13.f90:22:4: Warning: Missing ‘&’ in continued character constant at (1) [-Wampersand] continuation_13.f90:24:4: Warning: Missing ‘&’ in continued character constant at (1) [-Wampersand] Index: scanner.c =================================================================== --- scanner.c (revision 223250) +++ scanner.c (working copy) @@ -1383,7 +1383,12 @@ "constant at %C"); } else if (!in_string && (c == '\'' || c == '"')) + { + gfc_warning (OPT_Wampersand, + "Missing %<&%> in continued character " + "constant at %C"); goto done; + } /* Both !$omp and !$ -fopenmp continuation lines have & on the continuation line only optionally. */ else if (openmp_flag || openacc_flag || openmp_cond_flag)