From patchwork Tue May 12 14:54:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 471376 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4EE17140D23 for ; Wed, 13 May 2015 00:54:55 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=hH68kybu; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; q=dns; s=default; b=yTwTeZl9Pmr2b22zc sEo7KLXXHoHF0OoDdvWNrX7+9LcMrwj1qLbpB+H/rDr50NBdsrhemAqcvVeDujT2 eljpgg4LgsweVN3SXrUEYfqLN76CzGbrQZwxsK4pkEgJMAIbX2bRWdkL9SJZvrw7 Ar3HJd4iEkfXI6TgVkeHO98gDI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; s=default; bh=/2tVrNrk3agbXKUVhN0xySD NmrI=; b=hH68kybu15jqFSLhULt6wOKbIYRNBWXcZufiLa5TXbdZwCSqZ4c53/a UfftvdiEJOb1mKKwgIH9Mmxs+4Lcl1w0epbTUFu0sgM4cKOjG0w3ZXBdaSASwp0G d6cShZO7mZe5U1Xad1Z24wLMW4pE2yCnhcdKLdGTv3F6c2YPUdRM= Received: (qmail 41892 invoked by alias); 12 May 2015 14:54:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 41877 invoked by uid 89); 12 May 2015 14:54:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 12 May 2015 14:54:45 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D09B2ABEB; Tue, 12 May 2015 14:54:41 +0000 (UTC) Message-ID: <55521431.5090204@suse.cz> Date: Tue, 12 May 2015 16:54:41 +0200 From: =?UTF-8?B?TWFydGluIExpxaFrYQ==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Uros Bizjak , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] Fix PR ipa/65557 References: In-Reply-To: X-IsSubscribed: yes On 04/30/2015 11:11 PM, Uros Bizjak wrote: > Hello! > >> 2015-03-29 Martin Liska >> >> PR ipa/65557 >> * ipa-icf.c (sem_function::equals_wpa): Check if IPA CP >> has already filled up function summary. >> (sem_item_optimizer::update_hash_by_addr_refs): Likewise. >> >> gcc/testsuite/ChangeLog: >> >> 2015-03-29 Martin Liska >> >> * g++.dg/ipa/pr65557.C: New test. > > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ipa/pr65557.C > @@ -0,0 +1,19 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -fdump-ipa-icf-details" } */ > + > +struct S0 > +{ > + S0 () > + { > + } > +}; > + > +struct S1 > +{ > + S1 () > + { > + } > +}; > + > +S0 s0; > +S1 s1; > > The testcase doesn't clean its IPA dump. However, there is also no > scan dump function, so it is questionable, what the testcase tries to > do with the dump. Also, the flags that trigger the bug in the PR are > different: "-fdevirtualize -fipa-cp -fipa-icf-functions". > > Can you please check the testcase? > > Uros. > Hi. The test case caused ICE before the patch was applied. So removing -fdump* is the right fix for the test. I hope the patch is obvious. Should I also apply the patch for 5.1.0 branch? Thanks, Martin From 9814faae5ed8a3ffc48932e514648aba559055ea Mon Sep 17 00:00:00 2001 From: mliska Date: Tue, 12 May 2015 16:46:08 +0200 Subject: [PATCH] Fix test case. gcc/testsuite/ChangeLog: 2015-05-12 Martin Liska * g++.dg/ipa/pr65557.C: Remove unnecessary dump flag. --- gcc/testsuite/g++.dg/ipa/pr65557.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/g++.dg/ipa/pr65557.C b/gcc/testsuite/g++.dg/ipa/pr65557.C index 2250bb0..98471a3 100644 --- a/gcc/testsuite/g++.dg/ipa/pr65557.C +++ b/gcc/testsuite/g++.dg/ipa/pr65557.C @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -fdump-ipa-icf-details" } */ +/* { dg-options "-O2" } */ struct S0 { -- 2.1.4