From patchwork Mon Mar 30 11:10:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 456067 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C16B81400DE for ; Mon, 30 Mar 2015 22:10:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=n/8K5A8V; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; q=dns; s=default; b=NXITGS1qB5QmYwb+z4Lh4eJtXGLfwCRZrac9OarLiC9 PjHjmQTyM3jKEG6qYiY0kzhDVKb6Cr21hBdTTjvc5a6/Euu+SchinboGBc8utJBR 7zcbSq3raeAJQGYH2rBMzx6p1KQ29pt+tFgcnwdGHrhL+vxC3E/o30qG1sxWQmg8 = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; s=default; bh=mP0WtxB9vsB0ZGBVgwkssNOS2WE=; b=n/8K5A8VjwPW39L82 s4vE2/xsicwhCKD/TQvlOSGfHM0RXkseqW0Jcq8k8MO3pPXcUyoIJSzkZkFsiET9 ztiv24zt+szJMWWMBv2xHqsumA0dVJNxlZxyb0XkCYAa6AErrW+2khM8YrqYzf4f O9uHsF5LoDax8WOZYugTrl54Xs= Received: (qmail 28204 invoked by alias); 30 Mar 2015 11:10:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 28191 invoked by uid 89); 30 Mar 2015 11:10:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 30 Mar 2015 11:10:15 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7686E75013; Mon, 30 Mar 2015 11:10:12 +0000 (UTC) Message-ID: <55192F13.8050002@suse.cz> Date: Mon, 30 Mar 2015 13:10:11 +0200 From: =?UTF-8?B?TWFydGluIExpxaFrYQ==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: GCC Patches CC: Jan Hubicka Subject: [PATCH] Fix PR ipa/65557 X-IsSubscribed: yes Hello. Following patch fixed the issue, where we have to check if function summary for IPA CP has been already created. Tested on x86_64-linux-pc w/o any new regression introduced. Ready for trunk? Thanks, Martin From c33680093e67328863836a845e847bf1b1b23d0e Mon Sep 17 00:00:00 2001 From: mliska Date: Sun, 29 Mar 2015 20:20:33 +0200 Subject: [PATCH] Fix PR65557. gcc/ChangeLog: 2015-03-29 Martin Liska PR ipa/65557 * ipa-icf.c (sem_function::equals_wpa): Check if IPA CP has already filled up function summary. gcc/testsuite/ChangeLog: 2015-03-29 Martin Liska * g++.dg/ipa/pr65557.C: New test. --- gcc/ipa-icf.c | 2 +- gcc/testsuite/g++.dg/ipa/pr65557.C | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/ipa/pr65557.C diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c index ad868e1..ee7dabe 100644 --- a/gcc/ipa-icf.c +++ b/gcc/ipa-icf.c @@ -534,7 +534,7 @@ sem_function::equals_wpa (sem_item *item, if (opt_for_fn (decl, flag_devirtualize) && (TREE_CODE (TREE_TYPE (decl)) == METHOD_TYPE || TREE_CODE (TREE_TYPE (item->decl)) == METHOD_TYPE) - && (!flag_ipa_cp + && (ipa_node_params_sum == NULL || ipa_is_param_used (IPA_NODE_REF (dyn_cast (node)), 0)) && compare_polymorphic_p ()) diff --git a/gcc/testsuite/g++.dg/ipa/pr65557.C b/gcc/testsuite/g++.dg/ipa/pr65557.C new file mode 100644 index 0000000..2250bb0 --- /dev/null +++ b/gcc/testsuite/g++.dg/ipa/pr65557.C @@ -0,0 +1,19 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-ipa-icf-details" } */ + +struct S0 +{ + S0 () + { + } +}; + +struct S1 +{ + S1 () + { + } +}; + +S0 s0; +S1 s1; -- 2.1.4